All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gautam Dawar <gdawar@xilinx.com>
To: Jason Wang <jasowang@redhat.com>,
	"mst@redhat.com" <mst@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "lulu@redhat.com" <lulu@redhat.com>
Subject: RE: [PATCH 2/2] vhost-vdpa: remove the unused vhost_vdpa_get_acked_features()
Date: Sat, 5 Jun 2021 17:19:33 +0000	[thread overview]
Message-ID: <BY5PR02MB6980AA337402F4FBD3F14301B13A9@BY5PR02MB6980.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20210602033127.40149-2-jasowang@redhat.com>

No user for this helper, let's remove it.

[GD>>]  These patches seem unrelated to me. Do you think they should be part of one patch series?

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 include/net/vhost-vdpa.h | 1 -
 net/vhost-vdpa.c         | 9 ---------
 2 files changed, 10 deletions(-)

diff --git a/include/net/vhost-vdpa.h b/include/net/vhost-vdpa.h index 45e34b7cfc..b81f9a6f2a 100644
--- a/include/net/vhost-vdpa.h
+++ b/include/net/vhost-vdpa.h
@@ -15,7 +15,6 @@
 #define TYPE_VHOST_VDPA "vhost-vdpa"
 
 struct vhost_net *vhost_vdpa_get_vhost_net(NetClientState *nc); -uint64_t vhost_vdpa_get_acked_features(NetClientState *nc);
 
 extern const int vdpa_feature_bits[];
 
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index fe659ec9e2..8dc86332a6 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -66,15 +66,6 @@ VHostNetState *vhost_vdpa_get_vhost_net(NetClientState *nc)
     return s->vhost_net;
 }
 
-uint64_t vhost_vdpa_get_acked_features(NetClientState *nc) -{
-    VhostVDPAState *s = DO_UPCAST(VhostVDPAState, nc, nc);
-    assert(nc->info->type == NET_CLIENT_DRIVER_VHOST_VDPA);
-    s->acked_features = vhost_net_get_acked_features(s->vhost_net);
-
-    return s->acked_features;
-}
-
 static int vhost_vdpa_net_check_device_id(struct vhost_net *net)  {
     uint32_t device_id;
--
2.25.1



  reply	other threads:[~2021-06-05 17:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02  3:31 [PATCH 1/2] vhost-vdpa: don't initialize backend_features Jason Wang
2021-06-02  3:31 ` [PATCH 2/2] vhost-vdpa: remove the unused vhost_vdpa_get_acked_features() Jason Wang
2021-06-05 17:19   ` Gautam Dawar [this message]
2021-06-08  2:36     ` Jason Wang
2021-06-02  7:38 ` [PATCH 1/2] vhost-vdpa: don't initialize backend_features Gautam Dawar
2021-06-02  8:48   ` Jason Wang
2021-06-04  9:10     ` Gautam Dawar
2021-06-08  2:34       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR02MB6980AA337402F4FBD3F14301B13A9@BY5PR02MB6980.namprd02.prod.outlook.com \
    --to=gdawar@xilinx.com \
    --cc=jasowang@redhat.com \
    --cc=lulu@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.