From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 94F9C986312 for ; Thu, 22 Jul 2021 11:09:24 +0000 (UTC) From: Srivatsa Vaddagiri Date: Thu, 22 Jul 2021 11:09:16 +0000 Message-ID: References: , In-Reply-To: MIME-Version: 1.0 Subject: Re: [virtio-dev] [PATCH] virtio-mmio: Specify wait needed in driver during reset Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BY5PR02MB7073904F2843A1FE0860DFD9F9E49BY5PR02MB7073namp_" To: Jason Wang , "mst@redhat.com" , "virtio-dev@lists.oasis-open.org" Cc: Trilok Soni , Pratik Patel List-ID: --_000_BY5PR02MB7073904F2843A1FE0860DFD9F9E49BY5PR02MB7073namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > > This is following up on the discussion we had earlier on MMIO reset > > behavior: > > > > https://lists.oasis-open.org/archives/virtio-dev/202107/msg00012.html > > > > > > Suggesting below change to spec to make it explicit what's expected in > > driver. If this is accepted, I will follow up with a patch to Linux > > driver. > > > > =3D=3D=3D > > > > Device reset is accomplished by writing 0 to Status register. > > Explicitly note > > that a driver needs to wait on Status register read returning 0 before > > assuming that > > device reset operation is complete. > > Signed-off-by: Srivatsa Vaddagiri > > > > I wonder if it deserves a feature bit. I see this as fixing a bug in spec/code rather than adding any new feature,= so perhaps no. - vatsa --- Qualcomm Innovation Center, Inc. is submitting the attached "feedback" as a= non-member to the virtio-dev mailing list for consideration and inclusion. --_000_BY5PR02MB7073904F2843A1FE0860DFD9F9E49BY5PR02MB7073namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
> > This is following up on the discussion we had earlier on MMIO res= et
> > behavior:
> >
> > https://lists.oasis-open.org/archives/virtio-dev/202107/msg0= 0012.html
> > <https://lists.oasis-open.org/archives/virtio-dev/202107/= msg00012.html>
> >
> > Suggesting below change to spec to make it explicit what's e= xpected in
> > driver. If this is accepted, I will follow up with a patch t= o Linux
> > driver.
> >
> > =3D=3D=3D
> >
> > Device reset is accomplished by writing 0 to Status register= .
> > Explicitly note
> > that a driver needs to wait on Status register read returnin= g 0 before
> > assuming that
> > device reset operation is complete.
> > Signed-off-by: Srivatsa Vaddagiri <svaddagi@qti.qualcomm.= com>
>
>
>
> I wonder if it deserves a feature bit.

I see this as fixing a bug in spec/code rather than adding any new fea= ture, so
perhaps no.

- vatsa

---

Qualcomm Innovation Center, Inc. is submitting the attached "feedbac= k" as a non-member to the virtio-dev mailing list for consideration an= d inclusion.

--_000_BY5PR02MB7073904F2843A1FE0860DFD9F9E49BY5PR02MB7073namp_--