From: Srivatsa Vaddagiri <svaddagi@qti.qualcomm.com>
To: Jason Wang <jasowang@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
"mst@redhat.com" <mst@redhat.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>
Cc: Trilok Soni <tsoni@quicinc.com>, Pratik Patel <pratikp@quicinc.com>
Subject: Re: [virtio-dev] [PATCH] virtio-mmio: Specify wait needed in driver during reset
Date: Thu, 22 Jul 2021 15:41:49 +0000 [thread overview]
Message-ID: <BY5PR02MB7073E8361281BB624E320FA4F9E49@BY5PR02MB7073.namprd02.prod.outlook.com> (raw)
In-Reply-To: <f2b9203c-faaf-9aba-faad-0df2c199cb94@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
> >> I wonder if it deserves a feature bit.
> > Not sure what that feature bit should govern; if it is not negotiated,
> > the device must assume that the driver considers the reset to be
> > complete right after writing? I'm not sure what the device is supposed
> > to do then.
>
>
> The (hardware) device can refuse the feature negotiation if driver
> doesn't support the feature.
>
> This makes sure the driver is not broken by the device.
Let me send the next patch with a new feature bit added. I guess I can use bit
40 for it (VIRTIO_F_MMIO_RESET_WAIT)?
- vatsa
---
Qualcomm Innovation Center, Inc. is submitting the attached "feedback" as a
non-member to the virtio-dev mailing list for consideration and inclusion.
[-- Attachment #2: Type: text/html, Size: 1400 bytes --]
next prev parent reply other threads:[~2021-07-22 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 9:19 [virtio-dev] [PATCH] virtio-mmio: Specify wait needed in driver during reset Srivatsa Vaddagiri
2021-07-22 9:26 ` Jason Wang
2021-07-22 10:57 ` Cornelia Huck
2021-07-22 12:53 ` Jason Wang
2021-07-22 15:41 ` Srivatsa Vaddagiri [this message]
2021-07-22 11:09 ` Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR02MB7073E8361281BB624E320FA4F9E49@BY5PR02MB7073.namprd02.prod.outlook.com \
--to=svaddagi@qti.qualcomm.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pratikp@quicinc.com \
--cc=tsoni@quicinc.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.