From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ED8CC25B0E for ; Tue, 16 Aug 2022 14:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230281AbiHPOcp (ORCPT ); Tue, 16 Aug 2022 10:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbiHPOcj (ORCPT ); Tue, 16 Aug 2022 10:32:39 -0400 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19759BBA4C; Tue, 16 Aug 2022 07:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1660660356; x=1692196356; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=KXqWqj/4IaMbscxPRfXUiOf6m0+364cRxcaJOveEdsk=; b=qE2ZCQh94kbgMHNq2L44uK7F/TWNd8Oy3lJQ99VIIhn1e/MVkeIGfzJq 7u2znbfsNIXORfbUEhM7z7tO5xeWkM6nODkfEFOmty7s2AropK1tQJ422 Xb4Ri0W6Gz9NWBGM6h7q50uIFLb4BDf9tq2VBb3+juNFgM9OEPlKyS3rI gZZXWyDmDLAoi0SB7QYPIdhSSE8UBCw+IJwh+SiN0c9CSRMp+lVZboQl3 qSmP1huGzh9I+Oo2ABSm/ltEhzey0VIu9kbgi4s8pWnHGkRSCf77mBsp9 p6Dia+IbIS+MU7CAokDbjDxcZ4EGDFUEWZ7NN816R0kO4XlM+sV2Qaa48 g==; X-IronPort-AV: E=Sophos;i="5.93,241,1654531200"; d="scan'208";a="213934609" Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hgst.iphmx.com with ESMTP; 16 Aug 2022 22:32:35 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cVMNEkr2cK9TTc/RhD1MoUihNs18la2PF7X5MCAiCW0d5CY3+PYydXpiBCmtDKaCLAtEZJ+sSMwTB0LIWRxit+KnUUEyxXZb+CaUVQugCNkXN+aQjgbcMxrjguVNwZkDRfHmF7leCego4wYI4DvR50sMI6CZe+PTF28fWoC1XW0DgKuq2q4Bv6MdMUfnp/UD7qME1f5QtYWtvSNQ0iMf2vPZcVvVuIdsWb9H44fKUDEPEcAEJ/K1tHOPjLB1jnKUOgZxhsiOufiSAVf+5YJphu8I3s+D7P3GG/ZJ9AIzeZyaZAwwM8+SjrJkIfeIBUeLx7u+kIXwqVqSFBk/Ovuwow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KXqWqj/4IaMbscxPRfXUiOf6m0+364cRxcaJOveEdsk=; b=gJ3Wrc/x8spRPVG66FxfmCbLPVaQ6elxMKQW+N82qzEP5Q4z+2rwvObPwdmKm2Hvjg3HI/NJdVDpkh3Jt/Dxlxu3qu0uIE7Yf1eC2zAny3FvxYhN6bw5Z0B/6BUVJCE2bbigDl09C9TIjngRcGFfquSyH9VygJnygSB62GbzJrBxU/2uV0+oBisrPGatGeYMo4JIrsHGXAks0Zd5gFozjzFJP14qVs+yHgv34wqvtv+pmhLE4BMjREjhtsWgdjvMl84ruzhq6GByGA+PYNV7GOZ5hLvInqLwPH+pjeIQJKTQVrc59LkmX0CoEV9Ypbl18g02Zq2453qajkjwcrSU2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KXqWqj/4IaMbscxPRfXUiOf6m0+364cRxcaJOveEdsk=; b=xfs7zIQzq6rNK4leXm3db/V205+N1BgZJ7+C62evFZACMbcnnndnebRH92xpK1udgzMfsuoC+5Olb/31aRfdM4US7811Ws/WgiDUIx05+gpcnUnOkT03gC3f1FlWMhToPwas5DMGZrL0Cfj8bqvmv/S7ZgYg2T2FIJeMS9+lUyI= Received: from BY5PR04MB6327.namprd04.prod.outlook.com (2603:10b6:a03:1e8::20) by BN6PR04MB0677.namprd04.prod.outlook.com (2603:10b6:404:d2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Tue, 16 Aug 2022 14:32:34 +0000 Received: from BY5PR04MB6327.namprd04.prod.outlook.com ([fe80::d025:4966:3f9b:9117]) by BY5PR04MB6327.namprd04.prod.outlook.com ([fe80::d025:4966:3f9b:9117%8]) with mapi id 15.20.5525.011; Tue, 16 Aug 2022 14:32:34 +0000 From: Arthur Simchaev To: Daniil Lunev CC: "James@vger.kernel.org" , "E.J.Bottomley@vger.kernel.org" , "jejb@linux.vnet.ibm.com" , "Martin@vger.kernel.org" , "K.Petersen@vger.kernel.org" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Bean@vger.kernel.org" , "Huo@vger.kernel.org" , "beanhuo@micron.com" Subject: RE: [PATCH] scsi: ufs-bsg: Remove ufs_bsg_get_query_desc_size function Thread-Topic: [PATCH] scsi: ufs-bsg: Remove ufs_bsg_get_query_desc_size function Thread-Index: AQHYhKDynvKkVtaQm0SrWhB5D1T9dq2kYf+AgA2FIAA= Date: Tue, 16 Aug 2022 14:32:34 +0000 Message-ID: References: <1655727966-31584-1-git-send-email-Arthur.Simchaev@wdc.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wdc.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 00a8ea85-6762-43bd-cb04-08da7f9428de x-ms-traffictypediagnostic: BN6PR04MB0677:EE_ wdcipoutbound: EOP-TRUE x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bCnBu5Tpv6zUC/NMsiVcPIIZhl17UJBRGsVmn95M+J8Qn1/Md2l91kqOtkSCVsfx6GjhdVwqWCdbhgrenzTuerW51dKCCKtJyghTdDO4IsWgPiNxUCu1dE5n61iq/BDO9VOMCnZNOTQwX1uzUABdn2IotQ/chw1C9RxUzk5TEiwy5j/jZPNHBgOnoR6e69OIxlAiNmHfPkF7PeBjfSTdpNO2VGU3nkxxZxHR1+3D76+j+aS6ymEmu681E7IJ1bul/XWeq5bp6ziYzJl95QEUZ2s6JfPJLYHHSZcdT7dkEb9HSKKZAE7q3bGXjcdB+jsZTIxCZVVKXKorXhH2nUgEEoDDIhqRk9mLpx7kpeTqGtxVx3c+MH3hSoxrMQDzztjGF/8MZ3CDYoED8ZdPVQq8bojiCAyoXDjnp9qEdViND313qVxjTA1UMGxL9eAia0vbhgQyn/wt9JtC0KWJUBn5wGOY9Bwtw17H2gHd4+OCpPQLv34nbcDOn6pdlJBHPUse5caPMyJX858dsBNQAyW41q2jEmAvgYauXlaeblNg5Q2YmqPyogBxKXck0LecWVnmX8s5nDCH8zbQT8U79BGTcsuD7/S6jDRV3osq64GeEAfss9eiNJNr4EPnPcsQmWBxZ7iIz1Cxi/0YjtCze8qZGtbQDlvKJLvr5DFdmMNXPHwjYnY7RZwo4I+VcRx5jhsB5O7GoQsHUBO1UxqsWO7P9wO5f2D7LMbDpYvpOQHoIOcoLqmZCStYCSrVyONHTm4nPkLnu1tinjMN3TnCRSEphXEDBoCdNZXlmjsickVlQ2jIVr9onUs1+UT4Wm3ZEkpN x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR04MB6327.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(39860400002)(396003)(376002)(346002)(478600001)(186003)(64756008)(5660300002)(52536014)(6506007)(55016003)(83380400001)(6916009)(8936002)(54906003)(86362001)(41300700001)(7416002)(38070700005)(82960400001)(33656002)(71200400001)(26005)(122000001)(76116006)(8676002)(4326008)(66556008)(38100700002)(66446008)(2906002)(66946007)(9686003)(316002)(7696005)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?28CabA3RTZQrywnkk1WpXJFDXn+Dg7Kud56Y3/XeVdbbzTwPrU+lopH7g28b?= =?us-ascii?Q?/0wm6VFAJ3QeL4D89aEVHHBvuvVbRkqlUbLDz9HHmxSIEK6Yjn6h5lhmnIa2?= =?us-ascii?Q?bEz/+0oNPtOC7WyFnNo7M3OHOlDvzekDEgg6xQLnHojjOke66jRfLMZcfI4F?= =?us-ascii?Q?Tq7MofVbxx3DFbj4zm3FDIxvvwjlnIvmoFpaUwx7fTDSfwpm4/YLjJoYFXOj?= =?us-ascii?Q?55/GUbBLRlhzD0rM7bOg6EvxjzArXNopUt8U1nD8XR26KFG2A6+OuII7cHB0?= =?us-ascii?Q?IQrenOfQnujFNYxm2XpcWE5g7ySDnw3tGI2CfIbKaavu1XxQCtIpfRiVjM3G?= =?us-ascii?Q?1wsUgUaVUmwmFBeaxxQE2Oqv+uFWtY2JG107OBsXyagjYG31+b9IuK5q5esr?= =?us-ascii?Q?J4e/PdN/XLDn+n6Wp5w7hFyKWJviqw9in7SV6oRplvbSBJtYVPewJ8rpxn2d?= =?us-ascii?Q?uQf7tT/IOzyiRALrX36ifD3mJlbRuZAUYS81bk0M5PEECCucoJtvnytQCfnA?= =?us-ascii?Q?5qL3ub1VQWAxGHBxTXfTebPqSSR8iOjBkYWAaztP2gHWqE1GZNvvpR01XH72?= =?us-ascii?Q?xbk/AQV1Z9Fo9A4Flc5ELu6WDtWl7/H+yCHs+kGxV7MRYkwvvXCe5qqRIPOQ?= =?us-ascii?Q?JGYfhl0vrgN+icWydnovYL+RXpITqeICEF3VZN8U6NIv4hi26c9Sw1dD6T1+?= =?us-ascii?Q?B6vJOWensr0DyGwGw7qxw+m5GdNG+zxySYPHu4+7/I9+7N9Nty8qdVlH/8xG?= =?us-ascii?Q?FDmZsQZODOjagQhYtTLwxRvg3cdZY4UmB6+JM/GKcCoE3Drh8WioffcJbQiN?= =?us-ascii?Q?eXz+gS236jQEDeAu1fyfHjCg32lPxVlV/FgHCIoniD4CMvqX62xFW7Uhy/vA?= =?us-ascii?Q?vMV+MGTo4M915NUuQqza7ZvCPZehyixv+ky5oIhoagnOwDwP3Fx/cRWM7JPD?= =?us-ascii?Q?Q1zj5qDKd2LPKnp42n27JmcbLJhJG57bh9yDPS/vBL2VtUmdXF4KD7GMpAjo?= =?us-ascii?Q?QgVEQJet897rbWjPm0oYTgkf6grWD7klY02sBR3PD6qAEEarqVbqp5No9l8x?= =?us-ascii?Q?LkURxV8wIoeoYCDm6frlhPq78Laz7fXDFGHE2+AxFNlSZUE7v0qH3EzGiwQw?= =?us-ascii?Q?NbtxS8G7gJLN1zFWTuvHEJhZFu50enjLUvO5GJAwoQywEVpx2I+UuGLSuudQ?= =?us-ascii?Q?JBcWK07xUWIQvprcBmrQ08xtyTh3iKoNpyRzcHFX4pWTjG+NeEzIfHMpyq/C?= =?us-ascii?Q?mj4mNztSSByjs0BAF1jsgTEsPH9JR+byEsm6nRjdtu9FBF98B0ltJuHQ36Qc?= =?us-ascii?Q?eMkScfBIpgAiy8fG0TKUiesojURHIn3aCRE5yy7Ax5n6bEgEzPlHkCPcXi+R?= =?us-ascii?Q?s714hip2ud97OXwFP1BeBXyE+NqneUOCE24IcK62IpgknbCL7y1RrfN2+aSi?= =?us-ascii?Q?7swqXgmMuLQJ0oeYyjopqgamrjXgTmr/FhGeFDZ6BHWInf0awxd+B4xWaI4G?= =?us-ascii?Q?os7Rh3uMx66zvoxoPRM7D/M+z+ulNl+vpgpBukIODKWMwh+sMUrYrafxvzb9?= =?us-ascii?Q?v3VlIgKEKJ8PP7Fw1klYCLXBsPBvQ2ilVr4An2AL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?O113iX2Qug5w2Ki2mSv+s9ISgT25RffGbfM569AA8kiTK4YDEF1bkl1ABjUU?= =?us-ascii?Q?CBcj5SG+YpYU/NS2tGKLmlBxDt0k1R5MGncYZ1dSeum4/MPXlxYQ6gBqFNSG?= =?us-ascii?Q?hGUNZ1p5QYyzVqQ9CXowzUl4jWm708x0DFwc+z2C8aapwFhPN2IT+3TKQZ8E?= =?us-ascii?Q?QloGA8akhG232N4Sj6uI5LTBO5tWEddDn9KPBO8b2DwT9M8UDWBD5CiS8VTI?= =?us-ascii?Q?ytFjEX+dHvCzwK3GSNHQDRmqIep9FvfKF2QUdy05RpoiOw3rYsR8C1ph7jUZ?= =?us-ascii?Q?13jrou7dGYip2L+OqrVU0CEOy7lVQ0GIE0lb019mtvcSJU6uwABk6PbWEgPA?= =?us-ascii?Q?ubGUBP2cUiX776rkcGsJ63sPErFlKVmIDo4pY602Iy3QvWVY6H1gvSY4WHHr?= =?us-ascii?Q?JkvoZvxec+2yQ5Y0xPRC38E8uRfFED5FHfVyDOXLy3/9RSqPwbQ1/YwS0XUp?= =?us-ascii?Q?duoZbCU+ZdP8+wdLS+8ow2rpzsSM6lUQpwoWDA9kfqguOyUqVwDrOLcTWcnW?= =?us-ascii?Q?NfJI8Sgc24uVqA/7/fzOoGdUAyQFM8n3NWSvh6te/Y36OV2NkRqOW5f5MYNe?= =?us-ascii?Q?/yNSoT/Otoafa9QhuYVuGrrZMjTaobbLEU55C3uXh2aVbZLAAEt7DGYRXvXL?= =?us-ascii?Q?zLTYE/i5rFK22n+KEwpptOQhudSeQ8rJM79QbdtwJJNoIVaL80nbmIJcLJwi?= =?us-ascii?Q?RoD2Ik3T04pmFpS2szJ8j1qjqAwh1NdY0FYTuPJmTSNx02RMcASXkQ2DyUJe?= =?us-ascii?Q?G2Shj7HSKWAN51tp7koQqQt2ZizE1XB1Vj8vM4WwcK0wayeI7HnmSXS5Eysk?= =?us-ascii?Q?xXvVo/XW//Ll3OCrQL5e12IZZlBKX73UAmOzGSMVXDbW4WVcJFEzaKhZ9GEH?= =?us-ascii?Q?WgrVw4FsnZ6wW4Dc+PKO9XJpPo81kOk8VfBBUfOCIF/Se0PtTLgJwYwuaT73?= =?us-ascii?Q?ER8shQb947pt/qtpUt9g913Me+5xKrzpIpgpM8PboUSwfkWk8vMjoG41Zvfk?= =?us-ascii?Q?9cBxd2TNmfbwH/TNwyBvEWSuWA8hVbyIfx5oJ5lIqbqJG2u++58TiG5Jyu74?= =?us-ascii?Q?iGXbWlmQZFZJoVk7u1/+8A3Xvj4Q3uK28DuJee2wK/Y9kV8H6I6tPFK4Junz?= =?us-ascii?Q?wNcB8ojqRnXX+6RXkTtFZLhkJ++pqii2Cpbg6pNo7fYbs8Yd3i8OKEtbpseW?= =?us-ascii?Q?eey7aW4D83M9sImA2SVjqfsui7QjLPRGpU5VHi85yyl8LdSLpX9TSDEjObq7?= =?us-ascii?Q?yC4cjc0SySu8dQprSThuj0O1XbxVUKNRmSTD85xFsoQJcAGmuzStce8rcXZw?= =?us-ascii?Q?BlBmlBWZ5c4caR13enKKDhWvMnjExe0XM6rntktW97BbzizE2MoaHwtEs4HW?= =?us-ascii?Q?Mhy0S10a/AWwCPro6YiDjxFIxRmlbWklfquJ79eq2+AivI3SXYnjz3eYQg8a?= =?us-ascii?Q?a1ZcF+fZqw8=3D?= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6327.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00a8ea85-6762-43bd-cb04-08da7f9428de X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2022 14:32:34.3298 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SIhaqZ+T5uTSTA33S+SPQrpONZm05vS4pG8SwhyXZtyk+14n60FZ+iWZxBb13LMxUGbPuaNqlzzmiyR1aTVsQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0677 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniil, Thanks a lot for your review. > Can you clarify what you mean "hard-coded"? The descriptor size is initia= lized > as QUERY_DESC_MAX_SIZE, and updated in `ufshcd_update_desc_length`, > which is > called with the actual size upon finishing `ufshcd_read_desc_param`. >=20 > The function you are removing - `ufs_bsg_get_query_desc_size` - doesn't s= eem > to > reject requests on incompatible size, only to restrict the size of the qu= ery. > The way the code is written - if I read it right - will lead to truncatio= n of > the response if the size of the requested response is less than the actua= l > descriptor size, but otherwise you should get full descriptor back. >=20 > Can you provide a specific example where you see the problem to arise? Reading a new UFS descriptors will be rejected due to hard coded descriptor= definitions in ufshcd_map_desc_id_to_length invoked from ufs_bsg_get_query_desc_size.=20 For example FBO descriptor published in Jedec UFS 4.0 spec and already exis= t in some UFS devices. Or others reserved descriptors which can be used as vendor's descriptor. We should be able to read any UFS descriptor of any size (up to QUERY_DESC_= MAX_SIZE). According to the spec, the device will return the actual size. The ufs bsg driver should not impose any such limitation. It's one of its d= esign guidelines. E.g. as done for the attributes, flags the kernel doesn't check it size(for= attributes is the max - 4 bytes),=20 nor access (read/write). And just returns an appropriate error code should an error occur. Regards Arthur