From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tan, Ley Foon <ley.foon.tan@intel.com>
Date: Thu, 12 Nov 2020 10:51:37 +0000
Subject: [v3 08/16] net: designware: socfpga: Add ATF support for MAC
 driver
In-Reply-To: <20201015122955.10259-9-elly.siew.chin.lim@intel.com>
References: <20201015122955.10259-1-elly.siew.chin.lim@intel.com>
 <20201015122955.10259-9-elly.siew.chin.lim@intel.com>
Message-ID: <BY5PR11MB38933172D7C0527255AE4245CCE70@BY5PR11MB3893.namprd11.prod.outlook.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



> -----Original Message-----
> From: Lim, Elly Siew Chin <elly.siew.chin.lim@intel.com>
> Sent: Thursday, October 15, 2020 8:30 PM
> To: u-boot at lists.denx.de
> Cc: Marek Vasut <marex@denx.de>; Tan, Ley Foon
> <ley.foon.tan@intel.com>; See, Chin Liang <chin.liang.see@intel.com>;
> Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>; Chee, Tien Fong
> <tien.fong.chee@intel.com>; Westergreen, Dalon
> <dalon.westergreen@intel.com>; Simon Glass <sjg@chromium.org>; Ang,
> Chee Hong <chee.hong.ang@intel.com>; Lim, Elly Siew Chin
> <elly.siew.chin.lim@intel.com>
> Subject: [v3 08/16] net: designware: socfpga: Add ATF support for MAC
> driver
> 
> From: Chee Hong Ang <chee.hong.ang@intel.com>
> 
> In non-secure mode (EL2), MAC driver calls the SMC/PSCI services provided
> by ATF to setup the PHY interface.
> 
> Signed-off-by: Chee Hong Ang <chee.hong.ang@intel.com>
> Signed-off-by: Siew Chin Lim <elly.siew.chin.lim@intel.com>
> ---
>  drivers/net/dwmac_socfpga.c | 30 ++++++++++++++++++++++++++----
>  1 file changed, 26 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/dwmac_socfpga.c b/drivers/net/dwmac_socfpga.c
> index e93561dffa..a2d09d5c4a 100644
> --- a/drivers/net/dwmac_socfpga.c
> +++ b/drivers/net/dwmac_socfpga.c
> @@ -17,7 +17,9 @@
>  #include <dm/device_compat.h>
>  #include <linux/err.h>
> 
> +#include <asm/arch/smc_api.h>
>  #include <asm/arch/system_manager.h>
> +#include <linux/intel-smc.h>
Move this to after <linux/err.h>. 
> 
>  struct dwmac_socfpga_platdata {
>  	struct dw_eth_pdata	dw_eth_pdata;
> @@ -64,6 +66,27 @@ static int dwmac_socfpga_ofdata_to_platdata(struct
> udevice *dev)
>  	return designware_eth_ofdata_to_platdata(dev);
>  }
> 
> +static int dwmac_socfpga_do_setphy(struct udevice *dev, u32 modereg) {
> +	struct dwmac_socfpga_platdata *pdata = dev_get_platdata(dev);
> +
> +#if !defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_ATF)
> +	u64 args[2];
> +
> +	args[0] = ((u64)pdata->phy_intf - socfpga_get_sysmgr_addr() -
> +		   SYSMGR_SOC64_EMAC0) >> 2;
> +	args[1] = modereg;
> +
> +	if (invoke_smc(INTEL_SIP_SMC_HPS_SET_PHYINTF, args, 2, NULL, 0))
> +		return -EIO;
Can you if check ATF support this SMC call already? I didn't see it.


Regards
Ley Foon