From: "Marciniszyn, Mike" <mike.marciniszyn@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"Andrejczuk, Grzegorz" <grzegorz.andrejczuk@intel.com>
Cc: "Dalessandro, Dennis" <dennis.dalessandro@intel.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
"Weiny, Ira" <ira.weiny@intel.com>,
"Vishwanathapura,
Niranjana" <niranjana.vishwanathapura@intel.com>,
"Kacprowski, Andrzej" <Andrzej.Kacprowski@intel.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] IB/hfi1: Fix an error code in hfi1_vnic_init()
Date: Fri, 29 May 2020 13:34:06 +0000 [thread overview]
Message-ID: <BY5PR11MB3958CF61BB1F59A6F6B5234D868F0@BY5PR11MB3958.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200529100302.GC1304852@mwanda>
> From: Dan Carpenter <dan.carpenter@oracle.com>
> diff --git a/drivers/infiniband/hw/hfi1/vnic_main.c
> b/drivers/infiniband/hw/hfi1/vnic_main.c
> index b183c56b7b6a4..f89d0cb1c7204 100644
> --- a/drivers/infiniband/hw/hfi1/vnic_main.c
> +++ b/drivers/infiniband/hw/hfi1/vnic_main.c
> @@ -512,7 +512,8 @@ static int hfi1_vnic_init(struct hfi1_vnic_vport_info
> *vinfo)
> goto txreq_fail;
> }
>
> - if (hfi1_netdev_rx_init(dd)) {
> + rc = hfi1_netdev_rx_init(dd);
> + if (rc) {
> dd_dev_err(dd, "Unable to initialize netdev contexts\n");
> goto alloc_fail;
> }
Dan,
This is definitely wrong, but another call to hfi1_netdev_rx_init() exists in hfi1_vnic_up() that needs to be fixed.
Can you address that too?
Mike
next prev parent reply other threads:[~2020-05-29 13:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 10:03 [PATCH] IB/hfi1: Fix an error code in hfi1_vnic_init() Dan Carpenter
2020-05-29 10:03 ` Dan Carpenter
2020-05-29 13:34 ` Marciniszyn, Mike [this message]
2020-05-30 14:02 ` [PATCH v2] IB/hfi1: Fix hfi1_netdev_rx_init() error handling Dan Carpenter
2020-05-30 14:02 ` Dan Carpenter
2020-05-31 10:05 ` Leon Romanovsky
2020-05-31 10:05 ` Leon Romanovsky
2020-05-31 17:36 ` Dan Carpenter
2020-05-31 17:36 ` Dan Carpenter
2020-06-01 4:24 ` Leon Romanovsky
2020-06-01 4:24 ` Leon Romanovsky
2020-06-01 12:27 ` Jason Gunthorpe
2020-06-01 12:27 ` Jason Gunthorpe
2020-06-01 12:49 ` Wan, Kaike
2020-06-01 12:49 ` Wan, Kaike
2020-06-01 14:14 ` Jason Gunthorpe
2020-06-01 14:14 ` Jason Gunthorpe
2020-06-01 18:01 ` Dan Carpenter
2020-06-01 18:01 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB3958CF61BB1F59A6F6B5234D868F0@BY5PR11MB3958.namprd11.prod.outlook.com \
--to=mike.marciniszyn@intel.com \
--cc=Andrzej.Kacprowski@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=grzegorz.andrejczuk@intel.com \
--cc=ira.weiny@intel.com \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=niranjana.vishwanathapura@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.