All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-28  4:27 ` Vidya Srinivas
  0 siblings, 0 replies; 33+ messages in thread
From: Vidya Srinivas @ 2021-05-28  4:27 UTC (permalink / raw)
  To: intel-gfx, igt-dev; +Cc: markyacoub, charlton.lin

Without wait for vblank, CRC mismatch is seen
between big and small CRC on few Gen11 systems.

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_big_fb.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b35727a09bd0..f90363c3beb2 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
 static bool test_plane(data_t *data)
 {
 	igt_plane_t *plane = data->plane;
+	igt_display_t *display = &data->display;
 	struct igt_fb *small_fb = &data->small_fb;
 	struct igt_fb *big_fb = &data->big_fb;
 	int w = data->big_fb_width - small_fb->width;
@@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
 		igt_display_commit2(&data->display, data->display.is_atomic ?
 				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
 
-
+		igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
 
 		igt_plane_set_fb(plane, big_fb);
 		igt_fb_set_position(big_fb, plane, x, y);
 		igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
 		igt_plane_set_size(plane, data->width, data->height);
 		igt_display_commit2(&data->display, data->display.is_atomic ?
 				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+		igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
 
 		igt_plane_set_fb(plane, NULL);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 33+ messages in thread
* [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-27 15:40 Vidya Srinivas
  0 siblings, 0 replies; 33+ messages in thread
From: Vidya Srinivas @ 2021-05-27 15:40 UTC (permalink / raw)
  To: intel-gfx, igt-dev; +Cc: markyacoub, charlton.lin

Without wait for vblank, CRC mismatch is seen
between big and small CRC on few Gen11 systems.

Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_big_fb.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b2027b6b9d1b..7d78ff829d41 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
 static bool test_plane(data_t *data)
 {
 	igt_plane_t *plane = data->plane;
+	igt_display_t *display = &data->display;
 	struct igt_fb *small_fb = &data->small_fb;
 	struct igt_fb *big_fb = &data->big_fb;
 	int w = data->big_fb_width - small_fb->width;
@@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
 		igt_display_commit2(&data->display, data->display.is_atomic ?
 				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
 
-
+		igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
 
 		igt_plane_set_fb(plane, big_fb);
 		igt_fb_set_position(big_fb, plane, x, y);
 		igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
 		igt_plane_set_size(plane, data->width, data->height);
 		igt_display_commit2(&data->display, data->display.is_atomic ?
 				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+		igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
 
 		igt_plane_set_fb(plane, NULL);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 33+ messages in thread
* [Intel-gfx] [PATCH] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-27 15:09 Vidya Srinivas
  2021-05-27 15:23 ` [Intel-gfx] [PATCH i-g-t] " Vidya Srinivas
  0 siblings, 1 reply; 33+ messages in thread
From: Vidya Srinivas @ 2021-05-27 15:09 UTC (permalink / raw)
  To: intel-gfx, igt-dev; +Cc: markyacoub, charlton.lin

Without wait for vblank, CRC mismatch is seen between
big and small CRC on some Gen11 systems

Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_big_fb.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b2027b6b9d1b..7d78ff829d41 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
 static bool test_plane(data_t *data)
 {
 	igt_plane_t *plane = data->plane;
+	igt_display_t *display = &data->display;
 	struct igt_fb *small_fb = &data->small_fb;
 	struct igt_fb *big_fb = &data->big_fb;
 	int w = data->big_fb_width - small_fb->width;
@@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
 		igt_display_commit2(&data->display, data->display.is_atomic ?
 				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
 
-
+		igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
 
 		igt_plane_set_fb(plane, big_fb);
 		igt_fb_set_position(big_fb, plane, x, y);
 		igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
 		igt_plane_set_size(plane, data->width, data->height);
 		igt_display_commit2(&data->display, data->display.is_atomic ?
 				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+		igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
 		igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
 
 		igt_plane_set_fb(plane, NULL);
-- 
2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 33+ messages in thread

end of thread, other threads:[~2021-06-15  8:50 UTC | newest]

Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28  4:27 [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC Vidya Srinivas
2021-05-28  4:27 ` [igt-dev] " Vidya Srinivas
2021-05-28 13:25 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Wait for vblank before collecting CRC (rev5) Patchwork
2021-05-28 22:58 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-04 18:50 ` [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC Mark Yacoub
2021-06-04 18:50   ` [igt-dev] " Mark Yacoub
2021-06-05  5:46   ` [Intel-gfx] " Srinivas, Vidya
2021-06-08  7:01 ` Modem, Bhanuprakash
2021-06-08  7:01   ` [igt-dev] " Modem, Bhanuprakash
2021-06-08  7:34   ` [Intel-gfx] [igt-dev] " Juha-Pekka Heikkila
2021-06-08  7:48     ` Srinivas, Vidya
2021-06-08  9:19       ` Srinivas, Vidya
2021-06-08  9:19         ` [igt-dev] [Intel-gfx] " Srinivas, Vidya
2021-06-08 11:50         ` [Intel-gfx] [igt-dev] " Juha-Pekka Heikkila
2021-06-08 11:50           ` [igt-dev] [Intel-gfx] " Juha-Pekka Heikkila
2021-06-08 11:54           ` [Intel-gfx] [igt-dev] " Srinivas, Vidya
2021-06-10  8:38           ` Srinivas, Vidya
2021-06-10  8:38             ` [igt-dev] [Intel-gfx] " Srinivas, Vidya
2021-06-10  8:51             ` [Intel-gfx] [igt-dev] " Petri Latvala
2021-06-10  8:51               ` [igt-dev] [Intel-gfx] " Petri Latvala
2021-06-10  8:52               ` [Intel-gfx] [igt-dev] " Srinivas, Vidya
2021-06-08  9:05     ` [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Use igt_pipe_crc_get_current instead of igt_pipe_crc_collect_crc Vidya Srinivas
2021-06-10  8:52       ` Juha-Pekka Heikkila
2021-06-10  8:53         ` Srinivas, Vidya
2021-06-15  8:28           ` Srinivas, Vidya
2021-06-15  8:50             ` Petri Latvala
2021-06-15  8:50               ` Srinivas, Vidya
2021-06-08 10:54 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Wait for vblank before collecting CRC (rev6) Patchwork
2021-06-08 15:28 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-10  5:01 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Wait for vblank before collecting CRC (rev7) Patchwork
2021-06-10  6:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2021-05-27 15:40 [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC Vidya Srinivas
2021-05-27 15:09 [Intel-gfx] [PATCH] " Vidya Srinivas
2021-05-27 15:23 ` [Intel-gfx] [PATCH i-g-t] " Vidya Srinivas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.