* [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
@ 2021-05-28 4:34 ` Vidya Srinivas
0 siblings, 0 replies; 15+ messages in thread
From: Vidya Srinivas @ 2021-05-28 4:34 UTC (permalink / raw)
To: intel-gfx, igt-dev; +Cc: markyacoub, charlton.lin
For Intel platforms, pitch needs to be 64 byte aligned.
Kernel code vgem_gem_dumb_create which is platform generic code
doesnt do the alignment. This causes frame buffer creation to fail
on Intel platforms where the pitch is not 64 byte aligned.
tests: test run on Intel platforms with panel resolution 1366x768
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_prime.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/kms_prime.c b/tests/kms_prime.c
index 8cb2ca2a9dc3..fdc941fe8100 100644
--- a/tests/kms_prime.c
+++ b/tests/kms_prime.c
@@ -51,6 +51,8 @@ static struct {
{ .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 },
};
+bool check_platform;
+
IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
static bool has_prime_import(int fd)
@@ -101,7 +103,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
scratch->bpp = 32;
scratch->handle = kmstest_dumb_create(exporter_fd,
- scratch->width,
+ check_platform? ALIGN(scratch->width, 64): scratch->width,
scratch->height,
scratch->bpp,
&scratch->pitch,
@@ -262,6 +264,7 @@ igt_main
/* ANY = anything that is not VGEM */
first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
+ check_platform = is_i915_device(first_fd);
igt_require(first_fd >= 0);
second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
@ 2021-05-28 4:34 ` Vidya Srinivas
0 siblings, 0 replies; 15+ messages in thread
From: Vidya Srinivas @ 2021-05-28 4:34 UTC (permalink / raw)
To: intel-gfx, igt-dev; +Cc: charlton.lin
For Intel platforms, pitch needs to be 64 byte aligned.
Kernel code vgem_gem_dumb_create which is platform generic code
doesnt do the alignment. This causes frame buffer creation to fail
on Intel platforms where the pitch is not 64 byte aligned.
tests: test run on Intel platforms with panel resolution 1366x768
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_prime.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/kms_prime.c b/tests/kms_prime.c
index 8cb2ca2a9dc3..fdc941fe8100 100644
--- a/tests/kms_prime.c
+++ b/tests/kms_prime.c
@@ -51,6 +51,8 @@ static struct {
{ .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 },
};
+bool check_platform;
+
IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
static bool has_prime_import(int fd)
@@ -101,7 +103,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
scratch->bpp = 32;
scratch->handle = kmstest_dumb_create(exporter_fd,
- scratch->width,
+ check_platform? ALIGN(scratch->width, 64): scratch->width,
scratch->height,
scratch->bpp,
&scratch->pitch,
@@ -262,6 +264,7 @@ igt_main
/* ANY = anything that is not VGEM */
first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
+ check_platform = is_i915_device(first_fd);
igt_require(first_fd >= 0);
second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
2021-05-28 4:34 ` [igt-dev] " Vidya Srinivas
(?)
@ 2021-05-28 14:23 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2021-05-28 14:23 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 5182 bytes --]
== Series Details ==
Series: tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
URL : https://patchwork.freedesktop.org/series/90718/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10146 -> IGTPW_5862
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/index.html
Known issues
------------
Here are the changes found in IGTPW_5862 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- {fi-hsw-gt1}: [DMESG-WARN][1] ([i915#3303]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@i915_selftest@live@execlists:
- fi-cfl-8109u: [DMESG-FAIL][3] ([i915#3462]) -> [INCOMPLETE][4] ([i915#3462])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
- fi-bsw-nick: [DMESG-FAIL][5] ([i915#3462]) -> [INCOMPLETE][6] ([i915#2782] / [i915#2940] / [i915#3462])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-bsw-nick/igt@i915_selftest@live@execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/fi-bsw-nick/igt@i915_selftest@live@execlists.html
- fi-tgl-u2: [INCOMPLETE][7] ([i915#3462]) -> [DMESG-FAIL][8] ([i915#3462])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-tgl-u2/igt@i915_selftest@live@execlists.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/fi-tgl-u2/igt@i915_selftest@live@execlists.html
* igt@runner@aborted:
- fi-kbl-x1275: [FAIL][9] ([i915#1436] / [i915#3363]) -> [FAIL][10] ([i915#1436] / [i915#2426] / [i915#3363])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-kbl-x1275/igt@runner@aborted.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/fi-kbl-x1275/igt@runner@aborted.html
- fi-cfl-8109u: [FAIL][11] ([i915#2426] / [i915#3363]) -> [FAIL][12] ([i915#3363])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-cfl-8109u/igt@runner@aborted.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/fi-cfl-8109u/igt@runner@aborted.html
- fi-glk-dsi: [FAIL][13] ([i915#3363] / [k.org#202321]) -> [FAIL][14] ([i915#2426] / [i915#3363] / [k.org#202321])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-glk-dsi/igt@runner@aborted.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/fi-glk-dsi/igt@runner@aborted.html
- fi-bdw-5557u: [FAIL][15] ([i915#3462]) -> [FAIL][16] ([i915#1602] / [i915#2029])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-bdw-5557u/igt@runner@aborted.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/fi-bdw-5557u/igt@runner@aborted.html
- fi-skl-6700k2: [FAIL][17] ([i915#1436] / [i915#3363]) -> [FAIL][18] ([i915#1436] / [i915#2426] / [i915#3363])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/fi-skl-6700k2/igt@runner@aborted.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/fi-skl-6700k2/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (44 -> 38)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-dg1-1 fi-bdw-samus fi-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6095 -> IGTPW_5862
CI-20190529: 20190529
CI_DRM_10146: eca2bdf0b1ad4250df25fda7ae2a5848c314264d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5862: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/index.html
IGT_6095: 5c7b7a8e441577a00cc4e71ec0ae57af640eb92a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/index.html
[-- Attachment #1.2: Type: text/html, Size: 7012 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
2021-05-28 4:34 ` [igt-dev] " Vidya Srinivas
(?)
(?)
@ 2021-05-29 0:57 ` Patchwork
-1 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2021-05-29 0:57 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 30279 bytes --]
== Series Details ==
Series: tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
URL : https://patchwork.freedesktop.org/series/90718/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10146_full -> IGTPW_5862_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5862_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5862_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5862_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/shard-glk3/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk3/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
New tests
---------
New tests have been introduced between CI_DRM_10146_full and IGTPW_5862_full:
### New IGT tests (1) ###
* igt@gem_media_fill@media-fill@smem:
- Statuses : 4 pass(s)
- Exec time: [0.00, 0.01] s
Known issues
------------
Here are the changes found in IGTPW_5862_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-2x:
- shard-tglb: NOTRUN -> [SKIP][3] ([i915#1839])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb5/igt@feature_discovery@display-2x.html
- shard-iclb: NOTRUN -> [SKIP][4] ([i915#1839])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb8/igt@feature_discovery@display-2x.html
* igt@feature_discovery@psr2:
- shard-iclb: NOTRUN -> [SKIP][5] ([i915#658]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb6/igt@feature_discovery@psr2.html
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-snb2/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_ctx_persistence@replace-hostile@vcs1:
- shard-iclb: [PASS][7] -> [FAIL][8] ([i915#2410])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/shard-iclb4/igt@gem_ctx_persistence@replace-hostile@vcs1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb4/igt@gem_ctx_persistence@replace-hostile@vcs1.html
* igt@gem_ctx_sseu@engines:
- shard-tglb: NOTRUN -> [SKIP][9] ([i915#280])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb7/igt@gem_ctx_sseu@engines.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-tglb: NOTRUN -> [FAIL][10] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb7/igt@gem_exec_fair@basic-none-vip@rcs0.html
- shard-iclb: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb6/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: NOTRUN -> [FAIL][12] ([i915#2842]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/shard-tglb8/igt@gem_exec_fair@basic-pace@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][15] -> [SKIP][16] ([fdo#109271])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/shard-kbl1/igt@gem_exec_fair@basic-pace@vecs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_params@no-blt:
- shard-tglb: NOTRUN -> [SKIP][17] ([fdo#109283]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb1/igt@gem_exec_params@no-blt.html
* igt@gem_exec_params@no-vebox:
- shard-iclb: NOTRUN -> [SKIP][18] ([fdo#109283]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb6/igt@gem_exec_params@no-vebox.html
* igt@gem_exec_reloc@basic-wide-active@bcs0:
- shard-glk: NOTRUN -> [FAIL][19] ([i915#2389]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk3/igt@gem_exec_reloc@basic-wide-active@bcs0.html
- shard-tglb: NOTRUN -> [FAIL][20] ([i915#2389]) +4 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb1/igt@gem_exec_reloc@basic-wide-active@bcs0.html
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][21] ([i915#2389]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-snb5/igt@gem_exec_reloc@basic-wide-active@rcs0.html
- shard-iclb: NOTRUN -> [FAIL][22] ([i915#2389]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb5/igt@gem_exec_reloc@basic-wide-active@rcs0.html
- shard-kbl: NOTRUN -> [FAIL][23] ([i915#2389]) +4 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl7/igt@gem_exec_reloc@basic-wide-active@rcs0.html
* igt@gem_mmap_gtt@big-copy-odd:
- shard-glk: NOTRUN -> [FAIL][24] ([i915#307])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk2/igt@gem_mmap_gtt@big-copy-odd.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
- shard-kbl: NOTRUN -> [INCOMPLETE][25] ([i915#3468])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl1/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
* igt@gem_mmap_gtt@cpuset-medium-copy-xy:
- shard-tglb: [PASS][26] -> [INCOMPLETE][27] ([i915#3468] / [i915#750])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/shard-tglb6/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb2/igt@gem_mmap_gtt@cpuset-medium-copy-xy.html
* igt@gem_mmap_gtt@fault-concurrent-y:
- shard-apl: NOTRUN -> [INCOMPLETE][28] ([i915#3468])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl2/igt@gem_mmap_gtt@fault-concurrent-y.html
* igt@gem_mmap_gtt@medium-copy-xy:
- shard-iclb: [PASS][29] -> [INCOMPLETE][30] ([i915#2502] / [i915#3468])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/shard-iclb8/igt@gem_mmap_gtt@medium-copy-xy.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb4/igt@gem_mmap_gtt@medium-copy-xy.html
* igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#768]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3323])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl7/igt@gem_userptr_blits@dmabuf-sync.html
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#3323])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb3/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#3297]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb7/igt@gem_userptr_blits@dmabuf-unsync.html
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#3297]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@gem_userptr_blits@input-checking:
- shard-kbl: NOTRUN -> [DMESG-WARN][36] ([i915#3002])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl7/igt@gem_userptr_blits@input-checking.html
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/shard-apl8/igt@gem_workarounds@suspend-resume-context.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl1/igt@gem_workarounds@suspend-resume-context.html
* igt@gen7_exec_parse@chained-batch:
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#109289]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb8/igt@gen7_exec_parse@chained-batch.html
* igt@gen9_exec_parse@batch-invalid-length:
- shard-snb: NOTRUN -> [SKIP][40] ([fdo#109271]) +297 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-snb2/igt@gen9_exec_parse@batch-invalid-length.html
* igt@gen9_exec_parse@bb-large:
- shard-apl: NOTRUN -> [FAIL][41] ([i915#3296])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl3/igt@gen9_exec_parse@bb-large.html
- shard-kbl: NOTRUN -> [FAIL][42] ([i915#3296])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl3/igt@gen9_exec_parse@bb-large.html
* igt@gen9_exec_parse@bb-start-param:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#112306]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@gen9_exec_parse@bb-start-param.html
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#112306])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb6/igt@gen9_exec_parse@bb-start-param.html
* igt@gen9_exec_parse@shadow-peek:
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#2856])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb7/igt@gen9_exec_parse@shadow-peek.html
- shard-iclb: NOTRUN -> [SKIP][46] ([i915#2856])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@gen9_exec_parse@shadow-peek.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#1904])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_dc@dc9-dpms:
- shard-tglb: NOTRUN -> [SKIP][48] ([i915#3288])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb7/igt@i915_pm_dc@dc9-dpms.html
- shard-iclb: NOTRUN -> [FAIL][49] ([i915#3343])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb8/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#1937])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@i915_pm_rc6_residency@media-rc6-accuracy:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#109289] / [fdo#111719])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb6/igt@i915_pm_rc6_residency@media-rc6-accuracy.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#110892])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb8/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_pm_sseu@full-enable:
- shard-tglb: NOTRUN -> [SKIP][53] ([fdo#109288])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@i915_pm_sseu@full-enable.html
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109288])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb6/igt@i915_pm_sseu@full-enable.html
* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271]) +244 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl2/igt@kms_big_fb@linear-16bpp-rotate-90.html
* igt@kms_big_fb@linear-8bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][56] ([fdo#111614]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb1/igt@kms_big_fb@linear-8bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#110725] / [fdo#111614]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb5/igt@kms_big_fb@x-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][58] ([fdo#111615]) +4 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb6/igt@kms_big_fb@yf-tiled-8bpp-rotate-90.html
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#110723])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb8/igt@kms_big_fb@yf-tiled-8bpp-rotate-90.html
* igt@kms_big_joiner@basic:
- shard-kbl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2705]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl7/igt@kms_big_joiner@basic.html
* igt@kms_big_joiner@invalid-modeset:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#2705])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl1/igt@kms_big_joiner@invalid-modeset.html
- shard-tglb: NOTRUN -> [SKIP][62] ([i915#2705])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@kms_big_joiner@invalid-modeset.html
* igt@kms_chamelium@hdmi-mode-timings:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109284] / [fdo#111827]) +16 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@kms_chamelium@hdmi-mode-timings.html
* igt@kms_chamelium@vga-hpd-enable-disable-mode:
- shard-glk: NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827]) +17 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk1/igt@kms_chamelium@vga-hpd-enable-disable-mode.html
* igt@kms_color@pipe-a-gamma:
- shard-tglb: [PASS][65] -> [FAIL][66] ([i915#1149])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/shard-tglb5/igt@kms_color@pipe-a-gamma.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb5/igt@kms_color@pipe-a-gamma.html
* igt@kms_color@pipe-b-degamma:
- shard-tglb: NOTRUN -> [FAIL][67] ([i915#1149])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb6/igt@kms_color@pipe-b-degamma.html
* igt@kms_color@pipe-d-ctm-0-25:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109278] / [i915#1149]) +3 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@kms_color@pipe-d-ctm-0-25.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271] / [fdo#111827]) +17 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl2/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-d-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb6/igt@kms_color_chamelium@pipe-d-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-snb: NOTRUN -> [SKIP][71] ([fdo#109271] / [fdo#111827]) +16 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-snb2/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html
* igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes:
- shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [fdo#111827]) +25 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl1/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html
- shard-tglb: NOTRUN -> [SKIP][73] ([fdo#109284] / [fdo#111827]) +18 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb5/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html
* igt@kms_content_protection@atomic:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109300] / [fdo#111066])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb5/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-iclb: NOTRUN -> [SKIP][75] ([i915#3116])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@kms_content_protection@dp-mst-lic-type-1.html
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#3116])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@kms_content_protection@dp-mst-lic-type-1.html
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][77] ([i915#1319]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl3/igt@kms_content_protection@lic.html
- shard-tglb: NOTRUN -> [SKIP][78] ([fdo#111828]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@kms_content_protection@lic.html
* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#3319]) +5 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb7/igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][80] ([i915#180])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
- shard-kbl: NOTRUN -> [INCOMPLETE][81] ([i915#155] / [i915#2405])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109278] / [fdo#109279]) +3 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb4/igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding.html
* igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][83] ([fdo#109278]) +30 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement.html
* igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#3359]) +4 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb5/igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement.html
* igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding:
- shard-tglb: NOTRUN -> [SKIP][85] ([fdo#109279] / [i915#3359]) +4 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding.html
* igt@kms_cursor_edge_walk@pipe-d-64x64-left-edge:
- shard-kbl: NOTRUN -> [SKIP][86] ([fdo#109271]) +190 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl7/igt@kms_cursor_edge_walk@pipe-d-64x64-left-edge.html
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size:
- shard-iclb: NOTRUN -> [SKIP][87] ([fdo#109274] / [fdo#109278]) +6 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-kbl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#533]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl7/igt@kms_cursor_legacy@pipe-d-torture-bo.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][89] -> [FAIL][90] ([i915#79])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-flip-vs-rmfb-interruptible:
- shard-iclb: NOTRUN -> [SKIP][91] ([fdo#109274]) +9 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb6/igt@kms_flip@2x-flip-vs-rmfb-interruptible.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#2587])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#2642])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
- shard-glk: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#2642])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
- shard-kbl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#2642])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile.html
* igt@kms_force_connector_basic@force-load-detect:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109285])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb2/igt@kms_force_connector_basic@force-load-detect.html
- shard-tglb: NOTRUN -> [SKIP][97] ([fdo#109285])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb6/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt:
- shard-tglb: NOTRUN -> [SKIP][98] ([fdo#111825]) +62 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][99] ([fdo#109280]) +43 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-glk: NOTRUN -> [SKIP][100] ([fdo#109271]) +143 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk8/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
* igt@kms_hdr@static-toggle-dpms:
- shard-tglb: NOTRUN -> [SKIP][101] ([i915#1187])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb6/igt@kms_hdr@static-toggle-dpms.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-glk: NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#533]) +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk6/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html
- shard-apl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#533])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl8/igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-kbl: NOTRUN -> [DMESG-WARN][104] ([i915#180])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][105] ([fdo#108145] / [i915#265]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-glk: NOTRUN -> [FAIL][106] ([fdo#108145] / [i915#265]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk3/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-glk: NOTRUN -> [FAIL][107] ([i915#265])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk6/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
- shard-apl: NOTRUN -> [FAIL][108] ([i915#265]) +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl8/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
- shard-kbl: NOTRUN -> [FAIL][109] ([i915#265])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl3/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][110] ([fdo#108145] / [i915#265]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl7/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2733])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl1/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][112] ([fdo#109271] / [i915#658]) +4 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-apl6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-kbl: NOTRUN -> [SKIP][113] ([fdo#109271] / [i915#658]) +4 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-tglb: NOTRUN -> [SKIP][114] ([i915#2920]) +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb7/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3:
- shard-iclb: NOTRUN -> [SKIP][115] ([i915#2920])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_su@page_flip:
- shard-glk: NOTRUN -> [SKIP][116] ([fdo#109271] / [i915#658]) +3 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-glk7/igt@kms_psr2_su@page_flip.html
- shard-tglb: NOTRUN -> [SKIP][117] ([i915#1911])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@kms_psr2_su@page_flip.html
- shard-iclb: NOTRUN -> [SKIP][118] ([fdo#109642] / [fdo#111068] / [i915#658])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: NOTRUN -> [SKIP][119] ([fdo#109441]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][120] ([i915#132] / [i915#3467]) +2 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb1/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [PASS][121] -> [SKIP][122] ([fdo#109441])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
* igt@kms_tv_load_detect@load-detect:
- shard-tglb: NOTRUN -> [SKIP][123] ([fdo#109309])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@kms_tv_load_detect@load-detect.html
- shard-iclb: NOTRUN -> [SKIP][124] ([fdo#109309])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb6/igt@kms_tv_load_detect@load-detect.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][125] ([i915#180] / [i915#295])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: [PASS][126] -> [DMESG-WARN][127] ([i915#180]) +2 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10146/shard-kbl2/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][128] ([fdo#109271] / [i915#2437])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-kbl2/igt@kms_writeback@writeback-fb-id.html
* igt@nouveau_crc@pipe-b-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][129] ([i915#2530]) +4 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-tglb8/igt@nouveau_crc@pipe-b-ctx-flip-detection.html
* igt@nouveau_crc@pipe-b-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][130] ([i915#2530]) +2 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/shard-iclb3/igt@nouveau_crc@pipe-b-source-
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5862/index.html
[-- Attachment #1.2: Type: text/html, Size: 34060 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
2021-05-28 4:34 ` [igt-dev] " Vidya Srinivas
@ 2021-05-31 14:17 ` Ville Syrjälä
-1 siblings, 0 replies; 15+ messages in thread
From: Ville Syrjälä @ 2021-05-31 14:17 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: igt-dev, intel-gfx, charlton.lin
On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> For Intel platforms, pitch needs to be 64 byte aligned.
> Kernel code vgem_gem_dumb_create which is platform generic code
> doesnt do the alignment. This causes frame buffer creation to fail
> on Intel platforms where the pitch is not 64 byte aligned.
>
> tests: test run on Intel platforms with panel resolution 1366x768
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_prime.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_prime.c b/tests/kms_prime.c
> index 8cb2ca2a9dc3..fdc941fe8100 100644
> --- a/tests/kms_prime.c
> +++ b/tests/kms_prime.c
> @@ -51,6 +51,8 @@ static struct {
> { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 },
> };
>
> +bool check_platform;
> +
> IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
>
> static bool has_prime_import(int fd)
> @@ -101,7 +103,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
> scratch->bpp = 32;
>
> scratch->handle = kmstest_dumb_create(exporter_fd,
> - scratch->width,
> + check_platform? ALIGN(scratch->width, 64): scratch->width,
The dumb_create ioctl already does this for us.
> scratch->height,
> scratch->bpp,
> &scratch->pitch,
> @@ -262,6 +264,7 @@ igt_main
>
> /* ANY = anything that is not VGEM */
> first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
> + check_platform = is_i915_device(first_fd);
> igt_require(first_fd >= 0);
>
> second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
@ 2021-05-31 14:17 ` Ville Syrjälä
0 siblings, 0 replies; 15+ messages in thread
From: Ville Syrjälä @ 2021-05-31 14:17 UTC (permalink / raw)
To: Vidya Srinivas; +Cc: igt-dev, intel-gfx, charlton.lin
On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> For Intel platforms, pitch needs to be 64 byte aligned.
> Kernel code vgem_gem_dumb_create which is platform generic code
> doesnt do the alignment. This causes frame buffer creation to fail
> on Intel platforms where the pitch is not 64 byte aligned.
>
> tests: test run on Intel platforms with panel resolution 1366x768
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_prime.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_prime.c b/tests/kms_prime.c
> index 8cb2ca2a9dc3..fdc941fe8100 100644
> --- a/tests/kms_prime.c
> +++ b/tests/kms_prime.c
> @@ -51,6 +51,8 @@ static struct {
> { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 },
> };
>
> +bool check_platform;
> +
> IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
>
> static bool has_prime_import(int fd)
> @@ -101,7 +103,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
> scratch->bpp = 32;
>
> scratch->handle = kmstest_dumb_create(exporter_fd,
> - scratch->width,
> + check_platform? ALIGN(scratch->width, 64): scratch->width,
The dumb_create ioctl already does this for us.
> scratch->height,
> scratch->bpp,
> &scratch->pitch,
> @@ -262,6 +264,7 @@ igt_main
>
> /* ANY = anything that is not VGEM */
> first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
> + check_platform = is_i915_device(first_fd);
> igt_require(first_fd >= 0);
>
> second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
2021-05-31 14:17 ` Ville Syrjälä
@ 2021-05-31 14:47 ` Srinivas, Vidya
-1 siblings, 0 replies; 15+ messages in thread
From: Srinivas, Vidya @ 2021-05-31 14:47 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev, intel-gfx, Lin, Charlton
Hello Ville,
Thank you very much.
Before reaching our i915's i915_gem_dumb_create, it goes to vgem_gem_dumb_create for kms_prime.
The pitch gets calculated there and it is not 64 byte aligned. Due to this, intel_framebuffer_init reports "pitch must be 64 byte aligned"
and framebuffer creation fails. I tried submitting vgem patch where 64 byte alignment can be done in vgem_gem_dumb_create and that also
passes. But we did not get approval yet as few of them felt, vgem is generic and other platforms might fail if we do 64 byte alignment there.
Kindly suggest. Thanks a lot.
Regards
Vidya
-----Original Message-----
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Sent: Monday, May 31, 2021 7:48 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> For Intel platforms, pitch needs to be 64 byte aligned.
> Kernel code vgem_gem_dumb_create which is platform generic code doesnt
> do the alignment. This causes frame buffer creation to fail on Intel
> platforms where the pitch is not 64 byte aligned.
>
> tests: test run on Intel platforms with panel resolution 1366x768
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_prime.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_prime.c b/tests/kms_prime.c index
> 8cb2ca2a9dc3..fdc941fe8100 100644
> --- a/tests/kms_prime.c
> +++ b/tests/kms_prime.c
> @@ -51,6 +51,8 @@ static struct {
> { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 }, };
>
> +bool check_platform;
> +
> IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
>
> static bool has_prime_import(int fd)
> @@ -101,7 +103,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
> scratch->bpp = 32;
>
> scratch->handle = kmstest_dumb_create(exporter_fd,
> - scratch->width,
> + check_platform? ALIGN(scratch->width, 64): scratch->width,
The dumb_create ioctl already does this for us.
> scratch->height,
> scratch->bpp,
> &scratch->pitch,
> @@ -262,6 +264,7 @@ igt_main
>
> /* ANY = anything that is not VGEM */
> first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
> + check_platform = is_i915_device(first_fd);
> igt_require(first_fd >= 0);
>
> second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
@ 2021-05-31 14:47 ` Srinivas, Vidya
0 siblings, 0 replies; 15+ messages in thread
From: Srinivas, Vidya @ 2021-05-31 14:47 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev, intel-gfx, Lin, Charlton
Hello Ville,
Thank you very much.
Before reaching our i915's i915_gem_dumb_create, it goes to vgem_gem_dumb_create for kms_prime.
The pitch gets calculated there and it is not 64 byte aligned. Due to this, intel_framebuffer_init reports "pitch must be 64 byte aligned"
and framebuffer creation fails. I tried submitting vgem patch where 64 byte alignment can be done in vgem_gem_dumb_create and that also
passes. But we did not get approval yet as few of them felt, vgem is generic and other platforms might fail if we do 64 byte alignment there.
Kindly suggest. Thanks a lot.
Regards
Vidya
-----Original Message-----
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Sent: Monday, May 31, 2021 7:48 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> For Intel platforms, pitch needs to be 64 byte aligned.
> Kernel code vgem_gem_dumb_create which is platform generic code doesnt
> do the alignment. This causes frame buffer creation to fail on Intel
> platforms where the pitch is not 64 byte aligned.
>
> tests: test run on Intel platforms with panel resolution 1366x768
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_prime.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_prime.c b/tests/kms_prime.c index
> 8cb2ca2a9dc3..fdc941fe8100 100644
> --- a/tests/kms_prime.c
> +++ b/tests/kms_prime.c
> @@ -51,6 +51,8 @@ static struct {
> { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 }, };
>
> +bool check_platform;
> +
> IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
>
> static bool has_prime_import(int fd)
> @@ -101,7 +103,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
> scratch->bpp = 32;
>
> scratch->handle = kmstest_dumb_create(exporter_fd,
> - scratch->width,
> + check_platform? ALIGN(scratch->width, 64): scratch->width,
The dumb_create ioctl already does this for us.
> scratch->height,
> scratch->bpp,
> &scratch->pitch,
> @@ -262,6 +264,7 @@ igt_main
>
> /* ANY = anything that is not VGEM */
> first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
> + check_platform = is_i915_device(first_fd);
> igt_require(first_fd >= 0);
>
> second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
2021-05-31 14:47 ` Srinivas, Vidya
(?)
@ 2021-06-04 18:54 ` Mark Yacoub
2021-06-05 5:44 ` Srinivas, Vidya
-1 siblings, 1 reply; 15+ messages in thread
From: Mark Yacoub @ 2021-06-04 18:54 UTC (permalink / raw)
To: Srinivas, Vidya; +Cc: igt-dev, intel-gfx, Lin, Charlton
On Mon, May 31, 2021 at 10:47 AM Srinivas, Vidya
<vidya.srinivas@intel.com> wrote:
>
> Hello Ville,
>
> Thank you very much.
> Before reaching our i915's i915_gem_dumb_create, it goes to vgem_gem_dumb_create for kms_prime.
>
> The pitch gets calculated there and it is not 64 byte aligned. Due to this, intel_framebuffer_init reports "pitch must be 64 byte aligned"
> and framebuffer creation fails. I tried submitting vgem patch where 64 byte alignment can be done in vgem_gem_dumb_create and that also
> passes. But we did not get approval yet as few of them felt, vgem is generic and other platforms might fail if we do 64 byte alignment there.
>
> Kindly suggest. Thanks a lot.
>
> Regards
> Vidya
>
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Monday, May 31, 2021 7:48 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org; Lin, Charlton <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
>
> On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> > For Intel platforms, pitch needs to be 64 byte aligned.
> > Kernel code vgem_gem_dumb_create which is platform generic code doesnt
> > do the alignment. This causes frame buffer creation to fail on Intel
> > platforms where the pitch is not 64 byte aligned.
> >
> > tests: test run on Intel platforms with panel resolution 1366x768
> >
Tested on ChromeOS on JSL (Drawlat).
Tested-by: Mark Yacoub <markyacoub@chromium.org>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> > tests/kms_prime.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_prime.c b/tests/kms_prime.c index
> > 8cb2ca2a9dc3..fdc941fe8100 100644
> > --- a/tests/kms_prime.c
> > +++ b/tests/kms_prime.c
> > @@ -51,6 +51,8 @@ static struct {
> > { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 }, };
> >
> > +bool check_platform;
I think we can do a more precise name to indicate which platform.
Something like is_intel_device or is_i915 would be more appropriate.
alternatively, we can drop the boolean and just do the check when needed.
So it would look something like
+ is_i915_device(fd) ? ALIGN(scratch->width, 64) : scratch->width,
> > +
> > IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
> >
> > static bool has_prime_import(int fd)
> > @@ -101,7 +103,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
> > scratch->bpp = 32;
> >
> > scratch->handle = kmstest_dumb_create(exporter_fd,
> > - scratch->width,
> > + check_platform? ALIGN(scratch->width, 64): scratch->width,
>
> The dumb_create ioctl already does this for us.
>
> > scratch->height,
> > scratch->bpp,
> > &scratch->pitch,
> > @@ -262,6 +264,7 @@ igt_main
> >
> > /* ANY = anything that is not VGEM */
> > first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
> > + check_platform = is_i915_device(first_fd);
> > igt_require(first_fd >= 0);
> >
> > second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
> > --
> > 2.7.4
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
> --
> Ville Syrjälä
> Intel
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
2021-06-04 18:54 ` [Intel-gfx] " Mark Yacoub
@ 2021-06-05 5:44 ` Srinivas, Vidya
0 siblings, 0 replies; 15+ messages in thread
From: Srinivas, Vidya @ 2021-06-05 5:44 UTC (permalink / raw)
To: Mark Yacoub; +Cc: igt-dev, intel-gfx, Lin, Charlton
Thank you very much Mark, for testing the patch and providing the "Tested-by" tag.
I shall incorporate you review comments and submit the patch.
Additionally, we have submitted the kernel alternative https://patchwork.freedesktop.org/patch/436199/
Regards
Vidya
-----Original Message-----
From: Mark Yacoub <markyacoub@chromium.org>
Sent: Saturday, June 5, 2021 12:24 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>; igt-dev@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
On Mon, May 31, 2021 at 10:47 AM Srinivas, Vidya <vidya.srinivas@intel.com> wrote:
>
> Hello Ville,
>
> Thank you very much.
> Before reaching our i915's i915_gem_dumb_create, it goes to vgem_gem_dumb_create for kms_prime.
>
> The pitch gets calculated there and it is not 64 byte aligned. Due to this, intel_framebuffer_init reports "pitch must be 64 byte aligned"
> and framebuffer creation fails. I tried submitting vgem patch where 64
> byte alignment can be done in vgem_gem_dumb_create and that also passes. But we did not get approval yet as few of them felt, vgem is generic and other platforms might fail if we do 64 byte alignment there.
>
> Kindly suggest. Thanks a lot.
>
> Regards
> Vidya
>
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Monday, May 31, 2021 7:48 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org;
> Lin, Charlton <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned
> pitch to 64 byte for Intel platforms
>
> On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> > For Intel platforms, pitch needs to be 64 byte aligned.
> > Kernel code vgem_gem_dumb_create which is platform generic code
> > doesnt do the alignment. This causes frame buffer creation to fail
> > on Intel platforms where the pitch is not 64 byte aligned.
> >
> > tests: test run on Intel platforms with panel resolution 1366x768
> >
Tested on ChromeOS on JSL (Drawlat).
Tested-by: Mark Yacoub <markyacoub@chromium.org>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> > tests/kms_prime.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_prime.c b/tests/kms_prime.c index
> > 8cb2ca2a9dc3..fdc941fe8100 100644
> > --- a/tests/kms_prime.c
> > +++ b/tests/kms_prime.c
> > @@ -51,6 +51,8 @@ static struct {
> > { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 }, };
> >
> > +bool check_platform;
I think we can do a more precise name to indicate which platform.
Something like is_intel_device or is_i915 would be more appropriate.
alternatively, we can drop the boolean and just do the check when needed.
So it would look something like
+ is_i915_device(fd) ? ALIGN(scratch->width, 64) : scratch->width,
> > +
> > IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
> >
> > static bool has_prime_import(int fd) @@ -101,7 +103,7 @@ static
> > void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
> > scratch->bpp = 32;
> >
> > scratch->handle = kmstest_dumb_create(exporter_fd,
> > - scratch->width,
> > + check_platform? ALIGN(scratch->width, 64):
> > + scratch->width,
>
> The dumb_create ioctl already does this for us.
>
> > scratch->height,
> > scratch->bpp,
> > &scratch->pitch, @@ -262,6 +264,7 @@ igt_main
> >
> > /* ANY = anything that is not VGEM */
> > first_fd = __drm_open_driver_another(0, DRIVER_ANY |
> > DRIVER_VGEM);
> > + check_platform = is_i915_device(first_fd);
> > igt_require(first_fd >= 0);
> >
> > second_fd = __drm_open_driver_another(1, DRIVER_ANY |
> > DRIVER_VGEM);
> > --
> > 2.7.4
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
> --
> Ville Syrjälä
> Intel
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
@ 2021-06-05 5:44 ` Srinivas, Vidya
0 siblings, 0 replies; 15+ messages in thread
From: Srinivas, Vidya @ 2021-06-05 5:44 UTC (permalink / raw)
To: Mark Yacoub; +Cc: igt-dev, intel-gfx, Lin, Charlton
Thank you very much Mark, for testing the patch and providing the "Tested-by" tag.
I shall incorporate you review comments and submit the patch.
Additionally, we have submitted the kernel alternative https://patchwork.freedesktop.org/patch/436199/
Regards
Vidya
-----Original Message-----
From: Mark Yacoub <markyacoub@chromium.org>
Sent: Saturday, June 5, 2021 12:24 AM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>; igt-dev@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
On Mon, May 31, 2021 at 10:47 AM Srinivas, Vidya <vidya.srinivas@intel.com> wrote:
>
> Hello Ville,
>
> Thank you very much.
> Before reaching our i915's i915_gem_dumb_create, it goes to vgem_gem_dumb_create for kms_prime.
>
> The pitch gets calculated there and it is not 64 byte aligned. Due to this, intel_framebuffer_init reports "pitch must be 64 byte aligned"
> and framebuffer creation fails. I tried submitting vgem patch where 64
> byte alignment can be done in vgem_gem_dumb_create and that also passes. But we did not get approval yet as few of them felt, vgem is generic and other platforms might fail if we do 64 byte alignment there.
>
> Kindly suggest. Thanks a lot.
>
> Regards
> Vidya
>
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Monday, May 31, 2021 7:48 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org;
> Lin, Charlton <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned
> pitch to 64 byte for Intel platforms
>
> On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> > For Intel platforms, pitch needs to be 64 byte aligned.
> > Kernel code vgem_gem_dumb_create which is platform generic code
> > doesnt do the alignment. This causes frame buffer creation to fail
> > on Intel platforms where the pitch is not 64 byte aligned.
> >
> > tests: test run on Intel platforms with panel resolution 1366x768
> >
Tested on ChromeOS on JSL (Drawlat).
Tested-by: Mark Yacoub <markyacoub@chromium.org>
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> > tests/kms_prime.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_prime.c b/tests/kms_prime.c index
> > 8cb2ca2a9dc3..fdc941fe8100 100644
> > --- a/tests/kms_prime.c
> > +++ b/tests/kms_prime.c
> > @@ -51,6 +51,8 @@ static struct {
> > { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 }, };
> >
> > +bool check_platform;
I think we can do a more precise name to indicate which platform.
Something like is_intel_device or is_i915 would be more appropriate.
alternatively, we can drop the boolean and just do the check when needed.
So it would look something like
+ is_i915_device(fd) ? ALIGN(scratch->width, 64) : scratch->width,
> > +
> > IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
> >
> > static bool has_prime_import(int fd) @@ -101,7 +103,7 @@ static
> > void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
> > scratch->bpp = 32;
> >
> > scratch->handle = kmstest_dumb_create(exporter_fd,
> > - scratch->width,
> > + check_platform? ALIGN(scratch->width, 64):
> > + scratch->width,
>
> The dumb_create ioctl already does this for us.
>
> > scratch->height,
> > scratch->bpp,
> > &scratch->pitch, @@ -262,6 +264,7 @@ igt_main
> >
> > /* ANY = anything that is not VGEM */
> > first_fd = __drm_open_driver_another(0, DRIVER_ANY |
> > DRIVER_VGEM);
> > + check_platform = is_i915_device(first_fd);
> > igt_require(first_fd >= 0);
> >
> > second_fd = __drm_open_driver_another(1, DRIVER_ANY |
> > DRIVER_VGEM);
> > --
> > 2.7.4
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
> --
> Ville Syrjälä
> Intel
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
2021-05-31 14:47 ` Srinivas, Vidya
@ 2021-06-11 7:35 ` Srinivas, Vidya
-1 siblings, 0 replies; 15+ messages in thread
From: Srinivas, Vidya @ 2021-06-11 7:35 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev, intel-gfx, Lin, Charlton
Hello Ville,
Apologies for bothering you.
Kms_prime goes through vgem_gem_dumb_create where the pitch gets calculated which is not 64 byte aligned.
kms_prime->vgem_gem_dumb_create->intel_framebuffer_init which reports plane 0 pitch (5464) must be at least 64 byte aligned.
We have submitted this patch for kernel https://patchwork.freedesktop.org/patch/436199/ also for the same.
If we try to align stride in IGT after it gets back from vgem_gem_dumb_ioctl, Kernel gives error - [drm:intel_fill_fb_info] fb too big for bo (need 4227072 bytes, have 4198400 bytes).
As a workaround (if the above kernel patch does not go through) we submitted this https://patchwork.freedesktop.org/patch/435794/.
Can you kindly help suggest which is the better way? If not both - kindly guide us how we can address this issue. Thank you so much.
Regards
Vidya
-----Original Message-----
From: Srinivas, Vidya
Sent: Monday, May 31, 2021 8:18 PM
To: 'Ville Syrjälä' <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org; Lin, Charlton <Charlton.Lin@intel.com>
Subject: RE: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
Hello Ville,
Thank you very much.
Before reaching our i915's i915_gem_dumb_create, it goes to vgem_gem_dumb_create for kms_prime.
The pitch gets calculated there and it is not 64 byte aligned. Due to this, intel_framebuffer_init reports "pitch must be 64 byte aligned"
and framebuffer creation fails. I tried submitting vgem patch where 64 byte alignment can be done in vgem_gem_dumb_create and that also passes. But we did not get approval yet as few of them felt, vgem is generic and other platforms might fail if we do 64 byte alignment there.
Kindly suggest. Thanks a lot.
Regards
Vidya
-----Original Message-----
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Sent: Monday, May 31, 2021 7:48 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> For Intel platforms, pitch needs to be 64 byte aligned.
> Kernel code vgem_gem_dumb_create which is platform generic code doesnt
> do the alignment. This causes frame buffer creation to fail on Intel
> platforms where the pitch is not 64 byte aligned.
>
> tests: test run on Intel platforms with panel resolution 1366x768
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_prime.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_prime.c b/tests/kms_prime.c index
> 8cb2ca2a9dc3..fdc941fe8100 100644
> --- a/tests/kms_prime.c
> +++ b/tests/kms_prime.c
> @@ -51,6 +51,8 @@ static struct {
> { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 }, };
>
> +bool check_platform;
> +
> IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
>
> static bool has_prime_import(int fd)
> @@ -101,7 +103,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
> scratch->bpp = 32;
>
> scratch->handle = kmstest_dumb_create(exporter_fd,
> - scratch->width,
> + check_platform? ALIGN(scratch->width, 64): scratch->width,
The dumb_create ioctl already does this for us.
> scratch->height,
> scratch->bpp,
> &scratch->pitch,
> @@ -262,6 +264,7 @@ igt_main
>
> /* ANY = anything that is not VGEM */
> first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
> + check_platform = is_i915_device(first_fd);
> igt_require(first_fd >= 0);
>
> second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
@ 2021-06-11 7:35 ` Srinivas, Vidya
0 siblings, 0 replies; 15+ messages in thread
From: Srinivas, Vidya @ 2021-06-11 7:35 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev, intel-gfx, Lin, Charlton
Hello Ville,
Apologies for bothering you.
Kms_prime goes through vgem_gem_dumb_create where the pitch gets calculated which is not 64 byte aligned.
kms_prime->vgem_gem_dumb_create->intel_framebuffer_init which reports plane 0 pitch (5464) must be at least 64 byte aligned.
We have submitted this patch for kernel https://patchwork.freedesktop.org/patch/436199/ also for the same.
If we try to align stride in IGT after it gets back from vgem_gem_dumb_ioctl, Kernel gives error - [drm:intel_fill_fb_info] fb too big for bo (need 4227072 bytes, have 4198400 bytes).
As a workaround (if the above kernel patch does not go through) we submitted this https://patchwork.freedesktop.org/patch/435794/.
Can you kindly help suggest which is the better way? If not both - kindly guide us how we can address this issue. Thank you so much.
Regards
Vidya
-----Original Message-----
From: Srinivas, Vidya
Sent: Monday, May 31, 2021 8:18 PM
To: 'Ville Syrjälä' <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org; Lin, Charlton <Charlton.Lin@intel.com>
Subject: RE: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
Hello Ville,
Thank you very much.
Before reaching our i915's i915_gem_dumb_create, it goes to vgem_gem_dumb_create for kms_prime.
The pitch gets calculated there and it is not 64 byte aligned. Due to this, intel_framebuffer_init reports "pitch must be 64 byte aligned"
and framebuffer creation fails. I tried submitting vgem patch where 64 byte alignment can be done in vgem_gem_dumb_create and that also passes. But we did not get approval yet as few of them felt, vgem is generic and other platforms might fail if we do 64 byte alignment there.
Kindly suggest. Thanks a lot.
Regards
Vidya
-----Original Message-----
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Sent: Monday, May 31, 2021 7:48 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>
Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org; Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> For Intel platforms, pitch needs to be 64 byte aligned.
> Kernel code vgem_gem_dumb_create which is platform generic code doesnt
> do the alignment. This causes frame buffer creation to fail on Intel
> platforms where the pitch is not 64 byte aligned.
>
> tests: test run on Intel platforms with panel resolution 1366x768
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_prime.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_prime.c b/tests/kms_prime.c index
> 8cb2ca2a9dc3..fdc941fe8100 100644
> --- a/tests/kms_prime.c
> +++ b/tests/kms_prime.c
> @@ -51,6 +51,8 @@ static struct {
> { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 }, };
>
> +bool check_platform;
> +
> IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
>
> static bool has_prime_import(int fd)
> @@ -101,7 +103,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
> scratch->bpp = 32;
>
> scratch->handle = kmstest_dumb_create(exporter_fd,
> - scratch->width,
> + check_platform? ALIGN(scratch->width, 64): scratch->width,
The dumb_create ioctl already does this for us.
> scratch->height,
> scratch->bpp,
> &scratch->pitch,
> @@ -262,6 +264,7 @@ igt_main
>
> /* ANY = anything that is not VGEM */
> first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
> + check_platform = is_i915_device(first_fd);
> igt_require(first_fd >= 0);
>
> second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
2021-05-31 14:47 ` Srinivas, Vidya
` (2 preceding siblings ...)
(?)
@ 2021-06-28 11:08 ` Surendrakumar Upadhyay, TejaskumarX
2021-07-13 17:14 ` Srinivas, Vidya
-1 siblings, 1 reply; 15+ messages in thread
From: Surendrakumar Upadhyay, TejaskumarX @ 2021-06-28 11:08 UTC (permalink / raw)
To: Srinivas, Vidya, Ville Syrjälä
Cc: igt-dev, intel-gfx, Lin, Charlton
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Srinivas, Vidya
> Sent: 31 May 2021 20:18
> To: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: igt-dev@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; Lin,
> Charlton <charlton.lin@intel.com>
> Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned
> pitch to 64 byte for Intel platforms
>
> Hello Ville,
>
> Thank you very much.
> Before reaching our i915's i915_gem_dumb_create, it goes to
> vgem_gem_dumb_create for kms_prime.
>
> The pitch gets calculated there and it is not 64 byte aligned. Due to this,
> intel_framebuffer_init reports "pitch must be 64 byte aligned"
> and framebuffer creation fails. I tried submitting vgem patch where 64 byte
> alignment can be done in vgem_gem_dumb_create and that also passes. But
> we did not get approval yet as few of them felt, vgem is generic and other
> platforms might fail if we do 64 byte alignment there.
>
> Kindly suggest. Thanks a lot.
>
> Regards
> Vidya
>
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Monday, May 31, 2021 7:48 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org; Lin,
> Charlton <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64
> byte for Intel platforms
>
> On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> > For Intel platforms, pitch needs to be 64 byte aligned.
> > Kernel code vgem_gem_dumb_create which is platform generic code
> doesnt
> > do the alignment. This causes frame buffer creation to fail on Intel
> > platforms where the pitch is not 64 byte aligned.
> >
> > tests: test run on Intel platforms with panel resolution 1366x768
> >
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> > tests/kms_prime.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_prime.c b/tests/kms_prime.c index
> > 8cb2ca2a9dc3..fdc941fe8100 100644
> > --- a/tests/kms_prime.c
> > +++ b/tests/kms_prime.c
> > @@ -51,6 +51,8 @@ static struct {
> > { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 }, };
> >
> > +bool check_platform;
> > +
> > IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
> >
> > static bool has_prime_import(int fd)
> > @@ -101,7 +103,7 @@ static void prepare_scratch(int exporter_fd, struct
> dumb_bo *scratch,
> > scratch->bpp = 32;
> >
> > scratch->handle = kmstest_dumb_create(exporter_fd,
> > - scratch->width,
> > + check_platform? ALIGN(scratch->width, 64): scratch-
> >width,
>
> The dumb_create ioctl already does this for us.
I915_dumb_create does it for us but "vgem_gem_dumb_create" does not do 64 ALIGN. And kms_prime is using "vgem_gem_dumb_create" never call i915 dumb_create() as the IGT creates buffer through VGEM driver, see below IGT snippet :
/* ANY = anything that is not VGEM */
first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
igt_require(first_fd >= 0);
second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
Thanks,
Tejas
>
> > scratch->height,
> > scratch->bpp,
> > &scratch->pitch,
> > @@ -262,6 +264,7 @@ igt_main
> >
> > /* ANY = anything that is not VGEM */
> > first_fd = __drm_open_driver_another(0, DRIVER_ANY |
> DRIVER_VGEM);
> > + check_platform = is_i915_device(first_fd);
> > igt_require(first_fd >= 0);
> >
> > second_fd = __drm_open_driver_another(1, DRIVER_ANY |
> DRIVER_VGEM);
> > --
> > 2.7.4
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
> --
> Ville Syrjälä
> Intel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
2021-06-28 11:08 ` [Intel-gfx] " Surendrakumar Upadhyay, TejaskumarX
@ 2021-07-13 17:14 ` Srinivas, Vidya
0 siblings, 0 replies; 15+ messages in thread
From: Srinivas, Vidya @ 2021-07-13 17:14 UTC (permalink / raw)
To: Surendrakumar Upadhyay, TejaskumarX, Ville Syrjälä
Cc: igt-dev, intel-gfx, Lin, Charlton
Hello All,
Very sorry to bother you all again. Kindly can you help so that we can close on this please?
We have submitted both IGT and kernel patches. If none are okay, should we skip the subtest for panels which have width not 64 byte aligned for Intel platforms?
https://patchwork.freedesktop.org/patch/435794/ - IGT patch (we are aligning width itself as workaround due to missing alignment in VGEM before reaching i915)
https://patchwork.freedesktop.org/patch/436199/ - Kernel patch
Tejas has submitted another solution https://patchwork.freedesktop.org/patch/441967/ (256B alignment) - this too works.
Regards
Vidya
-----Original Message-----
From: Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay@intel.com>
Sent: Monday, June 28, 2021 4:39 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; Lin, Charlton <charlton.lin@intel.com>
Subject: RE: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Srinivas, Vidya
> Sent: 31 May 2021 20:18
> To: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: igt-dev@lists.freedesktop.org; intel-gfx@lists.freedesktop.org;
> Lin, Charlton <charlton.lin@intel.com>
> Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC]
> tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
>
> Hello Ville,
>
> Thank you very much.
> Before reaching our i915's i915_gem_dumb_create, it goes to
> vgem_gem_dumb_create for kms_prime.
>
> The pitch gets calculated there and it is not 64 byte aligned. Due to
> this, intel_framebuffer_init reports "pitch must be 64 byte aligned"
> and framebuffer creation fails. I tried submitting vgem patch where 64
> byte alignment can be done in vgem_gem_dumb_create and that also
> passes. But we did not get approval yet as few of them felt, vgem is
> generic and other platforms might fail if we do 64 byte alignment there.
>
> Kindly suggest. Thanks a lot.
>
> Regards
> Vidya
>
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Monday, May 31, 2021 7:48 PM
> To: Srinivas, Vidya <vidya.srinivas@intel.com>
> Cc: intel-gfx@lists.freedesktop.org; igt-dev@lists.freedesktop.org;
> Lin, Charlton <charlton.lin@intel.com>
> Subject: Re: [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned
> pitch to 64 byte for Intel platforms
>
> On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> > For Intel platforms, pitch needs to be 64 byte aligned.
> > Kernel code vgem_gem_dumb_create which is platform generic code
> doesnt
> > do the alignment. This causes frame buffer creation to fail on Intel
> > platforms where the pitch is not 64 byte aligned.
> >
> > tests: test run on Intel platforms with panel resolution 1366x768
> >
> > Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> > ---
> > tests/kms_prime.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_prime.c b/tests/kms_prime.c index
> > 8cb2ca2a9dc3..fdc941fe8100 100644
> > --- a/tests/kms_prime.c
> > +++ b/tests/kms_prime.c
> > @@ -51,6 +51,8 @@ static struct {
> > { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 }, };
> >
> > +bool check_platform;
> > +
> > IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
> >
> > static bool has_prime_import(int fd) @@ -101,7 +103,7 @@ static
> > void prepare_scratch(int exporter_fd, struct
> dumb_bo *scratch,
> > scratch->bpp = 32;
> >
> > scratch->handle = kmstest_dumb_create(exporter_fd,
> > - scratch->width,
> > + check_platform? ALIGN(scratch->width, 64): scratch-
> >width,
>
> The dumb_create ioctl already does this for us.
I915_dumb_create does it for us but "vgem_gem_dumb_create" does not do 64 ALIGN. And kms_prime is using "vgem_gem_dumb_create" never call i915 dumb_create() as the IGT creates buffer through VGEM driver, see below IGT snippet :
/* ANY = anything that is not VGEM */
first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
igt_require(first_fd >= 0);
second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
Thanks,
Tejas
>
> > scratch->height,
> > scratch->bpp,
> > &scratch->pitch,
> > @@ -262,6 +264,7 @@ igt_main
> >
> > /* ANY = anything that is not VGEM */
> > first_fd = __drm_open_driver_another(0, DRIVER_ANY |
> DRIVER_VGEM);
> > + check_platform = is_i915_device(first_fd);
> > igt_require(first_fd >= 0);
> >
> > second_fd = __drm_open_driver_another(1, DRIVER_ANY |
> DRIVER_VGEM);
> > --
> > 2.7.4
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
> --
> Ville Syrjälä
> Intel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-07-13 17:14 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28 4:34 [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms Vidya Srinivas
2021-05-28 4:34 ` [igt-dev] " Vidya Srinivas
2021-05-28 14:23 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-05-29 0:57 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-05-31 14:17 ` [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] " Ville Syrjälä
2021-05-31 14:17 ` Ville Syrjälä
2021-05-31 14:47 ` [Intel-gfx] " Srinivas, Vidya
2021-05-31 14:47 ` Srinivas, Vidya
2021-06-04 18:54 ` [Intel-gfx] " Mark Yacoub
2021-06-05 5:44 ` Srinivas, Vidya
2021-06-05 5:44 ` Srinivas, Vidya
2021-06-11 7:35 ` [Intel-gfx] " Srinivas, Vidya
2021-06-11 7:35 ` Srinivas, Vidya
2021-06-28 11:08 ` [Intel-gfx] " Surendrakumar Upadhyay, TejaskumarX
2021-07-13 17:14 ` Srinivas, Vidya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.