From: Tyler Baicar OS <baicar@os.amperecomputing.com> To: Shiju Jose <shiju.jose@huawei.com>, Open Source Submission <patches@amperecomputing.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>, "james.morse@arm.com" <james.morse@arm.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "will@kernel.org" <will@kernel.org>, "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>, "Guohanjun (Hanjun Guo)" <guohanjun@huawei.com>, "sudeep.holla@arm.com" <sudeep.holla@arm.com>, "rjw@rjwysocki.net" <rjw@rjwysocki.net>, "lenb@kernel.org" <lenb@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "tony.luck@intel.com" <tony.luck@intel.com>, "bp@alien8.de" <bp@alien8.de>, "Matteo.Carlini@arm.com" <Matteo.Carlini@arm.com>, "Andrew.Murray@arm.com" <andrew.murray@arm.com> Subject: Re: [PATCH RFC 1/4] ACPI/AEST: Initial AEST driver Date: Wed, 10 Jul 2019 00:49:56 +0000 [thread overview] Message-ID: <BYAPR01MB39758AB5AF4A67AF8278E361E3F00@BYAPR01MB3975.prod.exchangelabs.com> (raw) In-Reply-To: <86258A5CC0A3704780874CF6004BA8A6584514BF@lhreml523-mbs.china.huawei.com> Hello Shiju, Thank you for the feedback! On Thu, Jul 4, 2019 at 12:03 PM Shiju Jose <shiju.jose@huawei.com> wrote: > >+struct ras_ext_regs { > >+ u64 err_fr; > >+ u64 err_ctlr; > >+ u64 err_status; > >+ u64 err_addr; > >+ u64 err_misc0; > >+ u64 err_misc1; > >+ u64 err_misc2; > >+ u64 err_misc3; > err_misc2 and err_misc3 are not used. Are they for the future purpose? Yes, these will be for future purpose once ARMv8.4 support is added. I'd like to keep them in this structure define since that makes iterating through the memory mapped error records easier. Regardless of ARMv8.2 or ARMv8.4 support, each error record in memory mapped nodes are 64 bytes apart. Having these in the structure make the structure 64 bytes long making it possible for me to increment through error records with the increment ++ operation. If folks don't agree with that, I can change this structure to just have a reserved field at the end such as: + u64 res0[2]; or + u8 res0[8]; > >+ ppi_data = kcalloc(num_ppi, sizeof(struct aest_node_data *), > >+ GFP_KERNEL); > >+ > >+ for (i = 0; i < num_ppi; i++) { > >+ ppi_data[i] = alloc_percpu(struct aest_node_data); > >+ if (!ppi_data[i]) { > >+ ret = -ENOMEM; > >+ break; > >+ } > >+ } > >+ > >+ if (ret) { > >+ pr_err("Failed percpu allocation\n"); > >+ for (i = 0; i < num_ppi; i++) > >+ free_percpu(ppi_data[i]); > I think 'ppi_data' to be freed here? Yes it should be! I'll add that in the next version. Thanks, Tyler
WARNING: multiple messages have this Message-ID (diff)
From: Tyler Baicar OS <baicar@os.amperecomputing.com> To: Shiju Jose <shiju.jose@huawei.com>, Open Source Submission <patches@amperecomputing.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>, "james.morse@arm.com" <james.morse@arm.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "will@kernel.org" <will@kernel.org>, "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>, "Guohanjun (Hanjun Guo)" <guohanjun@huawei.com>, "sudeep.holla@arm.com" <sudeep.holla@arm.com>, "rjw@rjwysocki.net" <rjw@rjwysocki.net>, "lenb@kernel.org" <lenb@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "tony.luck@intel.com" <tony.luck@intel.com>, "bp@alien8.de" <bp@alien8.de>, "Matteo.Carlini@arm.com" <Matteo.Carlini@arm.com>, "Andrew.Murray@arm.com" <andrew.murray@arm.com> Subject: Re: [PATCH RFC 1/4] ACPI/AEST: Initial AEST driver Date: Wed, 10 Jul 2019 00:49:56 +0000 [thread overview] Message-ID: <BYAPR01MB39758AB5AF4A67AF8278E361E3F00@BYAPR01MB3975.prod.exchangelabs.com> (raw) In-Reply-To: <86258A5CC0A3704780874CF6004BA8A6584514BF@lhreml523-mbs.china.huawei.com> Hello Shiju, Thank you for the feedback! On Thu, Jul 4, 2019 at 12:03 PM Shiju Jose <shiju.jose@huawei.com> wrote: > >+struct ras_ext_regs { > >+ u64 err_fr; > >+ u64 err_ctlr; > >+ u64 err_status; > >+ u64 err_addr; > >+ u64 err_misc0; > >+ u64 err_misc1; > >+ u64 err_misc2; > >+ u64 err_misc3; > err_misc2 and err_misc3 are not used. Are they for the future purpose? Yes, these will be for future purpose once ARMv8.4 support is added. I'd like to keep them in this structure define since that makes iterating through the memory mapped error records easier. Regardless of ARMv8.2 or ARMv8.4 support, each error record in memory mapped nodes are 64 bytes apart. Having these in the structure make the structure 64 bytes long making it possible for me to increment through error records with the increment ++ operation. If folks don't agree with that, I can change this structure to just have a reserved field at the end such as: + u64 res0[2]; or + u8 res0[8]; > >+ ppi_data = kcalloc(num_ppi, sizeof(struct aest_node_data *), > >+ GFP_KERNEL); > >+ > >+ for (i = 0; i < num_ppi; i++) { > >+ ppi_data[i] = alloc_percpu(struct aest_node_data); > >+ if (!ppi_data[i]) { > >+ ret = -ENOMEM; > >+ break; > >+ } > >+ } > >+ > >+ if (ret) { > >+ pr_err("Failed percpu allocation\n"); > >+ for (i = 0; i < num_ppi; i++) > >+ free_percpu(ppi_data[i]); > I think 'ppi_data' to be freed here? Yes it should be! I'll add that in the next version. Thanks, Tyler _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-10 0:50 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-02 16:51 [PATCH RFC 0/4] ARM Error Source Table Support Tyler Baicar OS 2019-07-02 16:51 ` Tyler Baicar OS 2019-07-02 16:51 ` [PATCH RFC 1/4] ACPI/AEST: Initial AEST driver Tyler Baicar OS 2019-07-02 16:51 ` Tyler Baicar OS 2019-07-03 9:25 ` Andrew Murray 2019-07-03 9:25 ` Andrew Murray 2019-07-03 17:30 ` Tyler Baicar OS 2019-07-03 17:30 ` Tyler Baicar OS 2019-07-04 9:05 ` Andrew Murray 2019-07-04 9:05 ` Andrew Murray 2019-07-04 16:02 ` Shiju Jose 2019-07-04 16:02 ` Shiju Jose 2019-07-10 0:49 ` Tyler Baicar OS [this message] 2019-07-10 0:49 ` Tyler Baicar OS 2019-07-02 16:51 ` [PATCH RFC 2/4] arm64: mm: Add RAS extension system register check to SEA handling Tyler Baicar OS 2019-07-02 16:51 ` Tyler Baicar OS 2019-07-08 10:00 ` James Morse 2019-07-08 10:00 ` James Morse 2019-07-10 0:51 ` Tyler Baicar OS 2019-07-10 0:51 ` Tyler Baicar OS 2019-07-11 4:14 ` Tyler Baicar OS 2019-07-11 4:14 ` Tyler Baicar OS 2019-07-17 17:41 ` James Morse 2019-07-17 17:41 ` James Morse 2019-07-02 16:51 ` [PATCH RFC 3/4] arm64: traps: Add RAS extension system register check to serror handling Tyler Baicar OS 2019-07-02 16:51 ` Tyler Baicar OS 2019-07-02 16:52 ` [PATCH RFC 4/4] trace, ras: add ARM RAS extension trace event Tyler Baicar OS 2019-07-02 16:52 ` Tyler Baicar OS
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BYAPR01MB39758AB5AF4A67AF8278E361E3F00@BYAPR01MB3975.prod.exchangelabs.com \ --to=baicar@os.amperecomputing.com \ --cc=Matteo.Carlini@arm.com \ --cc=andrew.murray@arm.com \ --cc=bp@alien8.de \ --cc=catalin.marinas@arm.com \ --cc=guohanjun@huawei.com \ --cc=james.morse@arm.com \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=patches@amperecomputing.com \ --cc=rjw@rjwysocki.net \ --cc=shiju.jose@huawei.com \ --cc=sudeep.holla@arm.com \ --cc=tony.luck@intel.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.