From: Taylor Simpson <tsimpson@quicinc.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Richard Henderson <richard.henderson@linaro.org>
Subject: RE: [PATCH] target/hexagon/opcodes: Add missing varargs cleanup
Date: Tue, 23 Feb 2021 20:40:03 +0000 [thread overview]
Message-ID: <BYAPR02MB488661AEC5F0358B5BB714A6DE809@BYAPR02MB4886.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20210223111253.2831285-1-f4bug@amsat.org>
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, February 23, 2021 5:13 AM
> To: qemu-devel@nongnu.org
> Cc: Richard Henderson <richard.henderson@linaro.org>; Taylor Simpson
> <tsimpson@quicinc.com>; Philippe Mathieu-Daudé <f4bug@amsat.org>
> Subject: [PATCH] target/hexagon/opcodes: Add missing varargs cleanup
>
> Fix a trivial incorrect usage of variable argument macros detected
> by Coverity (missing_va_end: va_end was not called for ap).
>
> Fixes: Coverity CID 1446720 (VARARGS)
> Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/hexagon/opcodes.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/hexagon/opcodes.c b/target/hexagon/opcodes.c
> index 4eef5fc40f6..35d790cdd5b 100644
> --- a/target/hexagon/opcodes.c
> +++ b/target/hexagon/opcodes.c
> @@ -82,6 +82,7 @@ static void init_attribs(int tag, ...)
> while ((attr = va_arg(ap, int)) != 0) {
> set_bit(attr, opcode_attribs[tag]);
> }
> + va_end(ap);
> }
>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Tested-by: Taylor Simpson <tsimpson@quicinc.com>
next prev parent reply other threads:[~2021-02-23 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 11:12 [PATCH] target/hexagon/opcodes: Add missing varargs cleanup Philippe Mathieu-Daudé
2021-02-23 18:47 ` Richard Henderson
2021-02-23 20:40 ` Taylor Simpson [this message]
2021-03-05 19:04 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR02MB488661AEC5F0358B5BB714A6DE809@BYAPR02MB4886.namprd02.prod.outlook.com \
--to=tsimpson@quicinc.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.