RE: [PATCH v7 00/35] Hexagon patch series

From: Taylor Simpson <tsimpson@quicinc.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "ale@rev.ng" <ale@rev.ng>,
	"alex.bennee@linaro.org" <alex.bennee@linaro.org>,
	"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
	"laurent@vivier.eu" <laurent@vivier.eu>,
	Brian Cain <bcain@quicinc.com>
Subject: RE: [PATCH v7 00/35] Hexagon patch series
Date: Mon, 25 Jan 2021 23:09:09 +0000	[thread overview]
Message-ID: <BYAPR02MB4886C64A59EAC3B164159D5BDEBD9@BYAPR02MB4886.namprd02.prod.outlook.com> (raw)
In-Reply-To: <02e7217d-6376-b93d-842d-197d9e13fc58@amsat.org>

> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Monday, January 25, 2021 4:15 PM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: richard.henderson@linaro.org; alex.bennee@linaro.org;
> laurent@vivier.eu; ale@rev.ng; Brian Cain <bcain@quicinc.com>
> Subject: Re: [PATCH v7 00/35] Hexagon patch series
>
>
> Hi Taylor,
>
> On 1/20/21 4:28 AM, Taylor Simpson wrote:
> > This series adds support for the Hexagon processor with Linux user support
> >
> > See patch 02/33 Hexagon README for detailed information.
> >
> > This series assumes int128_or() is implemented.
> > https://lists.nongnu.org/archive/html/qemu-devel/2020-
> 10/msg06004.html
> >
> > The series is also available at https://github.com/quic/qemu on branch
> > small_series_v7.
> >
> >
> > Once the series is applied, the Hexagon port will pass "make check-tcg".
> > The series also includes Hexagon-specific tests in tcg/tests/hexagon.
> >
> > The final patch in the series add docker support.  Thanks to Alessandro
> > Di Federico <ale@rev.ng> and Brian Cain <bcain@quicinc.com> for making
> this
> > happen.  The default container (debian-hexagon-cross) uses a toolchain
> built
> > by rev.ng.  Alternatively, there is a container that will build the toolchain
> > locally (debian-hexagon-cross-build-local).
> >
> > Here are the commands to verify the code:
> >     mkdir build
> >     cd build
> >     ../configure --target-list=hexagon-linux-user
> >     make
> >     make check-tcg
>
> I'm looking at stressing a bit more your work.
>
> Are your Hexagon Linux user-land binaries available on some repository?
> Eventually busybox binary (known to work on real hardware) is a good
> candidate.

A prebuilt busybox isn't currently available, but we could publish one.  Is there a central location for the qemu community to get these?  Or is it expected that each target has their own?

Note that this series implements a subset of the instructions.  I plan to submit the others once this series is accepted.  So, I wouldn't be surprised if busybox doesn't work with this series.  I know that it works with the full set of instructions implemented at https://github.com/quic/qemu.  In fact, we demo'ed it during our talk at the 2019 KVM Forum https://www.youtube.com/watch?v=3EpnTYBOXCI&list=PLW3ep1uCIRfwwtvUS1Pco6Y0X-5tykpyG&index=33.

>
> Also I noticed these sample apps:
> https://developer.qualcomm.com/software/hexagon-dsp-sdk/sample-apps
>
> These could be nice to have as integration testing:
>
> - appi_fir
>   APPI-based module that applies a FIR filter to audio data
> - image downscale
>   Example showing deeply optimized 2D image downscaling function
> - cornerApp
>   Example that detects corners in an image, using aDSP FastCV primitives

All of the SDK examples run on our RTOS, not linux-user.  I could convert some of them to work in linux-user mode.  Would tests/tcg/hexagon be the right place for these?

> Any other real-world binary you could share?

In addition to busybox, we could build other open source packages.  Would that be of interest?

Thanks,
Taylor