All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Minwoo Im <minwoo.im.dev@gmail.com>,
	"Linux-nvme@lists.infradead.org" <Linux-nvme@lists.infradead.org>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: unexport internal function symbols
Date: Wed, 30 Dec 2020 07:10:49 +0000	[thread overview]
Message-ID: <BYAPR04MB496508D70A0F3121191C0C2886D70@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20201227103831.22319-1-minwoo.im.dev@gmail.com

On 12/27/20 2:46 AM, Minwoo Im wrote:
> Unexport symbols not taken from other side.  This patch also make those
> two functions as static functions:
>
>   nvme_reset_ctrl_sync
>   nvme_alloc_request_qid
>
> This patch has no functional changes.
change the commit log to :-


There are no callers for nvme_reset_ctrl_sync() and
nvme_alloc_request_qid()so that we keep the symbols exported.

Unexport those functions, mark them static and update the headerfile
respectively.
>
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
>  drivers/nvme/host/core.c | 6 ++----
>  drivers/nvme/host/nvme.h | 3 ---
>  2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index ce1b61519441..70a63d7c1d02 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -179,7 +179,7 @@ int nvme_reset_ctrl(struct nvme_ctrl *ctrl)
>  }
>  EXPORT_SYMBOL_GPL(nvme_reset_ctrl);
>  
> -int nvme_reset_ctrl_sync(struct nvme_ctrl *ctrl)
> +static int nvme_reset_ctrl_sync(struct nvme_ctrl *ctrl)
>  {
>  	int ret;
>  
> @@ -192,7 +192,6 @@ int nvme_reset_ctrl_sync(struct nvme_ctrl *ctrl)
>  
>  	return ret;
>  }
> -EXPORT_SYMBOL_GPL(nvme_reset_ctrl_sync);
>  
>  static void nvme_do_delete_ctrl(struct nvme_ctrl *ctrl)
>  {
> @@ -578,7 +577,7 @@ struct request *nvme_alloc_request(struct request_queue *q,
>  }
>  EXPORT_SYMBOL_GPL(nvme_alloc_request);
>  
> -struct request *nvme_alloc_request_qid(struct request_queue *q,
> +static struct request *nvme_alloc_request_qid(struct request_queue *q,
>  		struct nvme_command *cmd, blk_mq_req_flags_t flags, int qid)
>  {
>  	struct request *req;
> @@ -589,7 +588,6 @@ struct request *nvme_alloc_request_qid(struct request_queue *q,
>  		nvme_init_request(req, cmd);
>  	return req;
>  }
> -EXPORT_SYMBOL_GPL(nvme_alloc_request_qid);
>  
>  static int nvme_toggle_streams(struct nvme_ctrl *ctrl, bool enable)
>  {
> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index 7e49f61f81df..9c4fbfe44c00 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -610,8 +610,6 @@ void nvme_start_freeze(struct nvme_ctrl *ctrl);
>  #define NVME_QID_ANY -1
>  struct request *nvme_alloc_request(struct request_queue *q,
>  		struct nvme_command *cmd, blk_mq_req_flags_t flags);
> -struct request *nvme_alloc_request_qid(struct request_queue *q,
> -		struct nvme_command *cmd, blk_mq_req_flags_t flags, int qid);
>  void nvme_cleanup_cmd(struct request *req);
>  blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req,
>  		struct nvme_command *cmd);
> @@ -630,7 +628,6 @@ int nvme_get_features(struct nvme_ctrl *dev, unsigned int fid,
>  int nvme_set_queue_count(struct nvme_ctrl *ctrl, int *count);
>  void nvme_stop_keep_alive(struct nvme_ctrl *ctrl);
>  int nvme_reset_ctrl(struct nvme_ctrl *ctrl);
> -int nvme_reset_ctrl_sync(struct nvme_ctrl *ctrl);
>  int nvme_try_sched_reset(struct nvme_ctrl *ctrl);
>  int nvme_delete_ctrl(struct nvme_ctrl *ctrl);
>  



_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-12-30  7:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-27 10:38 [PATCH] nvme: unexport internal function symbols Minwoo Im
2020-12-30  7:10 ` Chaitanya Kulkarni [this message]
2020-12-30 11:10   ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR04MB496508D70A0F3121191C0C2886D70@BYAPR04MB4965.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=Linux-nvme@lists.infradead.org \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=minwoo.im.dev@gmail.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.