From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Pavel Begunkov <asml.silence@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>
Subject: Re: [PATCH 1/2] io_uring: fix ignoring xa_store errors
Date: Mon, 21 Dec 2020 23:27:43 +0000 [thread overview]
Message-ID: <BYAPR04MB49652ED4F50AE907F923583486C00@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 7ba58ef02c309cc19bca4f5832686fe6a049d868.1608575562.git.asml.silence@gmail.com
On 12/21/20 10:40, Pavel Begunkov wrote:
> @@ -8866,7 +8865,12 @@ static int io_uring_add_task_file(struct io_ring_ctx *ctx, struct file *file)
>
> if (!old) {
> get_file(file);
> - xa_store(&tctx->xa, (unsigned long)file, file, GFP_KERNEL);
> + ret = xa_err(xa_store(&tctx->xa, (unsigned long)file,
> + file, GFP_KERNEL));
> + if (ret) {
> + fput(file);
> + return ret;
> + }
> }
> tctx->last = file;
> }
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
next prev parent reply other threads:[~2020-12-21 23:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 18:34 [PATCH 0/2] fixes for syzbot reports Pavel Begunkov
2020-12-21 18:34 ` [PATCH 1/2] io_uring: fix ignoring xa_store errors Pavel Begunkov
2020-12-21 23:27 ` Chaitanya Kulkarni [this message]
2020-12-21 18:34 ` [PATCH 2/2] io_uring: fix double io_uring free Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB49652ED4F50AE907F923583486C00@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.