All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] blktrace: put bounds on BLKTRACESETUP buf_size and buf_nr
Date: Mon, 8 Jun 2020 21:59:55 +0000	[thread overview]
Message-ID: <BYAPR04MB4965D2A36AE58C4519DBD77A86850@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 35a5f5a7-770e-1cbe-10a3-118591b64f29@acm.org

Bart,
On 6/8/20 7:20 AM, Bart Van Assche wrote:
> On 2020-06-07 23:40, Chaitanya Kulkarni wrote:
>> Bart,
>> On 6/5/20 6:43 AM, Bart Van Assche wrote:
>>> We typically do not implement arbitrary limits in the kernel. So I'd
>>> prefer not to introduce any artificial limits.
>> That is what I mentioned in [1] that we can add a check suggested in
>> [1]. That way we will not enforce any limits in the kernel and keep
>> the backward compatibility.
>>
>> Do you see any problem with the approach suggested in [1].
>>
>> [1]https://www.spinics.net/lists/linux-block/msg54754.html
> Please take another look at Harshad's patch description. My
> understanding is that Harshad wants to protect the kernel against
> malicious user space software. Modifying the user space blktrace
> software as proposed in [1] doesn't help at all towards the goal of
> hardening the kernel.
> 
> Thanks,
> 
> Bart.
> 

Hmmm, I agree that we need fix for that. What I did't understand that 
why we don't need userspace fix ?

Also, what is a right way to impose these limits without having any 
bounds in kernel ?

Either I did not understand your comment(s) or I'm confuse.

Can you please elaborate ?

  reply	other threads:[~2020-06-08 22:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04  5:44 [PATCH] blktrace: put bounds on BLKTRACESETUP buf_size and buf_nr Harshad Shirwadkar
2020-06-04  7:10 ` Chaitanya Kulkarni
2020-06-04 15:26   ` harshad shirwadkar
2020-06-05  4:31 ` Bart Van Assche
2020-06-05  5:02   ` harshad shirwadkar
2020-06-05 13:43     ` Bart Van Assche
2020-06-05 17:39       ` harshad shirwadkar
2020-06-08  6:42         ` Chaitanya Kulkarni
2020-06-08  6:40       ` Chaitanya Kulkarni
2020-06-08 14:20         ` Bart Van Assche
2020-06-08 21:59           ` Chaitanya Kulkarni [this message]
2020-06-08 23:40             ` harshad shirwadkar
2020-06-09  0:00               ` Chaitanya Kulkarni
2020-06-08  6:34   ` Chaitanya Kulkarni
2020-06-08 14:13     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR04MB4965D2A36AE58C4519DBD77A86850@BYAPR04MB4965.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=harshadshirwadkar@gmail.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.