Re: [PATCH 5/5] f2fs-tools: Fix multi-device format with zoned devices

[Damien Le Moal <Damien.LeMoal@wdc.com>]

On 2019/03/21 17:41, Chao Yu wrote:
> On 2019/3/18 14:39, Damien Le Moal wrote:
>> There is no need to require conventional zones for a zoned block device
>> that is not the first device of a multi-device volume. So exclude the
>> check on the number of conventional zones of the device if the device
>> index is not 0.
>>
>> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
>> ---
>>  lib/libf2fs_zoned.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/libf2fs_zoned.c b/lib/libf2fs_zoned.c
>> index 1a6c5df..2d8244f 100644
>> --- a/lib/libf2fs_zoned.c
>> +++ b/lib/libf2fs_zoned.c
>> @@ -204,7 +204,7 @@ int f2fs_check_zones(int j)
>>  		goto out;
>>  	}
>>  
> 
> How about adding one line comment here to describe why we handle condition
> as below for better readability? I guess using your commit message here is
> enough... :)

Indeed, that would be better. Will add that. Thanks !

> 
>> -	if (dev->zoned_model == F2FS_ZONED_HM &&
>> +	if (j == 0 && dev->zoned_model == F2FS_ZONED_HM &&
>>  			!dev->nr_rnd_zones) {
>>  		ERR_MSG("No conventional zone for super block\n");
>>  		ret = -1;
>>
> 


-- 
Damien Le Moal
Western Digital Research