From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============0982007374932113344=="
MIME-Version: 1.0
From: Thomas, Ramesh <ramesh.thomas at intel.com>
Subject: [Accel-config] Re: [PATCH v1] accel-config: Fix static code analysis
 issues
Date: Fri, 04 Dec 2020 18:42:44 +0000
Message-ID: <BYAPR11MB2535795DEC2977C9B85D7AD3EDF10@BYAPR11MB2535.namprd11.prod.outlook.com>
In-Reply-To: 54908a95aed7433d8b66d387b7270a6a@intel.com
To: accel-config@lists.01.org
List-ID: <accel-config@lists.01.org>

--===============0982007374932113344==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 04, 2020 at 08:23:53AM, Tony Luck wrote:
> @@ -615,7 +616,6 @@ err_read:
>  free(wq->wq_buf);
>  free(wq->wq_path);
>  err_wq:
> -close(dfd);
>  free(wq);
>  free(path);
>  return NULL;
> =

> Maybe I'm not looking at the latest source ... but it looks like there
> is one path to this code where dfd isn't closed first. Here:
> =

>  640         /* parse uuid only in mdeve wq type */
>  641         if (wq->type =3D=3D ACCFG_WQT_MDEV) {
>  642                 ret =3D uuid_entry_add(ctx, wq, dfd);
>  643                 if (ret < 0)
>  644                         goto err_wq;
>  645         }

Yes, that is old code. We removed mdevs from wqs.
Use repo at https://github.com/intel/idxd-config.git pending branch
--===============0982007374932113344==--