From: "Zhang, Qiang" <Qiang.Zhang@windriver.com>
To: "tj@kernel.org" <tj@kernel.org>,
"jiangshanlai@gmail.com" <jiangshanlai@gmail.com>,
"htejun@gmail.com" <htejun@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 回复: [PATCH] workqueue: Move the position of debug_work_activate() in __queue_work()
Date: Wed, 17 Feb 2021 09:10:46 +0000 [thread overview]
Message-ID: <BYAPR11MB2632DACFF2D6722222A3818FFF869@BYAPR11MB2632.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210211082351.178536-1-qiang.zhang@windriver.com>
Hello Tejun Heo
Excuse me, do you have time to make some suggestions for this modification?
Thanks
Qiang
________________________________________
发件人: Zhang, Qiang <qiang.zhang@windriver.com>
发送时间: 2021年2月11日 16:24
收件人: tj@kernel.org; jiangshanlai@gmail.com
抄送: linux-kernel@vger.kernel.org
主题: [PATCH] workqueue: Move the position of debug_work_activate() in __queue_work()
From: Zqiang <qiang.zhang@windriver.com>
The debug_work_activate() is called on the premise that
the work can be inserted, because if wq be in WQ_DRAINING
status, insert work may be failed.
Signed-off-by: Zqiang <qiang.zhang@windriver.com>
---
kernel/workqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 0d150da252e8..21fb00b52def 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1412,7 +1412,6 @@ static void __queue_work(int cpu, struct workqueue_struct *wq,
*/
lockdep_assert_irqs_disabled();
- debug_work_activate(work);
/* if draining, only works from the same workqueue are allowed */
if (unlikely(wq->flags & __WQ_DRAINING) &&
@@ -1494,6 +1493,7 @@ static void __queue_work(int cpu, struct workqueue_struct *wq,
worklist = &pwq->delayed_works;
}
+ debug_work_activate(work);
insert_work(pwq, work, worklist, work_flags);
out:
--
2.25.1
next prev parent reply other threads:[~2021-02-17 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 8:23 [PATCH] workqueue: Move the position of debug_work_activate() in __queue_work() qiang.zhang
2021-02-17 9:10 ` Zhang, Qiang [this message]
2021-02-18 2:45 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB2632DACFF2D6722222A3818FFF869@BYAPR11MB2632.namprd11.prod.outlook.com \
--to=qiang.zhang@windriver.com \
--cc=htejun@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.