From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC254C433EF for ; Fri, 8 Jul 2022 08:16:00 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2A3440A7B; Fri, 8 Jul 2022 10:15:59 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 7F07A406B4 for ; Fri, 8 Jul 2022 10:15:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657268157; x=1688804157; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bpcQ86+RkQ7gcxoyrw2KgUDIDae627J0qb6t6+p9IR8=; b=eK8Oh3k7ygVsDXJWhBn7KPCTAsRcNcDMeLf4FcES0onm2Tt40KxO/d2t NXmjgymsORMtgTPTAbs/SXmgkC4TuAAr1p5/BP7Ssm95PxMkA5VjqxXgb lCxcHLeoy5zb54YX6DAsR+v3ghGNGkxe6ea5e1iJx63ybytOCOnh1J6/w svwyJpMU62vTzmSMR56LBq1fH6MU/saHdWAzOA2b3qeEV1iexbyPeflvD d6arvNcQbFMLXqphOcNfkPbTNAun0e2RwItqokdT1OpfZI6crRZCUcY+S 3Urp9aEOWyOJacqe6c91aI4r3CGLwsVELM4BV8P0dqs4BSIGGl1NHyr7r A==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="309792610" X-IronPort-AV: E=Sophos;i="5.92,254,1650956400"; d="scan'208";a="309792610" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2022 01:15:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,254,1650956400"; d="scan'208";a="736264638" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga001.fm.intel.com with ESMTP; 08 Jul 2022 01:15:56 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 8 Jul 2022 01:15:55 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Fri, 8 Jul 2022 01:15:55 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Fri, 8 Jul 2022 01:15:55 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Fri, 8 Jul 2022 01:15:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TVBQz9aRAILKDN5JxaAPk9XhNjWEyD70d0F0ELbfcDDNWVJrsCONnGpgxMOW5KHgvmQEBkdq8dj5II3xN/g51vp4lL21cRpPwGFz3u8PlaBNdEKrDnhF/Db6JHP5us1zl0FGRNNJy4Hs1gZGFlwvzKlyKKrAByPCKjpfbd8UKPfeyXKoHfVYTNUVpGKf0BiR98xmAt9G4hLPKldbqpplK7aXuZ6dyFgiMJrSDdIBb4T0XIjIY2wL3a9FK5KJVgnKGkXdGX6La34AstnrJs3XcYvEZ7tYXZ/H/FqVYPe/zvzLaHP3vaJqCH0JiBHHVbM08JL/qPRXXC6vpELF6DwVMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kKRhd8bQep1BuoI3waqDo9E/HWqCEFUXd5H/dL8e/cg=; b=etv0xN2azd5qG1dClYqUMkbVXi7EILT15E5fNUIVFswBwYBlTkGW/7hnET03SLQ5Fch2nszd+FC9nQOOZCBXgqRC+vHhoGycieNalg4+EJfZ7qYKqgsEcTPDsGjPHKo1SMz8ONsccIEICFARY5lpSaqket4vbETSlJOjzfixIaYgVv3ilS8oixiS46Qs0fcoKjZZ847bPHhbZMbkqxO8kJPDi2qeB4f/PL77/nYWBBrX7xQKXcsRjxaJeCXg/3xxODsFpxc6SpUadxxyeHvD6XBed6984xX+gSPQSVEX1VG5H2kGhh43OSBtiz6zVg3uUqMVRZLm/BBz4pH/N8VSEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB2711.namprd11.prod.outlook.com (2603:10b6:a02:c2::30) by IA1PR11MB6241.namprd11.prod.outlook.com (2603:10b6:208:3e9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 08:15:48 +0000 Received: from BYAPR11MB2711.namprd11.prod.outlook.com ([fe80::b936:5bf8:23b5:51b2]) by BYAPR11MB2711.namprd11.prod.outlook.com ([fe80::b936:5bf8:23b5:51b2%7]) with mapi id 15.20.5395.022; Fri, 8 Jul 2022 08:15:48 +0000 From: "Jiang, YuX" To: "Li, WeiyuanX" , Huisong Li , "ferruh.yigit@xilinx.com" , "andrew.rybchenko@oktetlabs.ru" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "huangdaode@huawei.com" , "liudongdong3@huawei.com" Subject: RE: [PATCH V2] app/testpmd: fix display types failure when query RSS rule Thread-Topic: [PATCH V2] app/testpmd: fix display types failure when query RSS rule Thread-Index: AQHYkmwIdVhYgu3Xwkml4LI4EocKR61z8xcwgAAtYnA= Date: Fri, 8 Jul 2022 08:15:47 +0000 Message-ID: References: <20220707105044.10567-1-lihuisong@huawei.com> <20220708014159.13499-1-lihuisong@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bddb583b-a743-4f46-be38-08da60ba1008 x-ms-traffictypediagnostic: IA1PR11MB6241:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z4H0t+MdA3N4HOcnx46VmMHBJS2Ib+Wiw5FlshzL1KNMbjpaz47Bw6ggIrmpm8NqAGSf/KlYunlAOFukR2V5x9kM2DfXaj6lDslDMm0j4PlFgCiKHAd9BjzvP283Z7RCoiItrZZ5B6CvK4DfvHJS537GEmZrQlcP46ud11S2jHGjG6DJzGKX4AvpdgPBI0QzgsSp3W4svNlWS4uv9sWdJgY054Ubxr9TLPNPUtazlog89sIvLBzFGHlwfgykNDptMC92y/JDqyq+4gu8mF2a44w/gj1k9aMjIh1seVkw6zT4Fwr7v6xJBIsp9gAPWjgQVHT6eTqNI1YFZfiqppZbF2iQ6XkEc914BOKbaFvgbX1gLklo5SMmwBHYGvG+yv8rBiOmWNvNv3wZ2VVFSsWzd25GqFSi7f0Gjq93RL27oGToRR8iKsZGdJY4X2yqN0IsUjnVjJLGhg5kBk9rlUmVIdqsHGuen5CmwPWSPLF40KT3oWEN+sDCirR4lQQsEKzLLKjDcsK4Yiku4lLgTUafB8uksx09Y+TOfzHt4kydFot2TvpmNv1k5eeXOg84pI569m4fnZ9ol5YHD7doozcIt8BkANzAz4bHd8pAH97mdXr5O4m2rRYWmie/ybufi8dk8tXfngF/4v4TH66/DvxFdu08DhDahjFA1csoUVKT0sy8s3FW/PiAXSn37BOfwJKAmRhZOWCTyL74tD4iApKQnSgGmp9+YspxBzGhzdn8M2zzkAUaY0QQB10NVKa1WD6cCa/bUUHB27AEdzNa4aW+bqQXwNGBCvrlRz7l25my2d7khAABlV6zXuDLJHUwlUooV6frh1cp3old3yBb+VOUiw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2711.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(366004)(396003)(376002)(346002)(39860400002)(5660300002)(9686003)(66476007)(66446008)(26005)(8676002)(66556008)(64756008)(66946007)(76116006)(83380400001)(8936002)(82960400001)(186003)(52536014)(38070700005)(4326008)(38100700002)(86362001)(71200400001)(478600001)(33656002)(41300700001)(122000001)(110136005)(55016003)(6506007)(2906002)(53546011)(316002)(54906003)(7696005)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eKm6jPxoC6yTZBYGGtRoxgb9Jz+3LL1/imsF9iMIuHxMhgfqT6k5fJj5pwOZ?= =?us-ascii?Q?omAVRCe3eYljpicJPmRTk7B+ZOE728BRRqj0C1plsZfwJJNPb740eh0I0/z8?= =?us-ascii?Q?nzH8AomuLL7t9mHQf3phEUmPvVz419d8o9XwrCJpni7d/xTU1CtowZv8E6eA?= =?us-ascii?Q?3PNF0WuQgUzF9wPB/2nsQ0Qd3uB6e5/tjvQodvY8BGqkmYI4lNNrIwYTbUpG?= =?us-ascii?Q?PDP223oBFKDlOUOMmc4fo6rq6ooAzmSr6jK49mWUiPJtKbtHU7VOrcgUL7jX?= =?us-ascii?Q?3+V0m0iVZ2ympv8H2WwfPZFqecaavrwsCF71i91V4JCCLkQfifTbnlDNh0W2?= =?us-ascii?Q?vkuL8f7ASFcZNO22sJfTfAP9lSj0YJmXMoxpEu/rYJeFt68fKeM4mHaf/Bbe?= =?us-ascii?Q?2eju6/voR2ztqNYLEZDq1NWxZ8RYgW0fUu0mQEk9dxc4wI4CclzKvmqsTEZl?= =?us-ascii?Q?GKr/honT0jIC9EfsS+vmiLaBVspeX5mima9KeHAdD1ju4SecZR7PCXMo888p?= =?us-ascii?Q?mke4XAiDduMtSq6VjWn/TXVQ6vdm0X2Fm0r12ERERoO8eI42lNtTQMUcJ/pF?= =?us-ascii?Q?SYSDiuQ9ckM4nzSY8Dyh9Px3s9NeWIujoLZpEePqUEaG5TwKkyChNz0qANkV?= =?us-ascii?Q?TQVk+LTwlIo2HN+77nCwTl2UEsuNrT5vIc93aRcMiIo5Mk8VTeBT5UIVJ4o6?= =?us-ascii?Q?wAc6yDV/QxWwKfpBkTnwKsm11fyUwxR0VpRMsqvP0b6ogUFe/t6lWfrBOo6V?= =?us-ascii?Q?qa9MpEVoikZZxahHsTgG1tsUKGxehmRG2lGiMWILlCJhVOtUGndeTEHIbty6?= =?us-ascii?Q?PBYJNcLOKVqReQT+amK9YvnXPv1dlM9VzwfnWUV4A7i+kZy/dDfNAK5dhUNb?= =?us-ascii?Q?pfbTC3FZS9J92F6yQQw30fi3sV8qyd03nbS7QjLAuQVnqioq3qZI3gEwXhTo?= =?us-ascii?Q?0OLXYv9nc83RngtRUozuUuUCcOnXVEWFz4PbwoWRDbyJFyyjYcm48GiofK4o?= =?us-ascii?Q?FTlmANQs40aO52asV8qfT+RC2Usms8V1cYPqyyeUNp5VZMChEvJTu0FzY0LR?= =?us-ascii?Q?MuH3nx+QPHLd9/+RtqSSKGWFw0mYzKOUjqyYtGABzHN9df2epMC/X48Nbqyt?= =?us-ascii?Q?UzjQLX+B+9lCLce64A2lzwSsbbzS9SGXWXR38z/zh1hqn4lM9TFoWQ/juCrJ?= =?us-ascii?Q?rXW7DnEJ8wEUz+P/zCguD/VwxfVfHKSiVFoC7v6ta59gNe3CAygqcDEoGPzy?= =?us-ascii?Q?35+WIr/+dMnNI7lNoxihBdo9tqBX8bf19JelJrv+scEMbjlRfvUG6XMbgfWs?= =?us-ascii?Q?i6PmVKU7semcM68vHBw6PRdKOunLXxe5ObgdiP9Sai6XDhLERM6r0PRj4lQ8?= =?us-ascii?Q?drKNEbCEQfb8Y68bhHTBf0WizRjbj2BQQmLlOO33mSA2YqHFd6pVD2VYFTbW?= =?us-ascii?Q?7VV2lq+KPQnlT3u8coLCVpUUMLgXsZxgRN+1Wdt+xOMsGRupd5K2RkoduUEH?= =?us-ascii?Q?PhGLvNVtmrdMYxCvB7I1nygtSGxx9z4adBLQnSWtYOBHrtGvgLUqYbBqH1SI?= =?us-ascii?Q?M+x0xgzyHSAts+RP6aoqO2KshaN+qwTahK/Z2/a0?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2711.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bddb583b-a743-4f46-be38-08da60ba1008 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2022 08:15:47.5069 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nczIqFNZ2h4huBDr2BRjHUf9ScH8nLRhjFZz9o1gQlwck4KNtXa+cCDL8KsUdJtkQxPCI/Cu5v9aY/0WDC2bGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6241 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Li, WeiyuanX > Sent: Friday, July 8, 2022 1:32 PM > To: Huisong Li ; ferruh.yigit@xilinx.com; > andrew.rybchenko@oktetlabs.ru; dev@dpdk.org > Cc: thomas@monjalon.net; huangdaode@huawei.com; > liudongdong3@huawei.com > Subject: RE: [PATCH V2] app/testpmd: fix display types failure when query > RSS rule >=20 > > -----Original Message----- > > From: Huisong Li > > Sent: Friday, July 8, 2022 9:42 AM > > To: ferruh.yigit@xilinx.com; andrew.rybchenko@oktetlabs.ru; > > dev@dpdk.org > > Cc: thomas@monjalon.net; Li, WeiyuanX ; > > huangdaode@huawei.com; liudongdong3@huawei.com; > lihuisong@huawei.com > > Subject: [PATCH V2] app/testpmd: fix display types failure when query > > RSS rule > > > > Now testpmd fails to display types when query RSS rule. The failure is > > because the '\n' character is missing at the end of the function > > 'rss_config_display()'. Actually, all places calling 'xxx_types_display= ()' > > need to '\n'. So this patch moves '\n' to the inside of these function. > > > > Fixes: 534988c490f1 ("app/testpmd: unify RSS types display") > > Fixes: 44a37f3cffe0 ("app/testpmd: compact RSS types output") > > > > --- > > v2: > > - move '\n' to the inside of 'xxx_types_display()'. > > > > Signed-off-by: Huisong Li >=20 > Tested-by: Weiyuan Li Thanks Huisong. Hi Huisong, Ferruh, May I know that this patch can be merged into RC4? Best regards, Yu Jiang