* [U-Boot] Compile error with CONFIG_MULTI_DTB_FIT and not SPL
@ 2018-10-22 8:48 Lars Povlsen
2018-10-22 15:01 ` Jean-Jacques Hiblot
0 siblings, 1 reply; 3+ messages in thread
From: Lars Povlsen @ 2018-10-22 8:48 UTC (permalink / raw)
To: u-boot
When changing some MIPS configs from CONFIG_OF_EMBED to
CONFIG_OF_SEPARATE, I ran into this compile issue since SPL is not
enabled. The fix is to guard the <spl.h> header with the
CONFIG_SPL_LIBCOMMON_SUPPORT preprocessor symbol.
It seems that the <spl.h> is not needed even when SPL is enabled, but
I'm not 100% sure on that. The code at lines 55..57 guarded by
CONFIG_SPL_LIBCOMMON_SUPPORT does not require the <spl.h> header file.
Signed-off-by: Lars Povlsen <lars.povlsen@microsemi.com>
---
common/common_fit.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/common_fit.c b/common/common_fit.c
index 577b352..33e26cc 100644
--- a/common/common_fit.c
+++ b/common/common_fit.c
@@ -8,7 +8,9 @@
#include <errno.h>
#include <image.h>
#include <linux/libfdt.h>
+#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
#include <spl.h>
+#endif
ulong fdt_getprop_u32(const void *fdt, int node, const char *prop)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] Compile error with CONFIG_MULTI_DTB_FIT and not SPL
2018-10-22 8:48 [U-Boot] Compile error with CONFIG_MULTI_DTB_FIT and not SPL Lars Povlsen
@ 2018-10-22 15:01 ` Jean-Jacques Hiblot
2018-10-23 8:23 ` Lars.Povlsen at microchip.com
0 siblings, 1 reply; 3+ messages in thread
From: Jean-Jacques Hiblot @ 2018-10-22 15:01 UTC (permalink / raw)
To: u-boot
On 22/10/2018 10:48, Lars Povlsen wrote:
> When changing some MIPS configs from CONFIG_OF_EMBED to
> CONFIG_OF_SEPARATE, I ran into this compile issue since SPL is not
> enabled. The fix is to guard the <spl.h> header with the
> CONFIG_SPL_LIBCOMMON_SUPPORT preprocessor symbol.
>
> It seems that the <spl.h> is not needed even when SPL is enabled, but
> I'm not 100% sure on that. The code at lines 55..57 guarded by
> CONFIG_SPL_LIBCOMMON_SUPPORT does not require the <spl.h> header file.
>
> Signed-off-by: Lars Povlsen <lars.povlsen@microsemi.com>
> ---
> common/common_fit.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/common/common_fit.c b/common/common_fit.c
> index 577b352..33e26cc 100644
> --- a/common/common_fit.c
> +++ b/common/common_fit.c
> @@ -8,7 +8,9 @@
> #include <errno.h>
> #include <image.h>
> #include <linux/libfdt.h>
> +#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
> #include <spl.h>
I believe that spl.h is not needed at all here. It should be removed
JJ
> +#endif
>
> ulong fdt_getprop_u32(const void *fdt, int node, const char *prop)
> {
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] Compile error with CONFIG_MULTI_DTB_FIT and not SPL
2018-10-22 15:01 ` Jean-Jacques Hiblot
@ 2018-10-23 8:23 ` Lars.Povlsen at microchip.com
0 siblings, 0 replies; 3+ messages in thread
From: Lars.Povlsen at microchip.com @ 2018-10-23 8:23 UTC (permalink / raw)
To: u-boot
...
> I believe that spl.h is not needed at all here. It should be removed JJ
Thanks for the feedback, I have sent a new patch to that effect.
---Lars
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-23 8:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-22 8:48 [U-Boot] Compile error with CONFIG_MULTI_DTB_FIT and not SPL Lars Povlsen
2018-10-22 15:01 ` Jean-Jacques Hiblot
2018-10-23 8:23 ` Lars.Povlsen at microchip.com
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.