RE: [PATCH v6] app/procinfo: display eventdev xstats for PMD data

From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Sevincer, Abdullah" <abdullah.sevincer@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: RE: [PATCH v6] app/procinfo: display eventdev xstats for PMD data
Date: Sat, 4 Mar 2023 07:17:59 +0000	[thread overview]
Message-ID: <BYAPR11MB33669DB0A2075AB6E8F79D7DFFB09@BYAPR11MB3366.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BYAPR11MB3158847730D557C7EEF7878DE9B39@BYAPR11MB3158.namprd11.prod.outlook.com>

> -----Original Message-----
> From: Sevincer, Abdullah <abdullah.sevincer@intel.com>
> 1) What is the difference between "--edev-stats-enable" and  "--edev-device-
> stats" ?
> 	--edev-stats-enable enables xstats for evendev and exits from proc-info
> application (when this flag is enabled) after displaying xstats.  It is like show
> mempool flag so we don't want bunch of different information is dumped to
> the console. The intent of the flag is distinguish dump information between
> eventdev and eth dev. If this flag is not passed no eventdev info will be
> displayed.

So you are displaying xstats. I guess the naming of the commands should be renamed.
Should start with "show"  something like  show_evdev_xtsats

> --edev-device-stats is a flag that dumps device stats like the other flags/commands introduced with this change.

Can you please clarify a little bit on  which flags and commands this display? Is this like help command for eventdev commands that you have added?
However this also should start with show_evdev_flags something like that.

--snip--

> 
> 2)Too all other comments following to simplify the code:
> 	Indeed all other commands in proc-info can be simplified but with
> below style we wanted easiness for user to remember commands and pass
> chain of commands. It is a trade of for user need to remember the format
> instead passing a name. I agree there is too much command in proc-info now. I
> will try to simplify command and code also considering something easy to
> remember from the users perspective.
> 
> 

In my opinion I see scope for simplifying this .
 if not what I have suggested earlier about command format, you can follow the other existing command format like below , to pass on the port and queue information to your eventdev commands.
Ex: --show-tx-descriptor queue_id:offset:num

---snip---

Also, please do inreply to the email , do not reply on top of the email thread.

Regards,
Reshma