All of lore.kernel.org
 help / color / mirror / Atom feed
From: G, GurucharanX <gurucharanx.g@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v1] ice: fix IPIP and SIT TSO offload
Date: Mon, 7 Feb 2022 20:32:21 +0000	[thread overview]
Message-ID: <BYAPR11MB3367141D5AA953CA64369E7EFC2C9@BYAPR11MB3367.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220114233839.67979-1-jesse.brandeburg@intel.com>



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jesse Brandeburg
> Sent: Saturday, January 15, 2022 5:09 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH net v1] ice: fix IPIP and SIT TSO offload
> 
> The driver was avoiding offload for IPIP (at least) frames due to parsing the
> inner header offsets incorrectly when trying to check lengths.
> 
> This length check works for VXLAN frames but fails on IPIP frames because
> skb_transport_offset points to the inner header in IPIP frames, which meant
> the subtraction of transport_header from inner_network_header returns a
> negative value (-20).
> 
> With the code before this patch, everything continued to work, but GSO was
> being used to segment, causing throughputs of 1.5Gb/s per thread.
> After this patch, throughput is more like 10Gb/s per thread for IPIP traffic.
> 
> Fixes: e94d44786693 ("ice: Implement filter sync, NDO operations and bump
> version")
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> --
> Testing Hints: test IPIP tunnel and VXLAN tunnel, both should use TSO.
> ---
>  .../net/ethernet/intel/ice/ice_lan_tx_rx.h    |  1 +
>  drivers/net/ethernet/intel/ice/ice_main.c     | 25 +++++++++++++------
>  2 files changed, 18 insertions(+), 8 deletions(-)
> 

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)

      parent reply	other threads:[~2022-02-07 20:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14 23:38 [Intel-wired-lan] [PATCH net v1] ice: fix IPIP and SIT TSO offload Jesse Brandeburg
2022-01-15  7:54 ` Paul Menzel
2022-02-07 20:32 ` G, GurucharanX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB3367141D5AA953CA64369E7EFC2C9@BYAPR11MB3367.namprd11.prod.outlook.com \
    --to=gurucharanx.g@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.