All of lore.kernel.org
 help / color / mirror / Atom feed
From: G, GurucharanX <gurucharanx.g@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH RESEND] i40e: Remove unnecessary synchronize_irq() before free_irq()
Date: Tue, 24 May 2022 13:48:33 +0000	[thread overview]
Message-ID: <BYAPR11MB3367C687414EEDCA02E8566FFCD79@BYAPR11MB3367.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220518213111.2444630-1-anthony.l.nguyen@intel.com>



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Tony Nguyen
> Sent: Thursday, May 19, 2022 3:01 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Zeal Robot <zealci@zte.com.cn>; Minghao Chi
> <chi.minghao@zte.com.cn>
> Subject: [Intel-wired-lan] [PATCH RESEND] i40e: Remove unnecessary
> synchronize_irq() before free_irq()
> 
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Calling synchronize_irq() right before free_irq() is quite useless. On one hand
> the IRQ can easily fire again before free_irq() is entered, on the other hand
> free_irq() itself calls synchronize_irq() internally (in a race condition free
> way), before any state associated with the IRQ is freed.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> Resending due to mail issues with Intel Wired LAN
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)

      reply	other threads:[~2022-05-24 13:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 21:31 [Intel-wired-lan] [PATCH RESEND] i40e: Remove unnecessary synchronize_irq() before free_irq() Tony Nguyen
2022-05-24 13:48 ` G, GurucharanX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB3367C687414EEDCA02E8566FFCD79@BYAPR11MB3367.namprd11.prod.outlook.com \
    --to=gurucharanx.g@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.