From: "Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>
To: "Su, Simei" <simei.su@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Su, Simei" <simei.su@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix segmentation fault for RSS init
Date: Wed, 6 Nov 2019 16:03:54 +0000 [thread overview]
Message-ID: <BYAPR11MB382900CCEF271693B3B8BE6BE0790@BYAPR11MB3829.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1573024135-267218-1-git-send-email-simei.su@intel.com>
Can you provide more details on how this fixes the issue? Looking at the code, the pointer *parser should get set by the code so I'm not sure how this change does anything.
Paul
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Simei Su
> Sent: Tuesday, November 5, 2019 11:09 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Su, Simei <simei.su@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ice: fix segmentation fault for RSS init
>
> This patch fixes core dump issue when entering safe mode with a wrong
> package file.
>
> Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
>
> Signed-off-by: Simei Su <simei.su@intel.com>
> ---
> drivers/net/ice/ice_hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index
> 3381b45..04ec30f 100644
> --- a/drivers/net/ice/ice_hash.c
> +++ b/drivers/net/ice/ice_hash.c
> @@ -236,7 +236,7 @@ struct ice_hash_match_type ice_hash_type_list[] = {
> static int ice_hash_init(struct ice_adapter *ad) {
> - struct ice_flow_parser *parser = NULL;
> + struct ice_flow_parser *parser;
>
> if (ad->active_pkg_type == ICE_PKG_TYPE_OS_DEFAULT)
> parser = &ice_hash_parser_os;
> --
> 1.8.3.1
prev parent reply other threads:[~2019-11-06 16:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 7:08 [dpdk-dev] [PATCH] net/ice: fix segmentation fault for RSS init Simei Su
2019-11-06 8:26 ` [dpdk-dev] [PATCH v2] " Simei Su
2019-11-06 16:10 ` Stillwell Jr, Paul M
2019-11-07 1:06 ` Su, Simei
2019-11-07 5:47 ` [dpdk-dev] [PATCH v3] net/ice: fix segmentation fault with a wrong package Simei Su
2019-11-07 6:14 ` Zhang, Qi Z
2019-11-11 9:06 ` Ye Xiaolong
2019-11-12 4:40 ` Su, Simei
2019-11-13 2:07 ` Ye Xiaolong
2019-11-06 16:03 ` Stillwell Jr, Paul M [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB382900CCEF271693B3B8BE6BE0790@BYAPR11MB3829.namprd11.prod.outlook.com \
--to=paul.m.stillwell.jr@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.