From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krishna Reddy Subject: RE: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook Date: Fri, 30 Aug 2019 18:05:19 +0000 Message-ID: References: <1567118827-26358-1-git-send-email-vdumpa@nvidia.com> <1567118827-26358-4-git-send-email-vdumpa@nvidia.com> <554f8de1-1638-4eb9-59ae-8e1f0d786c44@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <554f8de1-1638-4eb9-59ae-8e1f0d786c44@arm.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Robin Murphy Cc: Sachin Nikam , "Thomas Zeng (SW-TEGRA)" , Juha Tukkinen , Mikko Perttunen , Pritesh Raithatha , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , Timo Alho , Yu-Huan Hsu , "linux-tegra@vger.kernel.org" , Thierry Reding , Alexander Van Brunt , "linux-arm-kernel@lists.infradead.org" , "will.deacon@arm.com" , "joro@8bytes.org" List-Id: linux-tegra@vger.kernel.org Pj4gKwlmb3IgKGkgPSAwOyBpIDwgdG9fbnNtbXUoc21tdSktPm51bV9pbnN0OyBpKyspDQoNCj5J dCBtaWdodCBtYWtlIG1vcmUgc2Vuc2UgdG8gbWFrZSB0aGlzIHRoZSBpbm5lcm1vc3QgbG9vcCwg aS5lLjoNCglmb3IgKGkgPSAwOyBpIDwgbnNtbXUtPm51bV9pbnN0OyBpKyspDQoJCXJlZyAmPSBy ZWFkbF9yZWxheGVkKG5zbW11X3BhZ2Uoc21tdSwgaSwgcGFnZSkuLi4NCj5zaW5jZSBwb2xsaW5n IHRoZSBpbnN0YW5jZXMgaW4gcGFyYWxsZWwgcmF0aGVyIHRoYW4gaW4gc2VyaWVzIHNlZW1zIGxp a2UgaXQgbWlnaHQgYmUgYSBiaXQgbW9yZSBlZmZpY2llbnQuDQoNClN5bmMgcmVnaXN0ZXIgaXMg cHJvZ3JhbW1lZCBhdCB0aGUgc2FtZSB0aW1lIGZvciBib3RoIGluc3RhbmNlcy4gVGhlIHN0YXR1 cyBjaGVjayBpcyBzZXJpYWxpemVkLg0KSSBjYW4gdXBkYXRlIGl0IHRvIGNoZWNrIHN0YXR1cyBv ZiBib3RoIGF0IHRoZSBzYW1lIHRpbWUuDQoNCj4+ICsJaWYgKHNtbXUtPmltcGwtPnRsYl9zeW5j KSB7DQo+PiArCQlzbW11LT5pbXBsLT50bGJfc3luYyhzbW11LCBwYWdlLCBzeW5jLCBzdGF0dXMp Ow0KDQo+V2hhdCBJJ2QgaG9wZWQgaXMgdGhhdCByYXRoZXIgdGhhbiBuZWVkaW5nIGEgaG9vayBm b3IgdGhpcywgeW91IGNvdWxkIGp1c3Qgb3ZlcnJpZGUgc21tdV9kb21haW4tPnRsYl9vcHMgZnJv bSAuaW5pdF9jb250ZXh0IHRvIHdpcmUgdXAgdGhlIGFsdGVybmF0ZSAuc3luYyBtZXRob2QgZGly ZWN0bHkuIFRoYXQgd291bGQgc2F2ZSB0aGlzIGV4dHJhIGxldmVsIG9mIGluZGlyZWN0aW9uLg0K DQpXaXRoIGFybV9zbW11X2RvbWFpbiBub3cgYXZhaWxhYmxlIGluIGFybS1zbW11LmgsICBhcm0t c21tdS1udmlkaWEuYyBjYW4gZGlyZWN0bHkgdXBkYXRlIHRoZSB0bGJfb3BzLT50bGJfc3luYyBh bmQgYXZvaWQgaW5kaXJlY3Rpb24uDQpXaWxsIHVwZGF0ZSBpbiBuZXh0IHZlcnNpb24uDQoNCi1L UiANCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E0CFC3A5A4 for ; Fri, 30 Aug 2019 18:05:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFB4523429 for ; Fri, 30 Aug 2019 18:05:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="IVfN6iOC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728026AbfH3SFa (ORCPT ); Fri, 30 Aug 2019 14:05:30 -0400 Received: from nat-hk.nvidia.com ([203.18.50.4]:59670 "EHLO nat-hk.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727246AbfH3SF3 (ORCPT ); Fri, 30 Aug 2019 14:05:29 -0400 Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sat, 31 Aug 2019 02:05:28 +0800 Received: from HKMAIL104.nvidia.com ([10.18.16.13]) by hkpgpgate101.nvidia.com (PGP Universal service); Fri, 30 Aug 2019 11:05:24 -0700 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Fri, 30 Aug 2019 11:05:24 -0700 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 30 Aug 2019 18:05:24 +0000 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.59) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 30 Aug 2019 18:05:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XaE4MjVferQnN9ihleH3WmpzkDQHV8QrAw9DjYnajKPkM5LduYZytajqFSvDISTFDvV6Tv7V8NGvNc2YMeXxuYYNNDDvP/iIkM+/j7Mz3z3/NLfuV3M0UvSQMY+pe638q1v2ffLPilEZZaBKfa0IDc+FmNpI+0Y0R0ggD8lbsYChjWYUVzbYXGgwch4T7akVGWknDEWKaFx5rHbpkD/qyIrtwp4Lsp+Q5ReGDSKKuT44baJrQaVMaDxplTtbxtTT6AjeIvyms6X4WvEEow8dPXH3jIO6+5h8B2fJwz3doZD3lNRX0gtGe414ndmverfs+ha4lplvXZJC/Qxpn4SdLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wRTzU42oTS+hl/Y9AccE9c/RtuIB71TiWTKJM07i6E0=; b=b/7z9ZLDUuO0lW5/Svy7oyBq5Rl+/ijsxSRbPMfM4LcaK9txQ/ndR+vJBz50459F1e9D4mVgMC+JZxY5kaVHGjBVKcJLoVdOA3v0mbd67rN9foTexNZ84FbX363rnTytF6aG7GZrg0TIJwx2+o6BoWZej89qJd7GzxF52o8v/yOKhQ6Ivgjpe6fdp/ITmu6gZFtfo2CWFcqQi2o3d0acKmOm5VKLCybE+KD16JaZRbl71asPPkpJIJrLBW4eH5ZAaNCOaMBa7BKpX1IvDqH3xFdFecrKtc7EKICG8Od8ebzwFQrBjw0MjttowoY5NR3aDb874ly6RK0COfq8zXd1Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BYAPR12MB2710.namprd12.prod.outlook.com (20.177.124.11) by BYAPR12MB2999.namprd12.prod.outlook.com (20.178.53.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.21; Fri, 30 Aug 2019 18:05:19 +0000 Received: from BYAPR12MB2710.namprd12.prod.outlook.com ([fe80::60a8:9757:8be2:2c56]) by BYAPR12MB2710.namprd12.prod.outlook.com ([fe80::60a8:9757:8be2:2c56%6]) with mapi id 15.20.2220.013; Fri, 30 Aug 2019 18:05:19 +0000 From: Krishna Reddy To: Robin Murphy CC: Sachin Nikam , "Thomas Zeng (SW-TEGRA)" , Juha Tukkinen , Mikko Perttunen , Pritesh Raithatha , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , Timo Alho , Yu-Huan Hsu , "linux-tegra@vger.kernel.org" , Thierry Reding , Alexander Van Brunt , "linux-arm-kernel@lists.infradead.org" , "will.deacon@arm.com" , "joro@8bytes.org" Subject: RE: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook Thread-Topic: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook Thread-Index: AQHVXruLTOWAUKMP0EGEhzK6CNK386cT0DaAgAAq0XA= Date: Fri, 30 Aug 2019 18:05:19 +0000 Message-ID: References: <1567118827-26358-1-git-send-email-vdumpa@nvidia.com> <1567118827-26358-4-git-send-email-vdumpa@nvidia.com> <554f8de1-1638-4eb9-59ae-8e1f0d786c44@arm.com> In-Reply-To: <554f8de1-1638-4eb9-59ae-8e1f0d786c44@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=VDUMPA@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2019-08-30T18:05:16.2199634Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=a3d3cc0f-e7fb-4c08-bde5-5c1a13761cab; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=vdumpa@nvidia.com; x-originating-ip: [216.228.112.21] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1451366-1d2a-4b19-7341-08d72d749ea1 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:BYAPR12MB2999; x-ms-traffictypediagnostic: BYAPR12MB2999: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0145758B1D x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(376002)(346002)(39860400002)(366004)(136003)(199004)(189003)(7696005)(4326008)(64756008)(66476007)(9686003)(33656002)(14454004)(81156014)(81166006)(55016002)(8676002)(86362001)(74316002)(478600001)(316002)(305945005)(7736002)(76116006)(6116002)(6436002)(99286004)(54906003)(66066001)(3846002)(8936002)(6246003)(26005)(476003)(53936002)(66556008)(25786009)(446003)(76176011)(52536014)(71200400001)(14444005)(486006)(102836004)(71190400001)(66446008)(229853002)(66946007)(5660300002)(6506007)(6916009)(11346002)(256004)(186003)(2906002)(4744005);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR12MB2999;H:BYAPR12MB2710.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kiwwIu/EbIvxQINTf8n7K/j+rfJTW6SkBDuwYPzTZJzhLq6L5ry/jggY11jLQ+xCbH/nMFz2tqognNcwp0UmA7axrng79+RGkgi988+0RhAdmSdeDZEzo9VAtoRD2h6u2OBXUF+w8y2aHoVuUs4DQMeFIkdvDcbwHJ/2Kwhkf72lTYbDcMOhpRTHG3nonET6zph5XHxkGUYg6p6MpRSypwyo7KKcRUMS14hfVDvDnd5SMtW/GE1pKHyAvxgoh+Xxu0lQNn55Rq2k9ReUSL6QFIRmLcyWvy5V8vwp3DftEWTa+G6iRL4u5WCFSaUwVK/891KHVrqUNrw+Kvmw0C9QVVtGR2geklR6H7X7wjHW91EBUMbb10UDcEz1RF+UzpYc9KFtb8ZpCHqnEKQZF0HOxy4kL++PG0lpIUGwD5upJXk= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f1451366-1d2a-4b19-7341-08d72d749ea1 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2019 18:05:19.5842 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OFnNSL4eSWx4KGk44GvQYwmM6ehUzY7/S/NWPUZohG6xGKu2h7H93zY7tqCrkAU9R8yAPGLCY0EjYHmjnXCk9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2999 X-OriginatorOrg: Nvidia.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1567188328; bh=wRTzU42oTS+hl/Y9AccE9c/RtuIB71TiWTKJM07i6E0=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-microsoft-antispam: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-forefront-prvs:x-forefront-antispam-report:received-spf: x-ms-exchange-senderadcheck:x-microsoft-antispam-message-info: MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=IVfN6iOCJaFvdk+1h/4qndIUFRuR5gG4Pq/22jVlN7roS4skt+tj9ettqBAYDIEUn rqFeWQ7EpU1lJ7PZ74i78TgjpvZtIoN3VlytnYN/O9vzbNrY5R6f8j0nDM5X9UU3Ln LTLwucsY/4Ryq8O4ecASH5dMkRfBWHsucu/56y265lIj5lpG8FH+WrXACIy+2nZDGU y/xJ1uLvKDPiuLOsSbITR54sP3Z3XN90ZhWz84YrQ1SY0kuxdzNPLOCVzHW2QUG4ma rwrHPEwNRnwQJDoiw+Bkohrl41O71HHzxIiCjQVp9res8znpVAkA19gSoxLrLLERbT PD0P2p1DTZB9w== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pj4gKwlmb3IgKGkgPSAwOyBpIDwgdG9fbnNtbXUoc21tdSktPm51bV9pbnN0OyBpKyspDQoNCj5J dCBtaWdodCBtYWtlIG1vcmUgc2Vuc2UgdG8gbWFrZSB0aGlzIHRoZSBpbm5lcm1vc3QgbG9vcCwg aS5lLjoNCglmb3IgKGkgPSAwOyBpIDwgbnNtbXUtPm51bV9pbnN0OyBpKyspDQoJCXJlZyAmPSBy ZWFkbF9yZWxheGVkKG5zbW11X3BhZ2Uoc21tdSwgaSwgcGFnZSkuLi4NCj5zaW5jZSBwb2xsaW5n IHRoZSBpbnN0YW5jZXMgaW4gcGFyYWxsZWwgcmF0aGVyIHRoYW4gaW4gc2VyaWVzIHNlZW1zIGxp a2UgaXQgbWlnaHQgYmUgYSBiaXQgbW9yZSBlZmZpY2llbnQuDQoNClN5bmMgcmVnaXN0ZXIgaXMg cHJvZ3JhbW1lZCBhdCB0aGUgc2FtZSB0aW1lIGZvciBib3RoIGluc3RhbmNlcy4gVGhlIHN0YXR1 cyBjaGVjayBpcyBzZXJpYWxpemVkLg0KSSBjYW4gdXBkYXRlIGl0IHRvIGNoZWNrIHN0YXR1cyBv ZiBib3RoIGF0IHRoZSBzYW1lIHRpbWUuDQoNCj4+ICsJaWYgKHNtbXUtPmltcGwtPnRsYl9zeW5j KSB7DQo+PiArCQlzbW11LT5pbXBsLT50bGJfc3luYyhzbW11LCBwYWdlLCBzeW5jLCBzdGF0dXMp Ow0KDQo+V2hhdCBJJ2QgaG9wZWQgaXMgdGhhdCByYXRoZXIgdGhhbiBuZWVkaW5nIGEgaG9vayBm b3IgdGhpcywgeW91IGNvdWxkIGp1c3Qgb3ZlcnJpZGUgc21tdV9kb21haW4tPnRsYl9vcHMgZnJv bSAuaW5pdF9jb250ZXh0IHRvIHdpcmUgdXAgdGhlIGFsdGVybmF0ZSAuc3luYyBtZXRob2QgZGly ZWN0bHkuIFRoYXQgd291bGQgc2F2ZSB0aGlzIGV4dHJhIGxldmVsIG9mIGluZGlyZWN0aW9uLg0K DQpXaXRoIGFybV9zbW11X2RvbWFpbiBub3cgYXZhaWxhYmxlIGluIGFybS1zbW11LmgsICBhcm0t c21tdS1udmlkaWEuYyBjYW4gZGlyZWN0bHkgdXBkYXRlIHRoZSB0bGJfb3BzLT50bGJfc3luYyBh bmQgYXZvaWQgaW5kaXJlY3Rpb24uDQpXaWxsIHVwZGF0ZSBpbiBuZXh0IHZlcnNpb24uDQoNCi1L UiANCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C95A8C3A59B for ; Fri, 30 Aug 2019 18:07:13 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 922D521721 for ; Fri, 30 Aug 2019 18:07:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="IVfN6iOC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 922D521721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 9E939633D; Fri, 30 Aug 2019 18:07:12 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C2B4C6163 for ; Fri, 30 Aug 2019 18:05:27 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id D11B6F1 for ; Fri, 30 Aug 2019 18:05:26 +0000 (UTC) Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sat, 31 Aug 2019 02:05:28 +0800 Received: from HKMAIL104.nvidia.com ([10.18.16.13]) by hkpgpgate101.nvidia.com (PGP Universal service); Fri, 30 Aug 2019 11:05:24 -0700 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Fri, 30 Aug 2019 11:05:24 -0700 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 30 Aug 2019 18:05:24 +0000 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.59) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 30 Aug 2019 18:05:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XaE4MjVferQnN9ihleH3WmpzkDQHV8QrAw9DjYnajKPkM5LduYZytajqFSvDISTFDvV6Tv7V8NGvNc2YMeXxuYYNNDDvP/iIkM+/j7Mz3z3/NLfuV3M0UvSQMY+pe638q1v2ffLPilEZZaBKfa0IDc+FmNpI+0Y0R0ggD8lbsYChjWYUVzbYXGgwch4T7akVGWknDEWKaFx5rHbpkD/qyIrtwp4Lsp+Q5ReGDSKKuT44baJrQaVMaDxplTtbxtTT6AjeIvyms6X4WvEEow8dPXH3jIO6+5h8B2fJwz3doZD3lNRX0gtGe414ndmverfs+ha4lplvXZJC/Qxpn4SdLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wRTzU42oTS+hl/Y9AccE9c/RtuIB71TiWTKJM07i6E0=; b=b/7z9ZLDUuO0lW5/Svy7oyBq5Rl+/ijsxSRbPMfM4LcaK9txQ/ndR+vJBz50459F1e9D4mVgMC+JZxY5kaVHGjBVKcJLoVdOA3v0mbd67rN9foTexNZ84FbX363rnTytF6aG7GZrg0TIJwx2+o6BoWZej89qJd7GzxF52o8v/yOKhQ6Ivgjpe6fdp/ITmu6gZFtfo2CWFcqQi2o3d0acKmOm5VKLCybE+KD16JaZRbl71asPPkpJIJrLBW4eH5ZAaNCOaMBa7BKpX1IvDqH3xFdFecrKtc7EKICG8Od8ebzwFQrBjw0MjttowoY5NR3aDb874ly6RK0COfq8zXd1Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BYAPR12MB2710.namprd12.prod.outlook.com (20.177.124.11) by BYAPR12MB2999.namprd12.prod.outlook.com (20.178.53.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.21; Fri, 30 Aug 2019 18:05:19 +0000 Received: from BYAPR12MB2710.namprd12.prod.outlook.com ([fe80::60a8:9757:8be2:2c56]) by BYAPR12MB2710.namprd12.prod.outlook.com ([fe80::60a8:9757:8be2:2c56%6]) with mapi id 15.20.2220.013; Fri, 30 Aug 2019 18:05:19 +0000 From: Krishna Reddy To: Robin Murphy Subject: RE: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook Thread-Topic: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook Thread-Index: AQHVXruLTOWAUKMP0EGEhzK6CNK386cT0DaAgAAq0XA= Date: Fri, 30 Aug 2019 18:05:19 +0000 Message-ID: References: <1567118827-26358-1-git-send-email-vdumpa@nvidia.com> <1567118827-26358-4-git-send-email-vdumpa@nvidia.com> <554f8de1-1638-4eb9-59ae-8e1f0d786c44@arm.com> In-Reply-To: <554f8de1-1638-4eb9-59ae-8e1f0d786c44@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=VDUMPA@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2019-08-30T18:05:16.2199634Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=a3d3cc0f-e7fb-4c08-bde5-5c1a13761cab; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=vdumpa@nvidia.com; x-originating-ip: [216.228.112.21] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1451366-1d2a-4b19-7341-08d72d749ea1 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR12MB2999; x-ms-traffictypediagnostic: BYAPR12MB2999: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0145758B1D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(39860400002)(366004)(136003)(199004)(189003)(7696005)(4326008)(64756008)(66476007)(9686003)(33656002)(14454004)(81156014)(81166006)(55016002)(8676002)(86362001)(74316002)(478600001)(316002)(305945005)(7736002)(76116006)(6116002)(6436002)(99286004)(54906003)(66066001)(3846002)(8936002)(6246003)(26005)(476003)(53936002)(66556008)(25786009)(446003)(76176011)(52536014)(71200400001)(14444005)(486006)(102836004)(71190400001)(66446008)(229853002)(66946007)(5660300002)(6506007)(6916009)(11346002)(256004)(186003)(2906002)(4744005); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR12MB2999; H:BYAPR12MB2710.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kiwwIu/EbIvxQINTf8n7K/j+rfJTW6SkBDuwYPzTZJzhLq6L5ry/jggY11jLQ+xCbH/nMFz2tqognNcwp0UmA7axrng79+RGkgi988+0RhAdmSdeDZEzo9VAtoRD2h6u2OBXUF+w8y2aHoVuUs4DQMeFIkdvDcbwHJ/2Kwhkf72lTYbDcMOhpRTHG3nonET6zph5XHxkGUYg6p6MpRSypwyo7KKcRUMS14hfVDvDnd5SMtW/GE1pKHyAvxgoh+Xxu0lQNn55Rq2k9ReUSL6QFIRmLcyWvy5V8vwp3DftEWTa+G6iRL4u5WCFSaUwVK/891KHVrqUNrw+Kvmw0C9QVVtGR2geklR6H7X7wjHW91EBUMbb10UDcEz1RF+UzpYc9KFtb8ZpCHqnEKQZF0HOxy4kL++PG0lpIUGwD5upJXk= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f1451366-1d2a-4b19-7341-08d72d749ea1 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2019 18:05:19.5842 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OFnNSL4eSWx4KGk44GvQYwmM6ehUzY7/S/NWPUZohG6xGKu2h7H93zY7tqCrkAU9R8yAPGLCY0EjYHmjnXCk9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2999 X-OriginatorOrg: Nvidia.com Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1567188328; bh=wRTzU42oTS+hl/Y9AccE9c/RtuIB71TiWTKJM07i6E0=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-microsoft-antispam: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-forefront-prvs:x-forefront-antispam-report:received-spf: x-ms-exchange-senderadcheck:x-microsoft-antispam-message-info: MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=IVfN6iOCJaFvdk+1h/4qndIUFRuR5gG4Pq/22jVlN7roS4skt+tj9ettqBAYDIEUn rqFeWQ7EpU1lJ7PZ74i78TgjpvZtIoN3VlytnYN/O9vzbNrY5R6f8j0nDM5X9UU3Ln LTLwucsY/4Ryq8O4ecASH5dMkRfBWHsucu/56y265lIj5lpG8FH+WrXACIy+2nZDGU y/xJ1uLvKDPiuLOsSbITR54sP3Z3XN90ZhWz84YrQ1SY0kuxdzNPLOCVzHW2QUG4ma rwrHPEwNRnwQJDoiw+Bkohrl41O71HHzxIiCjQVp9res8znpVAkA19gSoxLrLLERbT PD0P2p1DTZB9w== Cc: Timo Alho , Thierry Reding , Mikko Perttunen , "linux-kernel@vger.kernel.org" , "will.deacon@arm.com" , "iommu@lists.linux-foundation.org" , Pritesh Raithatha , "Thomas Zeng \(SW-TEGRA\)" , Sachin Nikam , "linux-tegra@vger.kernel.org" , Yu-Huan Hsu , Juha Tukkinen , Alexander Van Brunt , "linux-arm-kernel@lists.infradead.org" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org >> + for (i = 0; i < to_nsmmu(smmu)->num_inst; i++) >It might make more sense to make this the innermost loop, i.e.: for (i = 0; i < nsmmu->num_inst; i++) reg &= readl_relaxed(nsmmu_page(smmu, i, page)... >since polling the instances in parallel rather than in series seems like it might be a bit more efficient. Sync register is programmed at the same time for both instances. The status check is serialized. I can update it to check status of both at the same time. >> + if (smmu->impl->tlb_sync) { >> + smmu->impl->tlb_sync(smmu, page, sync, status); >What I'd hoped is that rather than needing a hook for this, you could just override smmu_domain->tlb_ops from .init_context to wire up the alternate .sync method directly. That would save this extra level of indirection. With arm_smmu_domain now available in arm-smmu.h, arm-smmu-nvidia.c can directly update the tlb_ops->tlb_sync and avoid indirection. Will update in next version. -KR _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 165BDC3A59B for ; Fri, 30 Aug 2019 18:05:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDF8D23407 for ; Fri, 30 Aug 2019 18:05:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d/0mL5I9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="IVfN6iOC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDF8D23407 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wYmYtOhabB91JQs75aZK/wPanzSYMgfnL0c4xpwfmWA=; b=d/0mL5I9RXEB39 TMdg+4cnnZVqkF9QlKGuFG4XeFSSWBwcx0qBfglt+h17Bs/uPUxssYCNHSz9cTLSN6pnP5cQAGeei smod6bvEv/isUL2IQkiFWf5be7bKwKMiu0sIOf0TNObGo2LDkjl2n5xyrB5mUNP6SEi4XGAv10CLy zlzifrFC9MlywF1HseiwbmJ2a7Krd/eNvZCA8svSDhiQ6Mm6ILxXRv2loLZK80RSRhSdUc2BzdvjO 0rB/GvPJHHeHc/zKWYnxPiLuD8fO9oBk6ygwlBprMtmqcXvoS6diQVdRnF7a9FkjFJf7cIivbdkPS DPDmDiAutAYvy86FXiUQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3lH7-0000th-8t; Fri, 30 Aug 2019 18:05:29 +0000 Received: from nat-hk.nvidia.com ([203.18.50.4]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i3lH4-0000tI-JR for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2019 18:05:28 +0000 Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sat, 31 Aug 2019 02:05:28 +0800 Received: from HKMAIL104.nvidia.com ([10.18.16.13]) by hkpgpgate101.nvidia.com (PGP Universal service); Fri, 30 Aug 2019 11:05:24 -0700 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Fri, 30 Aug 2019 11:05:24 -0700 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 30 Aug 2019 18:05:24 +0000 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.59) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 30 Aug 2019 18:05:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XaE4MjVferQnN9ihleH3WmpzkDQHV8QrAw9DjYnajKPkM5LduYZytajqFSvDISTFDvV6Tv7V8NGvNc2YMeXxuYYNNDDvP/iIkM+/j7Mz3z3/NLfuV3M0UvSQMY+pe638q1v2ffLPilEZZaBKfa0IDc+FmNpI+0Y0R0ggD8lbsYChjWYUVzbYXGgwch4T7akVGWknDEWKaFx5rHbpkD/qyIrtwp4Lsp+Q5ReGDSKKuT44baJrQaVMaDxplTtbxtTT6AjeIvyms6X4WvEEow8dPXH3jIO6+5h8B2fJwz3doZD3lNRX0gtGe414ndmverfs+ha4lplvXZJC/Qxpn4SdLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wRTzU42oTS+hl/Y9AccE9c/RtuIB71TiWTKJM07i6E0=; b=b/7z9ZLDUuO0lW5/Svy7oyBq5Rl+/ijsxSRbPMfM4LcaK9txQ/ndR+vJBz50459F1e9D4mVgMC+JZxY5kaVHGjBVKcJLoVdOA3v0mbd67rN9foTexNZ84FbX363rnTytF6aG7GZrg0TIJwx2+o6BoWZej89qJd7GzxF52o8v/yOKhQ6Ivgjpe6fdp/ITmu6gZFtfo2CWFcqQi2o3d0acKmOm5VKLCybE+KD16JaZRbl71asPPkpJIJrLBW4eH5ZAaNCOaMBa7BKpX1IvDqH3xFdFecrKtc7EKICG8Od8ebzwFQrBjw0MjttowoY5NR3aDb874ly6RK0COfq8zXd1Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BYAPR12MB2710.namprd12.prod.outlook.com (20.177.124.11) by BYAPR12MB2999.namprd12.prod.outlook.com (20.178.53.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.21; Fri, 30 Aug 2019 18:05:19 +0000 Received: from BYAPR12MB2710.namprd12.prod.outlook.com ([fe80::60a8:9757:8be2:2c56]) by BYAPR12MB2710.namprd12.prod.outlook.com ([fe80::60a8:9757:8be2:2c56%6]) with mapi id 15.20.2220.013; Fri, 30 Aug 2019 18:05:19 +0000 From: Krishna Reddy To: Robin Murphy Subject: RE: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook Thread-Topic: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook Thread-Index: AQHVXruLTOWAUKMP0EGEhzK6CNK386cT0DaAgAAq0XA= Date: Fri, 30 Aug 2019 18:05:19 +0000 Message-ID: References: <1567118827-26358-1-git-send-email-vdumpa@nvidia.com> <1567118827-26358-4-git-send-email-vdumpa@nvidia.com> <554f8de1-1638-4eb9-59ae-8e1f0d786c44@arm.com> In-Reply-To: <554f8de1-1638-4eb9-59ae-8e1f0d786c44@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=VDUMPA@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2019-08-30T18:05:16.2199634Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=a3d3cc0f-e7fb-4c08-bde5-5c1a13761cab; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=vdumpa@nvidia.com; x-originating-ip: [216.228.112.21] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1451366-1d2a-4b19-7341-08d72d749ea1 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR12MB2999; x-ms-traffictypediagnostic: BYAPR12MB2999: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0145758B1D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(39860400002)(366004)(136003)(199004)(189003)(7696005)(4326008)(64756008)(66476007)(9686003)(33656002)(14454004)(81156014)(81166006)(55016002)(8676002)(86362001)(74316002)(478600001)(316002)(305945005)(7736002)(76116006)(6116002)(6436002)(99286004)(54906003)(66066001)(3846002)(8936002)(6246003)(26005)(476003)(53936002)(66556008)(25786009)(446003)(76176011)(52536014)(71200400001)(14444005)(486006)(102836004)(71190400001)(66446008)(229853002)(66946007)(5660300002)(6506007)(6916009)(11346002)(256004)(186003)(2906002)(4744005); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR12MB2999; H:BYAPR12MB2710.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: kiwwIu/EbIvxQINTf8n7K/j+rfJTW6SkBDuwYPzTZJzhLq6L5ry/jggY11jLQ+xCbH/nMFz2tqognNcwp0UmA7axrng79+RGkgi988+0RhAdmSdeDZEzo9VAtoRD2h6u2OBXUF+w8y2aHoVuUs4DQMeFIkdvDcbwHJ/2Kwhkf72lTYbDcMOhpRTHG3nonET6zph5XHxkGUYg6p6MpRSypwyo7KKcRUMS14hfVDvDnd5SMtW/GE1pKHyAvxgoh+Xxu0lQNn55Rq2k9ReUSL6QFIRmLcyWvy5V8vwp3DftEWTa+G6iRL4u5WCFSaUwVK/891KHVrqUNrw+Kvmw0C9QVVtGR2geklR6H7X7wjHW91EBUMbb10UDcEz1RF+UzpYc9KFtb8ZpCHqnEKQZF0HOxy4kL++PG0lpIUGwD5upJXk= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f1451366-1d2a-4b19-7341-08d72d749ea1 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2019 18:05:19.5842 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OFnNSL4eSWx4KGk44GvQYwmM6ehUzY7/S/NWPUZohG6xGKu2h7H93zY7tqCrkAU9R8yAPGLCY0EjYHmjnXCk9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2999 X-OriginatorOrg: Nvidia.com Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1567188328; bh=wRTzU42oTS+hl/Y9AccE9c/RtuIB71TiWTKJM07i6E0=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-microsoft-antispam: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-forefront-prvs:x-forefront-antispam-report:received-spf: x-ms-exchange-senderadcheck:x-microsoft-antispam-message-info: MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=IVfN6iOCJaFvdk+1h/4qndIUFRuR5gG4Pq/22jVlN7roS4skt+tj9ettqBAYDIEUn rqFeWQ7EpU1lJ7PZ74i78TgjpvZtIoN3VlytnYN/O9vzbNrY5R6f8j0nDM5X9UU3Ln LTLwucsY/4Ryq8O4ecASH5dMkRfBWHsucu/56y265lIj5lpG8FH+WrXACIy+2nZDGU y/xJ1uLvKDPiuLOsSbITR54sP3Z3XN90ZhWz84YrQ1SY0kuxdzNPLOCVzHW2QUG4ma rwrHPEwNRnwQJDoiw+Bkohrl41O71HHzxIiCjQVp9res8znpVAkA19gSoxLrLLERbT PD0P2p1DTZB9w== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190830_110527_115070_B59B5CA8 X-CRM114-Status: UNSURE ( 6.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Timo Alho , Thierry Reding , Mikko Perttunen , "linux-kernel@vger.kernel.org" , "joro@8bytes.org" , "will.deacon@arm.com" , "iommu@lists.linux-foundation.org" , Pritesh Raithatha , "Thomas Zeng \(SW-TEGRA\)" , Sachin Nikam , "linux-tegra@vger.kernel.org" , Yu-Huan Hsu , Juha Tukkinen , Alexander Van Brunt , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org >> + for (i = 0; i < to_nsmmu(smmu)->num_inst; i++) >It might make more sense to make this the innermost loop, i.e.: for (i = 0; i < nsmmu->num_inst; i++) reg &= readl_relaxed(nsmmu_page(smmu, i, page)... >since polling the instances in parallel rather than in series seems like it might be a bit more efficient. Sync register is programmed at the same time for both instances. The status check is serialized. I can update it to check status of both at the same time. >> + if (smmu->impl->tlb_sync) { >> + smmu->impl->tlb_sync(smmu, page, sync, status); >What I'd hoped is that rather than needing a hook for this, you could just override smmu_domain->tlb_ops from .init_context to wire up the alternate .sync method directly. That would save this extra level of indirection. With arm_smmu_domain now available in arm-smmu.h, arm-smmu-nvidia.c can directly update the tlb_ops->tlb_sync and avoid indirection. Will update in next version. -KR _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel