From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhu, Rex" Subject: RE: [PATCH] drm/amd/dc: Trigger set power state task when display configuration changes Date: Tue, 18 Sep 2018 05:44:37 +0000 Message-ID: References: <1536904627-24761-1-git-send-email-Rex.Zhu@amd.com> , Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0598470281==" Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Francis, David" , "Deucher, Alexander" , "Wentland, Harry" Cc: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" --===============0598470281== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BYAPR12MB277585FBE856647226005A97FB1D0BYAPR12MB2775namp_" --_000_BYAPR12MB277585FBE856647226005A97FB1D0BYAPR12MB2775namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi David, Yes, There is an issue you pointed out on Raven. Because the force_dpm_leve= l was added for UMD-P state and the min clocks were hardcode. The display's= clock requests were ignored. I will fix this issue. Thanks. Best Regards Rex From: Francis, David Sent: Monday, September 17, 2018 9:31 PM To: Zhu, Rex ; Deucher, Alexander ; Wentland, Harry Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Subject: Re: [PATCH] drm/amd/dc: Trigger set power state task when display = configuration changes On Linux, the clocks are already set by the time that function call is reac= hed. amdgpu_pm_compute clocks resets the clocks to their default value. ________________________________ From: Zhu, Rex Sent: September 17, 2018 4:12:33 AM To: Deucher, Alexander; Wentland, Harry; Francis, David Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Subject: RE: [PATCH] drm/amd/dc: Trigger set power state task when display = configuration changes +Harry and David. Best Regards Rex From: Deucher, Alexander Sent: Friday, September 14, 2018 9:40 PM To: Zhu, Rex >; amd-gfx-PD4FTy7X32mMSPqsTGOZug@public.gmane.org= esktop.org Subject: Re: [PATCH] drm/amd/dc: Trigger set power state task when display = configuration changes Acked-by: Alex Deucher > ________________________________ From: amd-gfx > on behalf of Rex Zhu > Sent: Friday, September 14, 2018 1:57:07 AM To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Zhu, Rex Subject: [PATCH] drm/amd/dc: Trigger set power state task when display conf= iguration changes Revert "drm/amd/display: Remove call to amdgpu_pm_compute_clocks" This reverts commit dcd473770e86517543691bdb227103d6c781cd0a. when display configuration changes, dc need to update the changes to powerplay, also need to trigger a power state task. amdgpu_pm_compute_clocks is the interface to set power state task either dpm enabled or powerplay enabled Signed-off-by: Rex Zhu > --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c b/dri= vers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c index 6d16b4a..0fab64a 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c @@ -105,6 +105,8 @@ bool dm_pp_apply_display_requirements( adev->powerplay.pp_funcs->display_configuration_ch= ange( adev->powerplay.pp_handle, &adev->pm.pm_display_cfg); + + amdgpu_pm_compute_clocks(adev); } return true; -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx --_000_BYAPR12MB277585FBE856647226005A97FB1D0BYAPR12MB2775namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi David,

 

Yes, There is an issue you pointed out on Raven. Bec= ause the force_dpm_level was added for UMD-P state and the min clocks were = hardcode. The display’s clock requests were ignored.

I will fix this issue.

Thanks.

 

Best Regards

Rex  

 

From: Francis, David
Sent: Monday, September 17, 2018 9:31 PM
To: Zhu, Rex <Rex.Zhu-5C7GfCeVMHo@public.gmane.org>; Deucher, Alexander <Alexand= er.Deucher-5C7GfCeVMHo@public.gmane.org>; Wentland, Harry <Harry.Wentland-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amd/dc: Trigger set power state task when d= isplay configuration changes

 

On Linux, the clocks are al= ready set by the time that function call is reached.  amdgpu_pm_comput= e clocks resets the clocks to their default value.

From: Zhu, Rex
Sent: September 17, 2018 4:12:33 AM
To: Deucher, Alexander; Wentland, Harry; Francis, David
Cc: amd-gfx@= lists.freedesktop.org
Subject: RE: [PATCH] drm/amd/dc: Trigger set power state task when d= isplay configuration changes

 

+Harry and David.

 

Best Regards

Rex

 

From: Deucher, Alexander
Sent: Friday, September 14, 2018 9:40 PM
To: Zhu, Rex <Rex.Zhu-5C7GfCeVMHo@public.gmane.org<= /a>>; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amd/dc: Trigger set power state task when d= isplay configuration changes

 

From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Rex Zhu <Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
Sent: Friday, September 14, 2018 1:57:07 AM
To: amd-gfx@= lists.freedesktop.org
Cc: Zhu, Rex
Subject: [PATCH] drm/amd/dc: Trigger set power state task when displ= ay configuration changes

 

Revert "drm/amd/display: Remove call to amdgpu= _pm_compute_clocks"

This reverts commit dcd473770e86517543691bdb227103d6c781cd0a.

when display configuration changes, dc need to update the changes
to powerplay, also need to trigger a power state task.
amdgpu_pm_compute_clocks is the interface to set power state task
either dpm enabled or powerplay enabled

Signed-off-by: Rex Zhu <Rex.Zhu@amd.c= om>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 2 += 3;
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c b/dri= vers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c
index 6d16b4a..0fab64a 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c<= br> @@ -105,6 +105,8 @@ bool dm_pp_apply_display_requirements(
            &nb= sp;            adev-= >powerplay.pp_funcs->display_configuration_change(
            &nb= sp;            =         adev->powerplay.pp_handle,             &nb= sp;            =         &adev->pm.pm_display_cfg)= ;
+
+           &nbs= p;   amdgpu_pm_compute_clocks(adev);
         }
 
         return true;
--
1.9.1

_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9/rsn8yoX9R0@public.gmane.org= org
https://= lists.freedesktop.org/mailman/listinfo/amd-gfx

--_000_BYAPR12MB277585FBE856647226005A97FB1D0BYAPR12MB2775namp_-- --===============0598470281== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== --===============0598470281==--