All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: Spike Du <spiked@nvidia.com>, Matan Azrad <matan@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	Ori Kam <orika@nvidia.com>,
	"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
	Shahaf Shuler <shahafs@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] mlx5/testpmd: fix crash on quit with avail thresh enabled
Date: Sun, 6 Nov 2022 15:42:22 +0000	[thread overview]
Message-ID: <BYAPR12MB3078FDA7C42D672149A3EEC4CF3D9@BYAPR12MB3078.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20221102114425.2091580-1-spiked@nvidia.com>

Hi,

> -----Original Message-----
> From: Spike Du <spiked@nvidia.com>
> Sent: Wednesday, November 2, 2022 1:44 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-
> Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Shahaf Shuler
> <shahafs@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH v2] mlx5/testpmd: fix crash on quit with avail thresh enabled
> 
> When testpmd quit with mlx5 avail_thresh enabled, a rte timer handler
> delays to reconfigure rx queue to re-arm this event. However at the same
> time, testpmd is destroying rx queues.
> It's never a valid use case for mlx5 avail_thresh. Before testpmd quit,
> user should disable avail_thresh configuration to not handle the events.
> This is documented in mlx5 driver guide.
> 
> To avoid the crash in such use case, check port status, if it is not
> RTE_PORT_STARTED, don't process the avail_thresh event.
> 
> Fixes: f41a5092e6ae ("app/testpmd: add host shaper command")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Spike Du <spiked@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

      parent reply	other threads:[~2022-11-06 15:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24  3:14 [PATCH] app/testpmd: fix testpmd crash when quit with mlx5 avail_thresh enabled Spike Du
2022-10-27  9:04 ` Singh, Aman Deep
2022-11-02 11:44 ` [PATCH v2] mlx5/testpmd: fix crash on quit with avail thresh enabled Spike Du
2022-11-06 13:26   ` Matan Azrad
2022-11-06 15:42   ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR12MB3078FDA7C42D672149A3EEC4CF3D9@BYAPR12MB3078.namprd12.prod.outlook.com \
    --to=rasland@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=spiked@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.