From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sony.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=S1; bh=jPthh4mVuA/00/MVCO01i9lLBQQmD/kA6gGHgVslr7k=; b=dlN93QlcPsatAuTzwQboKn4vg0SxQRoQOOa5Ffh1FYoQ0Nh8cdHmmxHEssMYnVq61tCs BanKRRtBKdGEKo5xKZ0ZtZYyhXoitvoSRvNwKS0iGM1oDJFNNAtW4G0Kutw3hIr9QOQH iicsttrImEdwXDugYlkm/it3UZx6AZ38K9MyK6tbnHFh+Yxjuxvg0G/oUC5+Lk33YAbe +Jn9GDrVxLFGCVIPezMGDvuy6Y4tji2B3R/tKYOy1vIVMAUq5J2plUBApIYFBLclS7pB 9QeD2PUPNb2PY3dR2j5VdQN9s/SdRX8ejeG4vbeOvDCgaS8MVVtqwi4yoI8+BM24t5gE Ug== From: Date: Thu, 22 Jul 2021 19:03:18 +0000 Message-ID: References: <20210718111012.21407-1-venkata.pyla@toshiba-tsip.com> <20210718111012.21407-7-venkata.pyla@toshiba-tsip.com> In-Reply-To: <20210718111012.21407-7-venkata.pyla@toshiba-tsip.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Fuego] [fuego-core 6/7] LTP: execute all tests when spec specifies "all" List-Id: Mailing list for the Fuego test framework List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: venkata.pyla@toshiba-tsip.com Cc: fuego@lists.linuxfoundation.org, tho1.nguyendat@toshiba.co.jp This one has problems. > -----Original Message----- > From: venkata.pyla@toshiba-tsip.com > Subject: [fuego-core 6/7] LTP: execute all tests when spec specifies "all= " >=20 I'm not sure that the summary line of this change matches what it does. >From reading the code, it appears that "tests" in the spec needs to be missing or empty, in order to activate this. If "tests" is "all",=20 then it appears that none of the tests will match, and you'd just end up with empty lists. Also, I had to intuit the reasoning here, since there is no description for this. I don't mind the concept of being able to easily run all LTP tests, but it would be nice to use the string "all" to signal this instead of just leaving FUNCTIONAL_LTP_TESTS empty. It should probably go into a comment in the code as well, and maybe in the test.yaml file, so that users and future developers will see it and understand the behaviour. Also, you might want to add a spec to the spec.json file for "all", to show it's usage. > From: Nguyen Dat Tho >=20 > Signed-off-by: Nguyen Dat Tho > Signed-off-by: Daniel Sangorrin > Signed-off-by: venkata pyla > --- > tests/Functional.LTP/fuego_test.sh | 42 +++++++++++++++++------------- > 1 file changed, 24 insertions(+), 18 deletions(-) >=20 > diff --git a/tests/Functional.LTP/fuego_test.sh b/tests/Functional.LTP/fu= ego_test.sh > index e620b17..16d556f 100755 > --- a/tests/Functional.LTP/fuego_test.sh > +++ b/tests/Functional.LTP/fuego_test.sh > @@ -188,7 +188,6 @@ function test_pre_check { > assert_define AR > assert_define RANLIB > #assert_define LDFLAGS > - assert_define FUNCTIONAL_LTP_TESTS >=20 > # FIXTHIS: use regex for selecting tests to skip once merged on LTP = upstream > echo "Tests skipped by default in Fuego for now" > @@ -453,25 +452,32 @@ function test_run { > # on the type of the test (regular, posize, or realtime) > # Separate the test list by type, and pass the tests in differen= t > # variables > - for a in $FUNCTIONAL_LTP_TESTS; do > - for b in $ALLTESTS; do > - if [ "$a" =3D=3D "$b" ]; then > - TESTS+=3D"$a " > - fi > - done > - > - for b in $ALLPTSTESTS; do > - if [ "$a" =3D=3D "$b" ]; then > - PTSTESTS+=3D"$a " > - fi > - done >=20 > - for b in $ALLRTTESTS; do > - if [ "$a" =3D=3D "$b" ]; then > - RTTESTS+=3D"$a " > - fi > + if [ -n "$FUNCTIONAL_LTP_TESTS" ]; then > + for a in $FUNCTIONAL_LTP_TESTS; do > + for b in $ALLTESTS; do > + if [ "$a" =3D=3D "$b" ]; then > + TESTS+=3D"$a " > + fi > + done > + > + for b in $ALLPTSTESTS; do > + if [ "$a" =3D=3D "$b" ]; then > + PTSTESTS+=3D"$a " > + fi > + done > + > + for b in $ALLRTTESTS; do > + if [ "$a" =3D=3D "$b" ]; then > + RTTESTS+=3D"$a " > + fi > + done > done > - done > + else > + TESTS=3D$ALLTESTS > + PTSTESTS=3D$ALLPTSTESTS > + RTTESTS=3D$ALLRTTESTS > + fi >=20 > # Let some of the tests fail, the information will be in the res= ult xlsx file > report "cd $LTP_DESTDIR; export TESTS=3D\"$TESTS\"; export PTSTE= STS=3D\"$PTSTESTS\"; export RTTESTS=3D\"$RTTESTS\"; > ./ltp_target_run.sh" > -- > 2.20.1 >=20 I have NOT applied this one. Please change this to check for the string "a= ll" in FUNCTIONAL_LTP_TESTS (and please submit a sample spec to go with this). Thanks, -- Tim