From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sony.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=S1; bh=gCOlnefx8Z85xmzWTMai2Z2XEWCT4beuwjAKkr/z19o=; b=XKkEo6JucIABU/1/EmJibYd6dmC6G9pqN7UN3Y65V7dhyygQMtqM7ez6qiIsIQNKq917 qIQ6Y2HwpVFVbHun+2K+bxoD30nZHT+D+Z3fQ+d9fakyRbjWs5kgmcsVI3pKG/Y1XayL Q8qdpO/tDknw597S0kQvZ4nyb+hDuLgeN22oTWBOCjwUXso8K61MvG+bY2RNRsl3/xxb IeMURjmNIO83LxJy0cTvfUqGzs3+QYie0l9gnwmzWmpwUqCw7PH5ORcrLgtepTaWsqqx CGu6q5QIjjoqmRlkCrG3J8gyWO559MyRNI0P5FDcDK89sW7002xRtnJ1W4+LC8LvR93C BQ== From: Date: Thu, 26 Aug 2021 17:53:43 +0000 Message-ID: References: In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Fuego] [PATCH 2/4] linaro: update to python3 List-Id: Mailing list for the Fuego test framework List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: daniel.sangorrin@toshiba.co.jp Cc: fuego@lists.linuxfoundation.org, tho1.nguyendat@toshiba.co.jp Ok - I went to apply this today, and I realized I still have some questions= ... See inline below. > -----Original Message----- > From: Daniel Sangorrin >=20 > From: Nguyen Dat Tho >=20 > The upstream linaro repository[1] now uses python3 so > use pip3 to install the requirements >=20 > [1] https://github.com/Linaro/test-definitions >=20 > Signed-off-by: Nguyen Dat Tho > Signed-off-by: Daniel Sangorrin > --- > tests/Functional.linaro/fuego_test.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/Functional.linaro/fuego_test.sh b/tests/Functional.lin= aro/fuego_test.sh > index 677ab49..c775baa 100755 > --- a/tests/Functional.linaro/fuego_test.sh > +++ b/tests/Functional.linaro/fuego_test.sh > @@ -26,8 +26,10 @@ function test_pre_check { > } >=20 > function test_build { > + apt-get install python3-pip > source ./automated/bin/setenv.sh > - pip install -r $REPO_PATH/automated/utils/requirements.txt --user > + pip3 install setuptools --user > + pip3 install -r $REPO_PATH/automated/utils/requirements.txt --user > } What is the effective user account when this is run in Fuego non-container mode? For non-container execution, do you execute build steps as user 'fuego' or 'jenkins'? For a container environment, the build steps are performed as user 'jenkins'. Will these steps even work, in that environment? Does this need to be 'sudo apt-get install', to handle the container case? Do the pip3 operations work at the system level, or at the level of an individual account. If a better python3-pip is needed for building, I think this should go into the installation scripts, unless this is intended to be doing somethin= g on the device under test, and not the host. This will have a permanent effect on the build environment, for either the container, or the host machine where Fuego is running. In your test environment, is the host machine the same as the device under test, so that these changes are thrown away when the image is thrown away? Or is this persistent? It seems like there should be a check to avoid re-installing these, if they are already present. But maybe "apt-get install " or "pip3 install" will just issue a warning, and there is not harm to executing these if the packages are already there. Anyway, as you can tell, I am confused by this patch. Overall, I don't object to it. I just want to understand what's happening with pip3 installation and setuptools installation at the user level and system level, for the case where: - the test is executing in a Fuego container, with a remote DUT - the test is executing in a Fuego container, with a local DUT (DUT=3Dself= ) - the text is executing natively, with a remote DUT - the test is executing natively, with a local DUT (DUT=3Dself) Thanks, -- Tim