From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF96C7618F for ; Mon, 15 Jul 2019 16:50:49 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id A4C9A206B8 for ; Mon, 15 Jul 2019 16:50:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="mMFwddWm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="wmOL/ZRC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4C9A206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9267C2C6A; Mon, 15 Jul 2019 18:50:47 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 428712C23 for ; Mon, 15 Jul 2019 18:50:46 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6FGo7kp005078; Mon, 15 Jul 2019 09:50:43 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=IkhnnWXg7LqULDZ58p0lQa0BvfMvxPGh7LmXST1URp4=; b=mMFwddWmsSuhd6x7T4Y1s4d43zzw35A9viP8cTcvZRL1JKlQGWo/jdO08C6vesMPO48P vttb3CB8tn53hfHiKgfIyR1SziHitXn8hKYtG3I0My7v6AyA3mqGq6ulH1iCn8dVtsF0 iQxj+BC/9XRAwyPmwTYflfktf1L1aCfo9IfpYa0SuhITLTHwb7GwYtFWdT5GZ4mlT6Lm G3wOy58dtYAzbDWoqZlVYq0OL0wVygdjhwmTWz1ZXVf+wA8Vo4br7CZreRzr7oYkPIGA 5tVzJXfMBicmzqC+OnKyB/6ypzo1si4oAQXXRsDmj5M4+eOoFYO7VmKhMElJVD0pDRDb fw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2tqcnprex7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 15 Jul 2019 09:50:43 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 15 Jul 2019 09:50:41 -0700 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.52) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 15 Jul 2019 09:50:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZSGrlacWV8dVP850iMy1DXTqIV7kYKIN1NcNUiCxUgGyRL/x0BE8OIDMYL2QzCD8T6gwQraucOC0YfDCYvZjtRzsOxOeldk2TYsZmqdSNEW+j4TRp1UZ1FXyLXy2VLxLTxL1XBLSiiianc3HS5kNcZf5vqxabHuGGwQZTnuXekjlXjAPuwkLgXbINtRLhr4jlo6l5j4YwtVDOEFDB4hEncA2n8eQiAErFnv/dS/4uIRzoGq6hqmCDe4hh+ZUNWSe9zRlziSD79UCUJImkx1gFa0u8mii0rmosMZ+zVjda8yJilS76FLvtBzMWGy9iGl2hH3fhjldtCIJmQJHXkZcrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IkhnnWXg7LqULDZ58p0lQa0BvfMvxPGh7LmXST1URp4=; b=ZjfuSMBsgLQl5CLuvKrJaeg30MQCjK/0QPga6NvLnmekUKJt1KFmCzJ6rprsjoRRuY1IiE0XWgeiXz+/NdnyB6fi+CQ5/qTBJFFH2xXd78CcuXtdPJmI1nfZae+qtiwCpo+pBcxXiDk1pTRgI00eqVcaPcjPrhe6uM3XneIhY1jEMnaszSjCp5EdfjYb+kMCMfgMlKGYZaQR52vueTw5UMfeynMV6XaulErffUxnkrxL3JMVl9Lw1KDw4VRjJLRF54cmYuOWt/2E1GybmfnboeFPkjrqppAJCvAYsKMin4j/8wf9l7lCE7DtxPhM8wVaW8XSgmE1pedbZE40KuNmkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IkhnnWXg7LqULDZ58p0lQa0BvfMvxPGh7LmXST1URp4=; b=wmOL/ZRCifPHCoEI+H6nfFs5/ml4IomPblsv5uAhjh0YMHCjKetXFhWCpj1lk08tYwZjgT9OF2mUPY2iXNUSQt0WeiwaxTc1CnLrO4Yj0LRvqdAPV/KfU7gkh6kIyDxiCW2De2RKwDoOCfi6Bo97wD6mYMQ68hWyaTK9sNo/Hs4= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2599.namprd18.prod.outlook.com (20.179.94.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.10; Mon, 15 Jul 2019 16:50:35 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2073.012; Mon, 15 Jul 2019 16:50:35 +0000 From: Jerin Jacob Kollanukkaran To: Hyong Youb Kim , David Marchand , Thomas Monjalon , "Ferruh Yigit" CC: "dev@dpdk.org" , John Daley , "Shahed Shaikh" , Nithin Kumar Dabilpuram Thread-Topic: [RFC PATCH] vfio: avoid re-installing irq handler Thread-Index: AdU7LOBENm/7fWlUSVuvO2rop1WEPw== Date: Mon, 15 Jul 2019 16:50:35 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.200.248.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 11676e2d-7eff-46e4-8e87-08d709448ee3 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2599; x-ms-traffictypediagnostic: BYAPR18MB2599: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 00997889E7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(376002)(366004)(346002)(136003)(199004)(189003)(13464003)(8936002)(4744005)(71190400001)(71200400001)(52536014)(110136005)(229853002)(33656002)(5660300002)(107886003)(2906002)(316002)(55016002)(6306002)(68736007)(6506007)(25786009)(6246003)(9686003)(4326008)(6436002)(7696005)(7736002)(6116002)(53936002)(26005)(256004)(186003)(53546011)(76116006)(102836004)(66066001)(3846002)(99286004)(66446008)(486006)(81166006)(966005)(86362001)(81156014)(64756008)(66946007)(66556008)(66476007)(305945005)(476003)(478600001)(74316002)(14454004)(8676002)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2599; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Cmn1EWkukuspMz5OAo6qF//5NBkb2erUfyz4XakEdx+oM3C89VjYQ+rd7c5CqDOUyG7E6zT4jVIogJCtlzqRs9Q/isvepmJElTyU8aTQVezCwDrFcpVRDtSwSkc9rLmS4+CZoJ7R6Og9isQKLVmRL1mkdkFiYq+nuwVjetfP/n+kLf6KO+fnexSTIdiKcFieonpqwtRVR8rgNk3+LmSOV3lwOAuVURfcCuv9VjB295fGoM1Dl5pYIz4XlOJDFyCW+jnT4a3RHXYKQyHPOcwhdGa4SUls3pBAXM2muSHmhk6z5u2e4gk00cl9kr/tJKwsLuQO0pOTSOh49xC5tIu5XY08odj3pygVHHd30V+Od6fJqwdJI/baJkUZ6+1ixAa+NtJCuO+tO4aNwmJztmQw0PjOEdvvDKh/WmjSW/kzHwE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 11676e2d-7eff-46e4-8e87-08d709448ee3 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2019 16:50:35.3799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2599 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-15_05:2019-07-15,2019-07-15 signatures=0 Subject: Re: [dpdk-dev] [RFC PATCH] vfio: avoid re-installing irq handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Hyong Youb Kim > Sent: Monday, July 15, 2019 9:28 PM > To: David Marchand ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Ferruh Yigit > Cc: dev@dpdk.org; John Daley ; Hyong Youb Kim > > Subject: [EXT] [RFC PATCH] vfio: avoid re-installing irq handler >=20 > A rough patch for the approach mentioned earlier. It is only for discussi= on. > http://mails.dpdk.org/archives/dev/2019-July/138113.html >=20 > To try this out, first revert the following then apply. > commit 89aac60e0be9 ("vfio: fix interrupts race condition") Yes. This patch has to be to reverted. It changes the existing interrupt be= havior and does not address the MSIX case as well. I think, The clean fix would be to introduce rte_intr_mask() and rte_intr_u= nmask() by abstracting the INTX and MSIX differences And let qede driver call it as needed. Thoughts?