From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5561BC282CE for ; Wed, 22 May 2019 11:54:21 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id CC3FA20815 for ; Wed, 22 May 2019 11:54:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="zJKtUzQa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="DxqNAgpE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC3FA20815 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9890D14EC; Wed, 22 May 2019 13:54:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 190D2201; Wed, 22 May 2019 13:54:17 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4MBnttO006270; Wed, 22 May 2019 04:54:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=TSkYOgk0FYvYyWEPk/Zr9NstasHPA88BXdLKs1xvfx8=; b=zJKtUzQaL4zVnn0wCw/F/ykTUMnx+NqA1hV4QQNGijXKfWNaHP2i2MGOq/8lg8fpBtKx GXFNOOAtVt+LRUFbISPB1p6u+Ka+HusWGw5Oj8OlAfi3ZuQshANRuyjxbcp0tw1Ywiwl N4xgiHe3jwX4SKfPT9zkOtag+B/uP5aKCaZKMzJXFB2qMXgjGTkd3hRPNtWTrTjeko1s v67CXNbrbTfUhbEC0PF8ULN/wx48sUnKvDUdR1MW+fCo7J/2MFww+JjhRoQsQrq7BiHx ebSKlxgl9iQV6fvthud1q1OJMvxHORlhutVSWzwYDTjNAUZuf8m5iUnUDPXmUlu3AEm9 Sw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 2smnwjv9e2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 22 May 2019 04:54:17 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 22 May 2019 04:54:15 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.51) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 22 May 2019 04:54:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TSkYOgk0FYvYyWEPk/Zr9NstasHPA88BXdLKs1xvfx8=; b=DxqNAgpEUO6J26/wDEJqUYkRj53CyaUTVuyy6DfsDcqRQlWzu2dyzRU+P6x+nFcYgdvYbGYVP/an5Hm7v2iobWzJmBd1ZbvSIA9mwm2Qq0TzB7+xW/rGhcF7oWxOJulUDZINMvtgR6RfPSa6kUu/wVeawyga3rSOqpxqkfBGx5I= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2821.namprd18.prod.outlook.com (20.179.57.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.16; Wed, 22 May 2019 11:54:13 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::1ce4:557d:eeb8:843c%7]) with mapi id 15.20.1900.020; Wed, 22 May 2019 11:54:13 +0000 From: Jerin Jacob Kollanukkaran To: Bruce Richardson CC: Neil Horman , "dev@dpdk.org" , "thomas@monjalon.net" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] Re: [PATCH] devtools: skip the symbol check when map file under drivers Thread-Index: AdUQlHPvzJ+kO9TbR5mYn3Q4jaf+fA== Date: Wed, 22 May 2019 11:54:13 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.201.57.97] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c29d7766-ffb4-4d39-2bea-08d6deac359f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:BYAPR18MB2821; x-ms-traffictypediagnostic: BYAPR18MB2821: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0045236D47 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(39860400002)(396003)(376002)(346002)(189003)(199004)(13464003)(6436002)(54906003)(9686003)(55016002)(99286004)(478600001)(6506007)(316002)(6246003)(53546011)(305945005)(7696005)(256004)(55236004)(2906002)(14444005)(5660300002)(26005)(7736002)(86362001)(102836004)(186003)(6916009)(52536014)(64756008)(3846002)(6116002)(81156014)(71200400001)(8676002)(71190400001)(66446008)(8936002)(81166006)(53936002)(14454004)(4326008)(74316002)(25786009)(68736007)(66066001)(66556008)(66476007)(229853002)(476003)(66946007)(486006)(76116006)(33656002)(73956011); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2821; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0Wn9Ej2+BIKxrox2Ij77RVCv/0eEnGpQOSrmvSPPe127ZSaEBTb4UZQo4xY/pHUeP+LS92+8QMPYzFNIfzMtetqMbbEUUbSROpqUsthKN5ETEv3QputSP6KQMv+TcKbSwnHPW62no2dF0W4SKz9J41xxCAwU3f8Un4OmCWWS53IR3uCl5Hx7+WKUZLBfC6qNeniwc2Dtm4cXYx3CF+oi/UaV5DCRFHGhTteXYbBURlFf5hD9syMUpjNwzSU8rcGY6qLBteKUmUQITej7mrKgLbtRDT49aKutOrmn9XDPDgT1e3n7lwXTxYil+RN2//KgXfB5WLq+uP6r1WtVsWedeJmc0dqdpIWrdDki311twE0cvjUtjBfpLxiCwq2xXUXVp7yDhtJmtrfq4v6clOu9FpZ43d+W36QkY7w5uOz9vf0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c29d7766-ffb4-4d39-2bea-08d6deac359f X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2019 11:54:13.3629 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2821 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-22_05:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH] devtools: skip the symbol check when map file under drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Wednesday, May 22, 2019 4:21 PM > To: Jerin Jacob Kollanukkaran > Cc: Neil Horman ; dev@dpdk.org; > thomas@monjalon.net; stable@dpdk.org > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] devtools: skip the symbol check > when map file under drivers >=20 > > > Sorry, but I'm not ok with this, because many of our DPDK PMDs have > > > functions that get exported which are meant to be called by > > > applications directly. The > > > > OK. Just to update my knowledge, Should those API needs to go through > > ABI/API depreciation process? > > > > Actually, I am concerned about the APIs, which is called between > > drviers not the application. For example, > > drivers/common/dpaax/rte_common_dpaax_version.map > > > > it is not interface to application rather it is for intra driver case. > > I think, I can change my logic to Skip the symbols which NOT starting w= ith > rte_. > > Agree? > > > > Context: > > I am adding a new driver/common/octeontx2 directory and it has some > > API which Needs to shared between drivers not to the application. For > > me, it does not make sense to go through any ABI process in such case. > > > > > Maybe not, but other drivers will have APIs designed for apps to call dir= ectly - > some NIC drivers have them, and I suspect that rawdev drivers will need > them a lot. Therefore, it's best to have the drivers directory scanned by= our > tooling. Agreed. But all of those API which called directly called from application is starts with rte_ symbol. How about skipping the symbols which is NOT sta= rt with rte_* example: drivers/common/octeontx/rte_common_octeontx_version.map drivers/common/dpaax/rte_common_dpaax_version.map