From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10DB3C76188 for ; Fri, 19 Jul 2019 05:03:03 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8DFB72082F for ; Fri, 19 Jul 2019 05:03:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="HHn9PoLr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="Y7LJ4m78" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DFB72082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B46F4231E; Fri, 19 Jul 2019 07:03:00 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id C78C21DBF for ; Fri, 19 Jul 2019 07:02:58 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6J50I6b020118; Thu, 18 Jul 2019 22:02:54 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=tx7TlNbnZIAFgSZQKtlMCV83l4mGf2YMUvp0Lruc1U0=; b=HHn9PoLr4spJDf7AbKX9uThvkqGyfb6bMphblqiQ17CkhlmNyw/vQSciK05HS4Nn2G9N Bsl6Rgn+OVJtOKuHdOq23LXOG9TZBFlcsy149cE0GO2EII4GHFkMjIxtECpSrcFpbI2i N4F342xWO8yylu8yWY9Ic30TCcHql0/xKdyAXwh7coE8WBiJ6FQeu6Vw0X4I18raBo3z 5E0vs/cR13UIgtH6IxE2gzuXGmLjYaNUdKhoJykRtU8OAz4eRSUzY//mvpLrfH9fdP9x N9AniUW3csfNCMmSlDH0a40flgilWr1H7XWVG78YJ40ZXqSe2+lYP5/fGcLEh+3XC3A/ bQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2ts07vr3s1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2019 22:02:54 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 18 Jul 2019 22:02:53 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.58) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 18 Jul 2019 22:02:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gMPidZUWxV7wOujs2jF0VcVBGPb318ag4RWVSW0o3cdx9rilVqoyBOeOTSiMum6ag2CM2HF0xUn1gn2kZ1434iRA5HwA+Cs20nUqbm+X1CLFRgqam6Pv/5S/cOSnqJXU1iVjVaA3HH9EipQxoQShJsyee3W0LCZaE8WrmpDark21930ScxELm9xnMvNtVw/u6SzksPG1MOOvQNkNam1hyL9NYEeHoT/aO0K1oNM8E4XlIuwnrdUuk7InRa17b89fpd3D7txq7gR1T6/tk6UtgDLxLIL/Slhw96fJQdGZIVk6sSql1N9oHf6m9mLTxNdVWgEMcBhhiks4omkDA0o3qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tx7TlNbnZIAFgSZQKtlMCV83l4mGf2YMUvp0Lruc1U0=; b=a0VKFdVnOONJKN+ATo3aboAuFaX2VsspxSi9T2GSvayqi+O857kyQVDDbMYhTQMFzcCNq3i+Uk91hOqMYKzi2qOOcv6XxFluJBX+oTVM3dK8rHQ4S+3dLXrn4x13j93Uf2rRJcxnjuYmqYSfpWS0HiuJn4fV3QP3U1bXv/9b2GsvzF207waey6PWySPyCAoR2dDpdCxRXoF0d0RdLAFEzXLbptL1Pk9aiCTXmHopE1iiKOrnviXajPFnt2vkrPZe2xTyKqKKnD+zQvNnm+i01WFynrVxPmCbBYJyKI0q5TlAxunpXoaOBvLmMbctU0hsDyu6psuiGFOdcjrVvp+ntQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tx7TlNbnZIAFgSZQKtlMCV83l4mGf2YMUvp0Lruc1U0=; b=Y7LJ4m78R0XSlOjXx+p8bLBm2ZQ6Tp4zGPUOo+k94APYz4ZazqQf2WlI6P3SM664mWAeLApe2GuAgGoYxgWSpnCv2ttgREm8LE+o+ashOGTUtCdbFk38UGcKbBfWqnm7wNnePwCRE6ntR3ad/4NpyyJBn4/3S0yTLGxZ2A2m0Y4= Received: from BYAPR18MB2424.namprd18.prod.outlook.com (20.179.91.149) by BYAPR18MB2630.namprd18.prod.outlook.com (20.179.94.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Fri, 19 Jul 2019 05:02:51 +0000 Received: from BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862]) by BYAPR18MB2424.namprd18.prod.outlook.com ([fe80::2d42:12b6:aa2e:2862%4]) with mapi id 15.20.2073.012; Fri, 19 Jul 2019 05:02:51 +0000 From: Jerin Jacob Kollanukkaran To: "Eads, Gage" , Phil Yang , "dev@dpdk.org" CC: "thomas@monjalon.net" , "hemant.agrawal@nxp.com" , "Honnappa.Nagarahalli@arm.com" , "gavin.hu@arm.com" , "nd@arm.com" Thread-Topic: [EXT] [PATCH v3 3/3] eal/stack: enable lock-free stack for aarch64 Thread-Index: AQHVLYk9rZbDQ4qg70+TRqBpyBPMi6bRddNggAAHwICAAALGkA== Date: Fri, 19 Jul 2019 05:02:51 +0000 Message-ID: References: <1561257671-10316-1-git-send-email-phil.yang@arm.com> <1561709503-11665-1-git-send-email-phil.yang@arm.com> <1561709503-11665-3-git-send-email-phil.yang@arm.com> <9184057F7FC11744A2107296B6B8EB1E68D23943@FMSMSX108.amr.corp.intel.com> In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E68D23943@FMSMSX108.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f567b2a9-7fcf-496e-a767-08d70c065a26 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:BYAPR18MB2630; x-ms-traffictypediagnostic: BYAPR18MB2630: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 01039C93E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(376002)(366004)(136003)(39860400002)(189003)(199004)(4326008)(561944003)(478600001)(53936002)(71190400001)(71200400001)(66066001)(33656002)(68736007)(6436002)(229853002)(6246003)(81166006)(76116006)(52536014)(7736002)(74316002)(305945005)(2906002)(86362001)(256004)(8676002)(316002)(186003)(3846002)(99286004)(14454004)(55016002)(2501003)(476003)(9686003)(25786009)(54906003)(110136005)(55236004)(486006)(5660300002)(76176011)(66446008)(102836004)(64756008)(66476007)(8936002)(66946007)(7696005)(81156014)(66556008)(11346002)(6506007)(6116002)(446003)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR18MB2630; H:BYAPR18MB2424.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: qss1sfQAEQ0EaPwHYIwOFUm83AeMopi6KD8zXhWsEDaQ3uWhtmFT/3nO/3btg1XVaGoskfDfJn/BKrVSuVu1j0ZEOb8aXqYcpelcsTbbDoC6ES5KfJ5kURg6YudZeOJQUZQnqQY2Jk0Lvy24npo9xLDl4WPmlwMfUQZx65Mv2tQL2sG+i1HjjTM7/BIe6G2LwwTqABaSeUY48CT6PGVOPvkn0BorB0b7VbhQn+XMEPurhUM6yRU4mYu4fLOAPPeGBOad4pm6aa6rkOzrnOlmA2psPPJ05BA1d52bsiePCYAPfehI+DzwrX1g7d0lpNERuulBloOWICUQJKvo89thBMcAkS1qu607mYQ3BjGkvMLXuYLCE9YoCkK/+kLSU2zkKyyS3x7BDx1HKAw9G6n8wCIvZNGj/Ct9XSTCmgDJrXU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f567b2a9-7fcf-496e-a767-08d70c065a26 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2019 05:02:51.6205 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jerinj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2630 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-19_03:2019-07-19,2019-07-19 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 3/3] eal/stack: enable lock-free stack for aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Can we remove this all #ifdef clutter by adding the following > > > > $ git diff > > diff --git a/lib/librte_stack/rte_stack_lf.h > > b/lib/librte_stack/rte_stack_lf.h index f5581f0c2..46af08b83 100644 > > --- a/lib/librte_stack/rte_stack_lf.h > > +++ b/lib/librte_stack/rte_stack_lf.h > > @@ -5,7 +5,7 @@ > > #ifndef _RTE_STACK_LF_H_ > > #define _RTE_STACK_LF_H_ > > > > -#ifdef RTE_USE_C11_MEM_MODEL > > +#if defined (RTE_USE_C11_MEM_MODEL) && > defined(RTE_ARCH_X86_64) > > && > > +defined(RTE_ARCH_ARM64) >=20 > I assume you meant (defined(RTE_ARCH_X86_64) || > defined(RTE_ARCH_ARM64))? Yup. >=20 > > #include "rte_stack_lf_c11.h" > > #else > > #include "rte_stack_lf_generic.h" > > > > >=20 > The ifdefs in those two headers prevent DPDK from trying to build > rte_atomic128_cmp_exchange() on architectures that don't implement it. So > the proposal wouldn't quite work, since rte_stack_lf_generic.h calls > rte_atomic128_cmp_exchange(). >=20 > Something like this could work: >=20 > #if !(defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_ARM64)) #include > rte_stack_lf_stubs.h #else #ifdef RTE_USE_C11_MEM_MODEL #include > "rte_stack_lf_c11.h" > #else > #include "rte_stack_lf_generic.h" > #endif > #endif >=20 > Where rte_stack_lf_stubs.h is a new header containing stub > implementations of __rte_stack_lf_count, __rte_stack_lf_push_elems, and > __rte_stack_lf_pop_elems. It still has some ifdef clutter, but less overa= ll. Agree. I prefer to take this route to reduce the ifdef clutter across gener= ic and c11 files.