From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quinn Tran Date: Wed, 20 Nov 2019 23:53:43 +0000 Subject: RE: [EXT] [PATCH v2 09/15] scsi: qla2xxx: Send Notify ACK after N2N PLOGI Message-Id: List-Id: References: <20191120222723.27779-1-r.bolshakov@yadro.com> <20191120222723.27779-10-r.bolshakov@yadro.com> In-Reply-To: <20191120222723.27779-10-r.bolshakov@yadro.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Roman Bolshakov , "linux-scsi@vger.kernel.org" , "target-devel@vger.kernel.org" Cc: "linux@yadro.com" , Himanshu Madhani , Krishna Kant , Alexei Potashnik Acked-by: Quinn Tran -----Original Message----- From: Roman Bolshakov Sent: Wednesday, November 20, 2019 2:27 PM To: linux-scsi@vger.kernel.org; target-devel@vger.kernel.org Cc: linux@yadro.com; Roman Bolshakov ; Quinn Tran ; Himanshu Madhani ; Krishna Kant ; Alexei Potashnik Subject: [EXT] [PATCH v2 09/15] scsi: qla2xxx: Send Notify ACK after N2N PLOGI External Email ---------------------------------------------------------------------- qlt_handle_login schedules session for deletion even if a login is in progress. That causes login bouncing, i.e. a few logins are made before it settles down. Complete the first login by sending Notify Acknowledge IOCB via qlt_plogi_ack_unref if the session is pending login completion. Fixes: 9cd883f07a54 ("scsi: qla2xxx: Fix session cleanup for N2N") Cc: Quinn Tran Cc: Himanshu Madhani Cc: Krishna Kant Cc: Alexei Potashnik Signed-off-by: Roman Bolshakov --- drivers/scsi/qla2xxx/qla_target.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index ab62fcba8ab3..853fa187d827 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -4802,6 +4802,7 @@ static int qlt_handle_login(struct scsi_qla_host *vha, switch (sess->disc_state) { case DSC_DELETED: + case DSC_LOGIN_PEND: qlt_plogi_ack_unref(vha, pla); break; -- 2.24.0