From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 089DAC433EF for ; Mon, 4 Apr 2022 19:51:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58AD36B0071; Mon, 4 Apr 2022 15:51:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 539DE6B0073; Mon, 4 Apr 2022 15:51:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B2976B0074; Mon, 4 Apr 2022 15:51:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 259EF6B0071 for ; Mon, 4 Apr 2022 15:51:49 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 714C3AC037 for ; Mon, 4 Apr 2022 19:51:38 +0000 (UTC) X-FDA: 79320241476.18.C453ED6 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2061.outbound.protection.outlook.com [40.107.94.61]) by imf19.hostedemail.com (Postfix) with ESMTP id 92B991A0028 for ; Mon, 4 Apr 2022 19:51:35 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vazz7z4PhLeK3sa+PRpT/esNMlzRfIU9K0HxS+0TCvdFWpFE1brHsoI6D/zi2T65DTtSCspwy6d22THt1Gm6dqgvwayWPRqPtzgk+xZMv1Y8f+Wn8h2YmkYf01bSZhx5ygfi9SlIe+osw73Q+Tih7IsqbyeAJu9QF0qIRPg7Tmxri7sVTAJzN022Q111nK5FASBbvHBll+hz4a5WV5WxXoGUcm/l1vBPBVH4wsjHapNJ6VYah8nGMzsnNORmeprCGcx1o2XjGeT6tKdKdi3njTj/G7rK4cXBt3DlQCx5j3xwAsyEx8ZcmiQY4Nyv4ViTg14LFnmXulTUweMKIDGhJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TvQx/Mm/zTAzS/LH+nOyqURZck7GAlyAD1N6itKhilY=; b=ZODcwoiBRG15PfAV1N2K7ssggzFhdyr8kWxS/rGygd9YSylEodwfpEz929U406nVRL1JbDgIFrqlSKh/EnFCGe7YkPO8pYlN289td5gffmF2JBK3N5m1VeoLail4PuGrTB6dzMtH8shSv43UsMuRufmfAqKzhPoDntZ/VVEd7kzAziZaujT8RNcJE+HN0WPwriTVAjsMMjHw6XAVKrtnGSBvm4pYgK9dluZuvFXZUn6qfBPMXcQfdPCAToWttAz4pJNM1XOE/QYrcjU5akC1G1WFvLJxdGcQeSHXKyNpnwEkagRpaccwwHIlHXDLX7lktUeacMuXTUm+FD1yjjftmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TvQx/Mm/zTAzS/LH+nOyqURZck7GAlyAD1N6itKhilY=; b=WYS70z32o1u21hOrN+emSuXNojrsIKyS1A4n/Ev3lma7DaxI7tsURYPIOlBegTCH+iFJcSh+9cVfViMYRjNSyY/LI3xbOIjkTie+hbikYRX1xfHSpl5GW31tr7yjXouMGg52QbL7gdbQnsTSkhTN2ejJB9Nw0s0U33RvncwsCeg+RZAiPk5vjmkUj/RVjsnNz8M/ki0SAyZl7u22IVlBiursVQMe2HAwAk5qrNB+gPshHfGb7Em1DDPQXD+PIyOQ+6TJ7IPbvgbD36lViiZtC5/ssOkyx3HgZkkWYD9RWeodHZ0gcwoamFUyVN5pwN1vbrywZ/F4fis3SQ6lDWr40Q== Received: from MN2PR12MB3823.namprd12.prod.outlook.com (2603:10b6:208:168::26) by MW3PR12MB4412.namprd12.prod.outlook.com (2603:10b6:303:58::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr 2022 19:51:32 +0000 Received: from MN2PR12MB3823.namprd12.prod.outlook.com ([fe80::69f1:dff6:826b:7d9c]) by MN2PR12MB3823.namprd12.prod.outlook.com ([fe80::69f1:dff6:826b:7d9c%5]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022 19:51:32 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH 4/4] mm/mempolicy: Use vma_alloc_folio() in new_page() Date: Mon, 04 Apr 2022 15:51:30 -0400 X-Mailer: MailMate (1.14r5870) Message-ID: In-Reply-To: <20220404193006.1429250-5-willy@infradead.org> References: <20220404193006.1429250-1-willy@infradead.org> <20220404193006.1429250-5-willy@infradead.org> Content-Type: multipart/signed; boundary="=_MailMate_E61B1FB9-E737-4898-A348-440602C14453_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: BL0PR01CA0035.prod.exchangelabs.com (2603:10b6:208:71::48) To MN2PR12MB3823.namprd12.prod.outlook.com (2603:10b6:208:168::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c79b5e17-4f4f-43c1-90fe-08da16748493 X-MS-TrafficTypeDiagnostic: MW3PR12MB4412:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7YEQ1zhK6UX8Be8kFncaAM3P3mnyErAKBpA7mIwssigEeyLLE7Cf7Ut/Uf15NSDGowPu+UHJaaoFtjHtSs3suFOIfl8nQS6tD9k9nEw/0nBewy26ITijqDdRfLpoGlsAJM8Pwck9eWcDqrHOdloOWLb5k5xHpVvEP0eypQuqLRsRFKAcQYyG2OlGBd+NNnUMMS00glO6Z6jAQjFGbgVLEmb7m8q0ieX5BzPMbGc2IdrTWBRN/0YI+3UU8d8l4MJhcNOwKTaoFExsGZGu/V8TJ6+DcrjmblZyUAtYh47DVUktmOF9fJm/etzpzUMpfRlmuQWbhyZYKPAKbUvp+v9ALuitUgbwLPWMqVs3qOjsHZG9WaVU/O9IfWps4tk9c2VZk38dlAv6DW0KsfKisJOHqpX146nSPJuE9sSEGPE9wWqPfMU1R+o+5oAr7HXiAKUgg+yUV8qdqLuf1ZaupuwxwzJ0GajlMUzl1pYvYc5Q39YD9ymgbSOQEo5ugsoBiLs9RaqTA6OueUgibElpmhs6QYuxnvGQbCrqpZoMs7rwox+WtIuwBoSE0c9TE7hq9dRswwMCu76YTbh7PVTO9e7qnvLb54MmDvTq7w0UUkvJMeDJIHO39804vMHoIDt0kJPwyeJK5MLQnZafvB4ZTb6ZisO6eeT3haBrGaGikaI6isIDut5g1dXhGjAzbkZh9tgr78RU04s3mzyLNiPq5Etc4suf29CemU2iP4hLwj1Ktl0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3823.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(186003)(26005)(235185007)(5660300002)(66946007)(83380400001)(21480400003)(66476007)(38100700002)(2616005)(8936002)(66556008)(6916009)(4326008)(8676002)(86362001)(508600001)(6512007)(6506007)(316002)(53546011)(2906002)(33656002)(6486002)(36756003)(45980500001)(72826004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2uwEJ9E5aD0DKcUVTi9xhWGpPC5weI2RSP8U6vFMYwPJbIpmSTcdAq8Mjk6S?= =?us-ascii?Q?pWvadeLE0LAYwZ63ZLkAv2uFU96E15wS1m4sEoAXUds0fZs/hOXt17CM0OSF?= =?us-ascii?Q?Am3+t35e54z0LXTEc9LZQ8QEld3z75S5HnCrg/oKsvcKqknMTIscxqE7D/US?= =?us-ascii?Q?sUs+Uhyns3+XYAAOfmu/ePnlX3qMinDSxPCmIYSK5iHlH8vg9GKqHRy/ahe3?= =?us-ascii?Q?1vV5xq+n5LfsJHO80f7cRE4rWlR9N3Hc4BXr2Oigo3dTL1LKJkgIFZZ4aA++?= =?us-ascii?Q?1IKCTiFQXmhNsChZTFZ+ghmCCyArvR90trTbV6nLY9AqL1N7mrUfivmcD8ST?= =?us-ascii?Q?BQvzToIaq+41sIpCVBBJD5Hy1dbrokQwM6Pz6lWxK8PmUSPFF8SC6n8ETSZH?= =?us-ascii?Q?1cVCiyL3pCpAM5F1wZtfWRMk9+yAeJ/yopJdBwUiZIWJ0wl4kIXiQbu9L9pa?= =?us-ascii?Q?E/AusvsThgkN9+vUdfonpPXS1kHK/TFwPUNZ6jxV/xnPueNIlGSUBlvCCBc4?= =?us-ascii?Q?u5SXvnVosJwR5U3J3e7DmQhnU7MOPoeSTIlcpOLsj6X0zu0wPy24r1BrWC6p?= =?us-ascii?Q?LtHNQIWAJ4SsAm0pxo0hnKKAKUnclkzWQn6z79fUhtPlX6tM6i1y3L1SzzFz?= =?us-ascii?Q?lvH5Tlo+jSt1UTNiIih1o7/AKdXVff9ra3LW6kIHfxW8FMvGfu4rf5NDKk/i?= =?us-ascii?Q?Foh2qqFcO/pD9MBua47Uyh9uZLE21X8i213k8eagqDTi9Glr2uJT7/BJKGdG?= =?us-ascii?Q?CJP8i+BFisKWb8eUJ44Vj5bp8mvXr9ghKNLNAID7OVirWAEuuhrtvTDX3gMv?= =?us-ascii?Q?q820nWsMb5+D4vNs9kDxrU5YVMbpVbb58SrkiaSHdjE5YhZssXNHRK+2/YJC?= =?us-ascii?Q?CPYfMLAFLyd5WAnCG3JkqV/7l3t4p0W8wABqSuvIppoSfd/w0ClXwOf0C4QQ?= =?us-ascii?Q?LO2PXyURDXiaSJbunj/zzDmhmZ5Oz/vzTnk9eaZMyn8ewbq7+1mEGOjfNWNw?= =?us-ascii?Q?58v+VsuWuU/455S6RJu4otGHzYY1TXPu4XoZ3lsQnIfKPufrefIfDlWlEP1B?= =?us-ascii?Q?V6ti4d4H21kAqwoxU443E4Q/vPUG6ZqwnHkiQJJzbEiorI020doUqz7xU28i?= =?us-ascii?Q?Vby/JNXjDiLwdeoQmu5AHUxlcYgQ93zwM1LcpdoA8pfdhCmrRcertce3JBKY?= =?us-ascii?Q?w/5WsF7GVHP01iyF7WdM0wcFfwRHbljfK6GLoGerC71bkbLLtWRxWHL2cMOi?= =?us-ascii?Q?ghOaSOjS6+Ki0LUWMCiQaW8/30ywNQ7m5jzOGw3GE23kChaWHRMDWAv6w40W?= =?us-ascii?Q?EXssIxURW1XCbg//77skwsM1Bb50SsAoLQCYwhw2cWMx4nN2iC46pYUPXUeH?= =?us-ascii?Q?VxD2H3mbuN80rRPNC+8RHfh7AN2fLkdr7oTFCdRGb6MGndB3d4prRMkelPGr?= =?us-ascii?Q?z5nQeqXlwv0JuwknsmCF0pJnMKeX2ECq9ROBFiG1Qr19Ct7j1dO3pcFzm2AE?= =?us-ascii?Q?2Cnjj3edyDPyP31dNchBzo6bUR98Ho8gp10mwzvbRWe879NL+/09GCWO4jd7?= =?us-ascii?Q?Ay5fmS7Loxle8kGPRwx5FX0MUEbeZgyljskjphtfhPlboPJpKW+U9P2ScjtG?= =?us-ascii?Q?pzZQO0IBB12fJcgb4peeevtBfY7sCHFTb1+8Dd1xBlQmm8Oyjfdh+cD3m/HN?= =?us-ascii?Q?SJu8SLXF9DGRQuTx0sHZaDrkeF707L3hnrwYlX1bSeTZzbWN9qDGKHMqLf5B?= =?us-ascii?Q?H5PV14jIBw=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c79b5e17-4f4f-43c1-90fe-08da16748493 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3823.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 19:51:32.4189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0prhz6c811doL11/hkqq73Lyi7lJhRcWWqXs540RFfWKb7pmGZNd1Bf8j+Jyvj3N X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4412 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=WYS70z32; spf=none (imf19.hostedemail.com: domain of ziy@nvidia.com has no SPF policy when checking 40.107.94.61) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com X-Stat-Signature: w3gmeq8eyfbneens9babozdb9twc4j1m X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 92B991A0028 X-HE-Tag: 1649101895-525948 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=_MailMate_E61B1FB9-E737-4898-A348-440602C14453_= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 4 Apr 2022, at 15:30, Matthew Wilcox (Oracle) wrote: > Simplify new_page() by unifying the THP and base page cases, and > handle orders other than 0 and HPAGE_PMD_ORDER correctly. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/mempolicy.c | 25 +++++++++++-------------- > 1 file changed, 11 insertions(+), 14 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index ec15f4f4b714..d6d7a95b0cce 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -1191,8 +1191,10 @@ int do_migrate_pages(struct mm_struct *mm, const= nodemask_t *from, > */ > static struct page *new_page(struct page *page, unsigned long start) > { > + struct folio *dst, *src =3D page_folio(page); > struct vm_area_struct *vma; > unsigned long address; > + gfp_t gfp =3D GFP_HIGHUSER_MOVABLE | __GFP_RETRY_MAYFAIL; > > vma =3D find_vma(current->mm, start); > while (vma) { > @@ -1202,24 +1204,19 @@ static struct page *new_page(struct page *page,= unsigned long start) > vma =3D vma->vm_next; > } > > - if (PageHuge(page)) { > - return alloc_huge_page_vma(page_hstate(compound_head(page)), > + if (folio_test_hugetlb(src)) { > + return alloc_huge_page_vma(page_hstate(&src->page), > vma, address); > - } else if (PageTransHuge(page)) { > - struct page *thp; > - > - thp =3D alloc_hugepage_vma(GFP_TRANSHUGE, vma, address, > - HPAGE_PMD_ORDER); > - if (!thp) > - return NULL; > - prep_transhuge_page(thp); > - return thp; > + } else if (folio_test_large(src)) { > + gfp =3D GFP_TRANSHUGE; > } Nit. The two bracket pairs from the two ifs can be removed. > + > /* > - * if !vma, alloc_page_vma() will use task or system default policy > + * if !vma, vma_alloc_folio() will use task or system default policy > */ > - return alloc_page_vma(GFP_HIGHUSER_MOVABLE | __GFP_RETRY_MAYFAIL, > - vma, address); > + dst =3D vma_alloc_folio(gfp, folio_order(src), vma, address, > + folio_test_large(src)); > + return &dst->page; > } > #else > > -- = > 2.34.1 -- Best Regards, Yan, Zi --=_MailMate_E61B1FB9-E737-4898-A348-440602C14453_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmJLTEIPHHppeUBudmlk aWEuY29tAAoJEOJ/noEUByhUv48P/jEfgTMIbz0XVoYihQ83DynOmJRo5y7ecprg MY/itLHDKMLZNcDYX4YCdZxSRxIIKMAkjdETK3j0h9o24Ia0KSkTfKdEjeNQ1Xyz q8f6hTWL4bvK4ubw8ZdFqX5Fdr1hFxR0ckBDV1DMldG6ZfyxP9FD7oWj66q0OEcG +VJom0ICEr/0mTwSDPf6ovxQo6g/oH0u+ebVLEm5ipifRJmNT1nrRuHRcb58kSAl oNeTo2E/J5pyD70mKXZW9JJcTHAzo6W8xmPC5d1I77Z0jw05DZRlCzgx2yT1mRqc 2pMIE++JsheEjUVy+XbPK2im5AC3YAtlbCuAfW+zTsBeRD9+IF+Q3atZtOJc9Xdp X0lh4cM8faIDneuHrwlz7TuBz/iyXdTl4TBjoRX9Acrr/ChcdV5VUb+RZQrI5Zye mNyrfsa55MAgC/h21GSKBGRqbZpq8fJpTUbAgVQWJcBuqsjaPRvf+vRSpmpthtPr AE89EBV7ey8fYDoPeB5b9jFLxQUEX9HQXiNpU79Csm1vL88SR7S5LVl+ALByjrfs Om21Cu52N96ES1ei7cCKd3EMIgm4OrS6xjLQIpEhSaz3Xq2/cxiDaFHY7ZY1TwZ2 Tiaqb2SHOynVYdTvqyBYw2Xn2UPi4HP2i1T9EHhxB5SzT00M/owQWZRSTKfe6JVD 0RSClvVC =D3Yv -----END PGP SIGNATURE----- --=_MailMate_E61B1FB9-E737-4898-A348-440602C14453_=--