Re: [PATCH v2] Grab the EFI System Resource Table and check it

[Luca Fancellu <Luca.Fancellu@arm.com>]

> On 31 Mar 2022, at 12:57, Demi Marie Obenour <demi@invisiblethingslab.com> wrote:
> 
> On Thu, Mar 31, 2022 at 07:04:34AM +0000, Luca Fancellu wrote:
>> Hi,
>> 
>>> 
>>> diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
>>> index 458cfbbed4..398a2411a1 100644
>>> --- a/xen/arch/arm/efi/efi-boot.h
>>> +++ b/xen/arch/arm/efi/efi-boot.h
>>> @@ -187,7 +187,8 @@ static bool __init meminfo_add_bank(struct meminfo *mem,
>>> 
>>> static EFI_STATUS __init efi_process_memory_map_bootinfo(EFI_MEMORY_DESCRIPTOR *map,
>>>                                                UINTN mmap_size,
>>> -                                                UINTN desc_size)
>>> +                                                UINTN desc_size,
>>> +                                                const EFI_MEMORY_DESCRIPTOR *const esrt_desc)
>>> {
>>>    int Index;
>>>    EFI_MEMORY_DESCRIPTOR *desc_ptr = map;
>>> @@ -199,6 +200,7 @@ static EFI_STATUS __init efi_process_memory_map_bootinfo(EFI_MEMORY_DESCRIPTOR *
>>>              desc_ptr->Type == EfiLoaderCode ||
>>>              desc_ptr->Type == EfiLoaderData ||
>>>              (!map_bs &&
>>> +               desc != esrt_desc &&
>> 
>> I was going to test it but this line is breaking arm build.
> 
> Not too surprising; I don’t think I actually built this for ARM.  Can
> you post the error you get?  I’ll send a v3 once that is fixed.

I think I cleaned my logs, but it was an easy one like “desc is not defined”,
probably you were looking for “desc_ptr”?