From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19DE9C33CB3 for ; Tue, 28 Jan 2020 10:01:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9B482467E for ; Tue, 28 Jan 2020 10:01:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725903AbgA1KBN (ORCPT ); Tue, 28 Jan 2020 05:01:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:52978 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbgA1KBN (ORCPT ); Tue, 28 Jan 2020 05:01:13 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0DB87B122; Tue, 28 Jan 2020 10:01:11 +0000 (UTC) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1580148908-4863-3-git-send-email-stefan.wahren@i2se.com> Date: Tue, 28 Jan 2020 10:44:23 +0100 From: "Nicolas Saenz Julienne" To: "Stefan Wahren" , "Florian Fainelli" , "Linus Walleij" , "Ray Jui" , "Scott Branden" Cc: , , , , "Stefan Wahren" Subject: Re: [RFC PATCH 2/4] pinctrl: bcm2835: Refactor platform data Message-Id: Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Stefan, thanks for the series! On Mon Jan 27, 2020 at 7:15 PM, Stefan Wahren wrote: > This prepares the platform data to be easier to extend for more GPIOs. > Except of this there is no functional change. > > Signed-off-by: Stefan Wahren > --- [...] > @@ -1083,6 +1112,7 @@ static int bcm2835_pinctrl_probe(struct > platform_device *pdev) > struct device *dev =3D &pdev->dev; > struct device_node *np =3D dev->of_node; > struct bcm2835_pinctrl *pc; > + struct bcm_plat_data *pdata; You could define pdata as const here... > struct gpio_irq_chip *girq; > struct resource iomem; > int err, i; > @@ -1108,7 +1138,13 @@ static int bcm2835_pinctrl_probe(struct > platform_device *pdev) > if (IS_ERR(pc->base)) > return PTR_ERR(pc->base); > =20 > - pc->gpio_chip =3D bcm2835_gpio_chip; > + match =3D of_match_node(bcm2835_pinctrl_match, pdev->dev.of_node); > + if (!match) > + return -EINVAL; > + > + pdata =3D (struct bcm_plat_data *)match->data; ...And avoid this cast. > + > + memcpy(&pc->gpio_chip, pdata->gpio_chip, sizeof(pc->gpio_chip)); Here (and below) you could do: pc->gpio_chip =3D *pdata->gpio_chip; IMO it's nicer, but it's a matter of taste. > pc->gpio_chip.parent =3D dev; > pc->gpio_chip.of_node =3D np; > =20 > @@ -1159,19 +1195,14 @@ static int bcm2835_pinctrl_probe(struct > platform_device *pdev) > return err; > } > =20 > - match =3D of_match_node(bcm2835_pinctrl_match, pdev->dev.of_node); > - if (match) { > - bcm2835_pinctrl_desc.confops =3D > - (const struct pinconf_ops *)match->data; > - } > - > - pc->pctl_dev =3D devm_pinctrl_register(dev, &bcm2835_pinctrl_desc, pc); > + memcpy(&pc->pctl_desc, pdata->pctl_desc, sizeof(pc->pctl_desc)); > + pc->pctl_dev =3D devm_pinctrl_register(dev, &pc->pctl_desc, pc); > if (IS_ERR(pc->pctl_dev)) { > gpiochip_remove(&pc->gpio_chip); > return PTR_ERR(pc->pctl_dev); > } > =20 > - pc->gpio_range =3D bcm2835_pinctrl_gpio_range; > + memcpy(&pc->gpio_range, pdata->gpio_range, sizeof(pc->gpio_range)); > pc->gpio_range.base =3D pc->gpio_chip.base; > pc->gpio_range.gc =3D &pc->gpio_chip; > pinctrl_add_gpio_range(pc->pctl_dev, &pc->gpio_range); > -- > 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 910ACC33CB3 for ; Tue, 28 Jan 2020 10:01:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EA9F24686 for ; Tue, 28 Jan 2020 10:01:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WMdu2Sjv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EA9F24686 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Subject: To:From:Date:In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=QeL4847RjRW7KDOalQkt75jTp14cjDr2n8iZrW0Iizk=; b=WMdu2Sjvjg20DB 6yIF7NaXed53TU/mZ2ZrSHJz8/+MkJRztFPQL2smUyB1uf2vLPQQzngh45ByCrJlGlYYWNZJJiwaY oGaF9CsAmo9toLfy9NJf6T5/9ehK1kAvIJw2124z34TarX7eLEuy6WZ5F8MEAz1rrZ6QyOZNNM7Ih W3ebyIH0OwbCq1grDgFjtPxAJ+kVw6LX1pNIxXq/KZlUf0r8kE/nrBswq+j8ZzHVLxXFMYQGRHYrc gDQjUatk2HBW8aIseXPZIqPsCMNigAWpSFpaGVpMpn/0sdnPuij3vdGjITjYMG3DPok/Pud05JswU D6kvWKIzDiePOBNnlBuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwNgM-0006rU-73; Tue, 28 Jan 2020 10:01:18 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwNgI-0006qq-Jq for linux-arm-kernel@lists.infradead.org; Tue, 28 Jan 2020 10:01:15 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0DB87B122; Tue, 28 Jan 2020 10:01:11 +0000 (UTC) In-Reply-To: <1580148908-4863-3-git-send-email-stefan.wahren@i2se.com> Date: Tue, 28 Jan 2020 10:44:23 +0100 From: "Nicolas Saenz Julienne" To: "Stefan Wahren" , "Florian Fainelli" , "Linus Walleij" , "Ray Jui" , "Scott Branden" Subject: Re: [RFC PATCH 2/4] pinctrl: bcm2835: Refactor platform data Message-Id: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200128_020114_797677_0C3A1C9C X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , linux-gpio@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, thanks for the series! On Mon Jan 27, 2020 at 7:15 PM, Stefan Wahren wrote: > This prepares the platform data to be easier to extend for more GPIOs. > Except of this there is no functional change. > > Signed-off-by: Stefan Wahren > --- [...] > @@ -1083,6 +1112,7 @@ static int bcm2835_pinctrl_probe(struct > platform_device *pdev) > struct device *dev = &pdev->dev; > struct device_node *np = dev->of_node; > struct bcm2835_pinctrl *pc; > + struct bcm_plat_data *pdata; You could define pdata as const here... > struct gpio_irq_chip *girq; > struct resource iomem; > int err, i; > @@ -1108,7 +1138,13 @@ static int bcm2835_pinctrl_probe(struct > platform_device *pdev) > if (IS_ERR(pc->base)) > return PTR_ERR(pc->base); > > - pc->gpio_chip = bcm2835_gpio_chip; > + match = of_match_node(bcm2835_pinctrl_match, pdev->dev.of_node); > + if (!match) > + return -EINVAL; > + > + pdata = (struct bcm_plat_data *)match->data; ...And avoid this cast. > + > + memcpy(&pc->gpio_chip, pdata->gpio_chip, sizeof(pc->gpio_chip)); Here (and below) you could do: pc->gpio_chip = *pdata->gpio_chip; IMO it's nicer, but it's a matter of taste. > pc->gpio_chip.parent = dev; > pc->gpio_chip.of_node = np; > > @@ -1159,19 +1195,14 @@ static int bcm2835_pinctrl_probe(struct > platform_device *pdev) > return err; > } > > - match = of_match_node(bcm2835_pinctrl_match, pdev->dev.of_node); > - if (match) { > - bcm2835_pinctrl_desc.confops = > - (const struct pinconf_ops *)match->data; > - } > - > - pc->pctl_dev = devm_pinctrl_register(dev, &bcm2835_pinctrl_desc, pc); > + memcpy(&pc->pctl_desc, pdata->pctl_desc, sizeof(pc->pctl_desc)); > + pc->pctl_dev = devm_pinctrl_register(dev, &pc->pctl_desc, pc); > if (IS_ERR(pc->pctl_dev)) { > gpiochip_remove(&pc->gpio_chip); > return PTR_ERR(pc->pctl_dev); > } > > - pc->gpio_range = bcm2835_pinctrl_gpio_range; > + memcpy(&pc->gpio_range, pdata->gpio_range, sizeof(pc->gpio_range)); > pc->gpio_range.base = pc->gpio_chip.base; > pc->gpio_range.gc = &pc->gpio_chip; > pinctrl_add_gpio_range(pc->pctl_dev, &pc->gpio_range); > -- > 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel