From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755361AbdDLUT3 convert rfc822-to-8bit (ORCPT ); Wed, 12 Apr 2017 16:19:29 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:45371 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbdDLUTY (ORCPT ); Wed, 12 Apr 2017 16:19:24 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCHv3 00/10] Nokia H4+ support From: Marcel Holtmann In-Reply-To: <20170411140637.GA4388@kroah.com> Date: Wed, 12 Apr 2017 22:19:21 +0200 Cc: Sebastian Reichel , "Gustavo F. Padovan" , Johan Hedberg , Samuel Thibault , Pavel Machek , Tony Lindgren , Jiri Slaby , Mark Rutland , "open list:BLUETOOTH DRIVERS" , "linux-serial@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S. Miller" , Rob Herring Content-Transfer-Encoding: 8BIT Message-Id: References: <20170328155939.31566-1-sre@kernel.org> <20170331133353.GA32267@kroah.com> <20170410231041.vz35anezpzhscu4t@earth> <4FEFA1D8-BE23-40FB-BAA3-3EC910FE9F96@holtmann.org> <20170411140637.GA4388@kroah.com> To: Greg Kroah-Hartman X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sebastian, >>>>>>>> Here is PATCHv3 for the Nokia bluetooth patchset. I addressed all comments from >>>>>>>> Rob and Pavel regarding the serdev patches and dropped the *.dts patches, since >>>>>>>> they were queued by Tony. I also changed the patch order, so that the serdev >>>>>>>> patches come first. All of them have Acked-by from Rob, so I think it makes >>>>>>>> sense to merge them to serdev subsystem (now) and provide an immutable branch >>>>>>>> for the bluetooth subsystem. >>>>>>> >>>>>>> Greg doesn't read cover letters generally and since the serdev patches >>>>>>> are Cc rather than To him, he's probably not planning to pick them up. >>>>>> >>>>>> I wonder actually if we should merge all of these via bluetooth-next >>>>>> tree with proper Ack from Greg. However it would be good to also get >>>>>> buy in from Dave for merging this ultimately through net-next. >>>>> >>>>> I don't really care where it goes. I can take the whole thing in my >>>>> tty/serial tree now if no one objects and I get an ack from the relevant >>>>> maintainers {hint...} >>>> >>>> I think it is better if it goes thru BT tree. I have another driver >>>> converted that is dependent on this series. There's a couple other >>>> serdev changes on the list too, but this shouldn't depend on them. >>> >>> Is this waiting for something, or could it be queued to >>> bluetooth-next then? It would be nice to finally have >>> this in 4.12 :) >> >> I would prefer if we can get an ACK from Greg. Then I merge it through the bluetooth-next tree. > > Sorry thought this was coming through mine: > Acked-by: Greg Kroah-Hartman > > Merge away! so I have applied patches 1-8 to bluetooth-next tree. The last 2 I left out since they do cause build issues on non-DT platforms. We need to be able to build the driver on all platforms so that sanity compile checks happen all the time. CC drivers/bluetooth/hci_nokia.o drivers/bluetooth/hci_nokia.c:802:34: error: array type has incomplete element type ‘struct of_device_id’ static const struct of_device_id nokia_bluetooth_of_match[] = { ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/bluetooth/hci_nokia.c:803:4: error: field name not in record or union initializer { .compatible = "nokia,h4p-bluetooth", }, ^ drivers/bluetooth/hci_nokia.c:803:4: note: (near initialization for ‘nokia_bluetooth_of_match’) drivers/bluetooth/hci_nokia.c:815:21: error: implicit declaration of function ‘of_match_ptr’ [-Werror=implicit-function-declaration] .of_match_table = of_match_ptr(nokia_bluetooth_of_match), ^~~~~~~~~~~~ drivers/bluetooth/hci_nokia.c:802:34: warning: ‘nokia_bluetooth_of_match’ defined but not used [-Wunused-variable] static const struct of_device_id nokia_bluetooth_of_match[] = { ^~~~~~~~~~~~~~~~~~~~~~~~ Regards Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Holtmann Subject: Re: [PATCHv3 00/10] Nokia H4+ support Date: Wed, 12 Apr 2017 22:19:21 +0200 Message-ID: References: <20170328155939.31566-1-sre@kernel.org> <20170331133353.GA32267@kroah.com> <20170410231041.vz35anezpzhscu4t@earth> <4FEFA1D8-BE23-40FB-BAA3-3EC910FE9F96@holtmann.org> <20170411140637.GA4388@kroah.com> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20170411140637.GA4388-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg Kroah-Hartman Cc: Sebastian Reichel , "Gustavo F. Padovan" , Johan Hedberg , Samuel Thibault , Pavel Machek , Tony Lindgren , Jiri Slaby , Mark Rutland , "open list:BLUETOOTH DRIVERS" , "linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "David S. Miller" , Rob Herring List-Id: devicetree@vger.kernel.org Hi Sebastian, >>>>>>>> Here is PATCHv3 for the Nokia bluetooth patchset. I addressed all comments from >>>>>>>> Rob and Pavel regarding the serdev patches and dropped the *.dts patches, since >>>>>>>> they were queued by Tony. I also changed the patch order, so that the serdev >>>>>>>> patches come first. All of them have Acked-by from Rob, so I think it makes >>>>>>>> sense to merge them to serdev subsystem (now) and provide an immutable branch >>>>>>>> for the bluetooth subsystem. >>>>>>> >>>>>>> Greg doesn't read cover letters generally and since the serdev patches >>>>>>> are Cc rather than To him, he's probably not planning to pick them up. >>>>>> >>>>>> I wonder actually if we should merge all of these via bluetooth-next >>>>>> tree with proper Ack from Greg. However it would be good to also get >>>>>> buy in from Dave for merging this ultimately through net-next. >>>>> >>>>> I don't really care where it goes. I can take the whole thing in my >>>>> tty/serial tree now if no one objects and I get an ack from the relevant >>>>> maintainers {hint...} >>>> >>>> I think it is better if it goes thru BT tree. I have another driver >>>> converted that is dependent on this series. There's a couple other >>>> serdev changes on the list too, but this shouldn't depend on them. >>> >>> Is this waiting for something, or could it be queued to >>> bluetooth-next then? It would be nice to finally have >>> this in 4.12 :) >> >> I would prefer if we can get an ACK from Greg. Then I merge it through the bluetooth-next tree. > > Sorry thought this was coming through mine: > Acked-by: Greg Kroah-Hartman > > Merge away! so I have applied patches 1-8 to bluetooth-next tree. The last 2 I left out since they do cause build issues on non-DT platforms. We need to be able to build the driver on all platforms so that sanity compile checks happen all the time. CC drivers/bluetooth/hci_nokia.o drivers/bluetooth/hci_nokia.c:802:34: error: array type has incomplete element type ‘struct of_device_id’ static const struct of_device_id nokia_bluetooth_of_match[] = { ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/bluetooth/hci_nokia.c:803:4: error: field name not in record or union initializer { .compatible = "nokia,h4p-bluetooth", }, ^ drivers/bluetooth/hci_nokia.c:803:4: note: (near initialization for ‘nokia_bluetooth_of_match’) drivers/bluetooth/hci_nokia.c:815:21: error: implicit declaration of function ‘of_match_ptr’ [-Werror=implicit-function-declaration] .of_match_table = of_match_ptr(nokia_bluetooth_of_match), ^~~~~~~~~~~~ drivers/bluetooth/hci_nokia.c:802:34: warning: ‘nokia_bluetooth_of_match’ defined but not used [-Wunused-variable] static const struct of_device_id nokia_bluetooth_of_match[] = { ^~~~~~~~~~~~~~~~~~~~~~~~ Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html