All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <andreas.faerber@web.de>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>
Cc: 'Jan Kiszka' <jan.kiszka@siemens.com>,
	'qemu-devel' <qemu-devel@nongnu.org>,
	quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Fix serial interface vmstate
Date: Thu, 23 Jun 2011 12:11:43 +0200	[thread overview]
Message-ID: <C1A37300-49CF-4894-B5EF-4D99AF5437C6@web.de> (raw)
In-Reply-To: <4e01af43.ce4ee50a.60ee.3b47SMTPIN_ADDED@mx.google.com>

Am 22.06.2011 um 10:58 schrieb Pavel Dovgaluk:

>>>>>  This patch fixes save/restore of serial interface's state.
>>>>>  It includes changing of fcr setter function (it now does not  
>>>>> invoke
>>>>> an interrupt while loading vmstate), and saving/restoring all
>>>>> fields that describe the state of serial interface (including  
>>>>> timers).
>>>>>
>>>>> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>

>  If the port is disabled, the state will not be saved, isn't it?

See the ISA reconfigurability / PReP series for a counter-example [1].  
Whether the state is saved depends on whether the isa-serial qdev  
device is instantiated, not on whether the port is active. Therefore a  
subsection will be even more useful here.

Andreas

[1] http://patchwork.ozlabs.org/patch/100274/

      parent reply	other threads:[~2011-06-23 10:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21 12:23 [Qemu-devel] [PATCH] Fix serial interface vmstate Pavel Dovgaluk
2011-06-21 13:31 ` Juan Quintela
2011-06-22  6:19   ` Pavel Dovgaluk
     [not found]   ` <49270.9042774097$1308723700@news.gmane.org>
2011-06-22  8:12     ` Jan Kiszka
2011-06-22  8:58       ` Pavel Dovgaluk
2011-06-22  9:10         ` Jan Kiszka
2011-06-22  9:15           ` Pavel Dovgaluk
2011-06-22  9:22             ` Jan Kiszka
2011-06-22 10:13               ` Pavel Dovgaluk
2011-06-22 16:14                 ` Jan Kiszka
     [not found]       ` <4e01af43.ce4ee50a.60ee.3b47SMTPIN_ADDED@mx.google.com>
2011-06-23 10:11         ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C1A37300-49CF-4894-B5EF-4D99AF5437C6@web.de \
    --to=andreas.faerber@web.de \
    --cc=Pavel.Dovgaluk@ispras.ru \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.