From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [Xen-devel] Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas Date: Fri, 16 Feb 2007 17:12:31 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Keir Fraser , Jeremy Fitzhardinge , Andi Kleen Cc: Zachary Amsden , xen-devel@lists.xensource.com, virtualization@lists.osdl.org, linux-kernel@vger.kernel.org, Jan Beulich , Chris Wright , Ian Pratt , Andrew Morton , Christian Limpach List-Id: virtualization@lists.linuxfoundation.org On 16/2/07 17:10, "Keir Fraser" wrote: > On 16/2/07 16:46, "Jeremy Fitzhardinge" wrote: > >> Yes, that would work. Unfortunately that's i386 arch-specific, whereas >> the rest of this code is generic. I guess I could just move it all to >> arch/i386/mm. > > This whole thing isn't an issue on ia64 (they no-op lock_vm_area) and > powerpc doesn't use any of the Xen driver code at this time. > vmalloc_sync_all is supported by both i386 and x86_64, so we can make the > call conditional on CONFIG_X86 so that ia64 will continue to build. This is > what I've done in xen-unstable. In fact that file is only built for i386 and x86_64, so there really is no problem with using vmalloc_sync_all() directly and without ifdef. -- Keir