All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir@xensource.com>
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH 8/8] 2.6.17: scan DMI early
Date: Mon, 05 Mar 2007 15:51:54 +0000	[thread overview]
Message-ID: <C211ED1A.A9BB%keir@xensource.com> (raw)
In-Reply-To: <45D34049.76E4.0078.0@novell.com>

On 14/2/07 16:00, "Jan Beulich" <jbeulich@novell.com> wrote:

> While shuffling quite a few things around, this gets us closer to native,
> which clearly had a reason to do the DMI scan early.
> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>

Taken, but a few comments:

 - could we get rid of alloc_static_page() and use spp_getpage() everywhere?

 - the double-staged find_early_table_space(), where table_end gets updated
halfway through init_memory_mapping(), is pretty skanky. I suppose we get to
keep the BUG_ON(start_pfn != table_end) this way, but perhaps it would be
nicer just to set table_end once and for all in find_early_table_space().

 - the estimate of number of fixmap pagetables required in
find_early_table_space() is conservative. Is there any risk that
spp_getpage() may end up with start_pfn<table_end for long enough that we
run into concurrency issues? Perhaps we could do a dummy set_fixmap for
every fixmap slot to force population of all fixmap slots in
init_memory_mapping(), and then BUG_ON(start_pfn != table_end)?

 -- Keir

  reply	other threads:[~2007-03-05 15:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 16:00 [PATCH 8/8] 2.6.17: scan DMI early Jan Beulich
2007-03-05 15:51 ` Keir Fraser [this message]
2007-03-05 18:11   ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C211ED1A.A9BB%keir@xensource.com \
    --to=keir@xensource.com \
    --cc=jbeulich@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.