From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S937162AbdJQRvK convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Oct 2017 13:51:10 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:51806 "EHLO
        aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752306AbdJQRvI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Oct 2017 13:51:08 -0400
Date: Tue, 17 Oct 2017 13:50:44 -0400
User-Agent: K-9 Mail for Android
In-Reply-To: <1508156051-5024-1-git-send-email-luwei.kang@intel.com>
References: <1508156051-5024-1-git-send-email-luwei.kang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [PATCH 9/9] KVM: x86: Disable intercept for Intel processor trace MSRs
To: Luwei Kang <luwei.kang@intel.com>, kvm@vger.kernel.org
CC: pbonzini@redhat.com, rkrcmar@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, Chao Peng <chao.p.peng@linux.intel.com>
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Message-ID: <C21EB80B-726A-44B3-BB8D-C7CB274060B7@oracle.com>
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On October 16, 2017 8:14:11 AM EDT, Luwei Kang <luwei.kang@intel.com> wrote:
>From: Chao Peng <chao.p.peng@linux.intel.com>
>
>Trap for Intel processor trace is none sense. Pass through to
>guest directly.


And none of those MSRs can be subverted by the guest? That is none of these should be filtered / audited first?


>
>Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
>Signed-off-by: Luwei Kang <luwei.kang@intel.com>
>---
> arch/x86/kvm/vmx.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>index 3c9ce3e..58606ce 100644
>--- a/arch/x86/kvm/vmx.c
>+++ b/arch/x86/kvm/vmx.c
>@@ -7076,6 +7076,20 @@ static __init int hardware_setup(void)
> 	if (pt_mode == PT_MODE_GUEST)
> 		pt_register_virt_ops(&pt_virt_ops);
> 
>+	if (pt_mode == PT_MODE_GUEST || pt_mode == PT_MODE_HOST_GUEST) {
>+		u32 i, eax, ebx, ecx, edx;
>+
>+		cpuid_count(0x14, 1, &eax, &ebx, &ecx, &edx);
>+		vmx_disable_intercept_for_msr(MSR_IA32_RTIT_CTL, false);
>+		vmx_disable_intercept_for_msr(MSR_IA32_RTIT_STATUS, false);
>+		vmx_disable_intercept_for_msr(MSR_IA32_RTIT_OUTPUT_BASE, false);
>+		vmx_disable_intercept_for_msr(MSR_IA32_RTIT_OUTPUT_MASK, false);
>+		vmx_disable_intercept_for_msr(MSR_IA32_RTIT_CR3_MATCH, false);
>+		for (i = 0; i < (eax & 0x7); i++)
>+			vmx_disable_intercept_for_msr(MSR_IA32_RTIT_ADDR0_A + i,
>+									false);
>+	}
>+
> 	return alloc_kvm_area();
> 
> out:


Thanks!