From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754878AbcLOSwu (ORCPT ); Thu, 15 Dec 2016 13:52:50 -0500 Received: from mail-sn1nam01on0083.outbound.protection.outlook.com ([104.47.32.83]:23176 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751845AbcLOSwF (ORCPT ); Thu, 15 Dec 2016 13:52:05 -0500 X-Greylist: delayed 13116 seconds by postgrey-1.27 at vger.kernel.org; Thu, 15 Dec 2016 13:50:29 EST Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; synopsys.com; dkim=none (message not signed) header.d=none;synopsys.com; dmarc=bestguesspass action=none header.from=xilinx.com; X-IncomingTopHeaderMarker: OriginalChecksum:;UpperCasedChecksum:;SizeAsReceived:2602;Count:25 From: Appana Durga Kedareswara Rao To: Jose Abreu , "dan.j.williams@intel.com" , "vinod.koul@intel.com" , "michal.simek@xilinx.com" , Soren Brinkmann , "moritz.fischer@ettus.com" , "laurent.pinchart@ideasonboard.com" , "luis@debethencourt.com" , Anirudha Sarangi CC: "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor Thread-Topic: [PATCH 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor Thread-Index: AQHSVuWKMv099oZq9EGvoV87jhWJ2KEIoLaAgAC45RA= Date: Thu, 15 Dec 2016 18:49:50 +0000 Message-ID: References: <1481814682-31780-1-git-send-email-appanad@xilinx.com> <1481814682-31780-2-git-send-email-appanad@xilinx.com> <5f667b4f-b1f3-df34-ec0d-b62061328642@synopsys.com> In-Reply-To: <5f667b4f-b1f3-df34-ec0d-b62061328642@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.23.228.222] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22762.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-IncomingHeaderCount: 25 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39840400002)(39450400003)(39850400002)(39410400002)(39860400002)(2980300002)(438002)(189002)(199003)(51914003)(55846006)(5250100002)(3846002)(2900100001)(6636002)(54356999)(4326007)(102836003)(81166006)(23726003)(6116002)(106116001)(81156014)(8936002)(106466001)(8676002)(2201001)(38730400001)(626004)(76176999)(97756001)(2906002)(2920100001)(5660300001)(92566002)(50986999)(8746002)(46406003)(2950100002)(229853002)(33656002)(5001770100001)(47776003)(50466002)(7696004)(6862003)(189998001)(305945005)(2501003)(7736002)(356003)(63266004)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR02MB2270;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT036;1:n8UmTGPxStIgQmyXjCqjrTUlnn7TFcxnWDhZhNE5a1x00wqy21pfOUFe0FE8XXFJrjjUodq8EZuZ4fEVua7M2xse9hVYWydeXyb09TCIOfseaqgUCu2/gidu1bbUgLj7J8pe39/idu4mp3THB/pgxF8MzNuV7j2RQn0UlVw1vHXQgzlu2ybRGSHAVUe8S487i9GnPRZ0GUfslIQZ1Q+A3QHcL/q+N52SwwYhUbHHJziD0j8au5pLbppb8PijXMR0dmwjZr9u3GHozQsXHb+U58X/VuoS4rtF+MklWUnmqWe4tYAmi1i66KzSE1vsLoa+12TOSfifKkXurJefvkZAvk4JRnBTLYbRyCLVu98ericsHUKDod8LRQ7okkoUtHoznckJEuo1in6LvFZ749q2RZyWhZVh+3xV8Q+Iop8MspPoVs0dH8m9+gj3ASvSFj/fYpn3s7ck3Lny5LatEd7j3xTLwq51aT+hk4X4A4TvAmbqgpCTfXK1fKjJOJwJ6xJAkEyb7XcBzHQ4J3cFrx9KiYp9ikJtfEbzNHwfYVGoX/oHfq4aX48lLDKVcxhGSgAarot8mlu5hUt3Pf5AjNr0WxqlHj9KIgTcE7qLWHurwbi6nu68IJD8N2Stq4jMXOks X-MS-Office365-Filtering-Correlation-Id: 31ef3ce7-5bf2-4881-3b96-08d4251b290a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:MWHPR02MB2270; X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2270;3:qm5Ac8kWT2sATclCAb7fFpomEzUaQj8hxLmFYfHdf0vizm4QbhKYcael/A+QMvujJzZic4EKKpx8wIQcjAWefDf9c3Fxe5oPLLrZSw+zNSp0zdnk7dkq6bXjp307/w1c6L+q2VmAWPE65PeucDFLIE7E+xM4F9vKxU4B1q9aiEilvOseZCRhzMV2pkglhAGfq1NSzsu2iuWKS6nprl55Guz8EvZh2fssnjXWAH03KiYS0XqZCX5SvqXxiqRgaCDmLoNax4U4/ipzsPVXJJ/G8kqhwVOpCyJO0QOlYDHHI6XvuyteEft7DGjtdVCVXE6/5c//YkCh96T2CFLWMF2dFPEZJDl+SAt5i4YWD+Xy5JjEbNuEsMcTxIevbpzMMpV6I99pj3hJf+mq2HqEp8sn6A== X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2270;25:8Sg1gGmQKnIV0uoukLk6i2hR9s/JSSF03bNsRNiVZSL44Lg49coy780KoJ5EtJ3MKmqybC05X0ZpFZcYPpJShG3JSelA2PsyNZwb+U55ak/gFdaP3E/Ks58Gzj2x4cY+XOwishPpY/P+1/OUwKqLFgwa5xwKNkZQOr5CBbNLTGD3kWkhlfo+MWSUEWk1dQQxmL6Kbx7Gwu82/TJHZGgP1ENqsksWsLKqgH/a2xq9yzPZwSxQD943Wc6rY06GHYan1zO7sLjG2rRjCL0yF6+L0X0UL8t/BZ/SndtcaD/IM/YCO1cUn6C0ZfO62lvKkj5i4/l4FPGEMQwIB8hvnfb2i5XTdMb0kbIadDJAiW35SFu52CIR0owgBamX899CZKBMyd7cZ84OLdw94dNJmegSW07/WzX6fzwXUEoCRWZKGKalKacM9eBD9gAoxdYzVIiIMh+1hE+D5nPg9s3hLehYZdiOM/1/5033SDkXwNFORa8hvmRGTO+k0IGfQyeWMfFlhYkdDzrUBh/xC1LbLscrImNhKrlFqKErCmsC1iCUfH3aJTQ7FPxAylbGs02F4CJ+4al2BMRr/Xm8+dRWtIFQMEpYBQ7ZXTihs/9VF9TB+sVKmCjclhMp6NnE7DHgbfATSAn1K9SNhEmdAyCCnhPuZeATcFu+SFhCQQZL8V+gA9Ho2ck2zE3mJ6r/Gi1FFqidCLHYwYIXRbSRHFH2cHcsHAXcZqM9RmYoc9ydbZhI+I7MOKkh9IxwtiJWyLAJTYlWyUl0dxPJDQgQmzqhWnLUk+fhhMlQlULBIJe1o7ymFA3FfAN4/pxXUixCdqGLPFgq7Evz4v3gr9SIn8Ar/qj6kA== X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2270;31:Qd/UE53kWmvcsgVp4E2YJVvXVyVAHEHmO35rlm1yVcH7GIyjzI1Bm2rpj0BobvCaQYo4WSQQ0p/oXd+FiGFjZwP24xdIs9lTfxf3c+RUVYcHInZwYcp4ISCBYOVseWOmFmdjTbVy7ThKQ5zjuYmCCo4jhuJ5G+6/SY0BUfKwyQlzxstYG1nF1YNSPTOLqmDOFzyEy4gma3YaqzPNR4/yNPsOHE5CRxNYfktZJAbSV/jusii2BLACSZj3vkbmXdhReAtRQ5DZREy8F4aLQ9grJW1iGOr9f6Vjj8J4skMuRoI=;20:/IkFOUYGO5xyqeUmqX7aGKjwckBif9q+Qw2EwBkQWbk3Q0Csa50b/O3RyQvP8H4JWc46/Jag0Wa5uMTT4hLRw1GfTMTUjKbWIjT87PyHXliUAYEg8YmbCaR6ckM8uYav6MLzLqtMZjI6JhwHZcXXph94OO1ztA13j3WFEb3c6UGAH/laHbwwpGXcLK/ix50z+11OyEPJTnCuT6vYPYD/DDX73G4fjnwvb6j+ArvbXB0Qu6Ph9+PZwoT+aZ82+aIoPzqVU6g54VKeuHte7y3hD6A8laziaTckhu9p/SRl6XBf44Ifjfp+fVTcadjP0q65IhZcCsxxgnwS3DiRlQcCUXkb0/4fiDeeFXe3fTxfb6aQBXsxNwb9KX8H2n0pYZ7r7JvbmVvoy18Qw9qtG87qouWWHSupi3Pe1bj7lJezWbVWSSefXwvNhFovDsLxEvjny+dIf/YuSKAPM1oW/u2P7AE+3Zj5TAW0CZUCrDpAUQ9ZyQ+QqrokLurkEiEPSZge X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13015025)(13017025)(13024025)(13018025)(5005006)(13023025)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148);SRVR:MWHPR02MB2270;BCL:0;PCL:0;RULEID:;SRVR:MWHPR02MB2270; X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2270;4:kn1kKW58YOW8ao1sd8GdBwbaYTiLCN4VC5kgsL+7izN5BKnMLTeFgkW/E2iwLshdEZ7y3J8e2BppopS18XwyvGji0IFQy+ripGKlegsPPw4CWcpipMc3uSP59imfDo6sBZLxijScoHTJals7M7wFNKchjOi92urkW5UTqFA9Fl7Btwb04PhBuymSlQI1icbeyMMXIOtv1psfA1dmKUTy4m9/30U6cNgN/W27QjhI3wzMtL9DB3cJ0YVdaiXcDHL7I9kpFt5vljUcLUQnjZYPl4nmHv9yNZDQxfFx5z6YbIiMovKdlEiUznRdsEdmkg0Eist+r0fqCxBwt1Xr/osDFXNVlat/z/Xg9sXLAoTmKDtSZ9ydjh6I3Cvw3wawcy9jzRMk6BgLA2mbRx6P1j/ODnOqmbKaXQc9rq63x02QADSf6zqEWlnyM8+pSL9/0OYCbjJsdu/Ev3gCpDboOC1rjd25ed6ztWDyyje2g2euhRUnYs1lbn2v1qSxOsOFmZBIGSq59qpZzQdfwmv9yYO/cU60ngsZBn4gsRSrZa9iM8tlCr/O08dlmTH5PQAd0Q3rtEV/t7sJTTfNOARsj0lCYm58h7qrCW5smK+2ESwKYXn3+nDa6eMzq2GWttksdIgbQnEkyj0+Kyz2bPCnWZKNj3Qw5+nZwsAa2+ugf88Olntc84v8grZzAhfLJZztleKA X-Forefront-PRVS: 0157DEB61B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR02MB2270;23:AEUpeoP9dQH4vmoncgTDs1UbHEmt5qPh4cXDwKNYf?= =?us-ascii?Q?A7MmwdhjodrjvTNaZ6rVCbBTMxiYS1g93ckP5WYhF2jhHEE6nCQAu55QK44T?= =?us-ascii?Q?1+/bVxa3G6HVKcJkWkwAoyG3mRUxREOCxgnEhNyX5SSvBOA4tRp9S1UFUsQH?= =?us-ascii?Q?l7Flgtx0EfGtTXXXl4gTWm/b8LgyzcjQp6NCnLa8tsWu8yZNRXWjI/VCTXh8?= =?us-ascii?Q?u392czas5SCgDl0FF/S3hjbcjtWgBBsv1MzB1SjVc5SsTwlxdqAaBfHnQU8X?= =?us-ascii?Q?rZvFQAvdV5KgIzExWsWC2HPZvg1UwKL9+BuUMfvviCTZvWBP8xPoesz7bn5s?= =?us-ascii?Q?wE9ZNn9SEoebxSFD63YSrG+JW/CcaDG2ZSta9Mf7wrSYekBqKVO7hGUGbpjB?= =?us-ascii?Q?8LDcWHHNMHhfBPysTeIIYX3i+G/Y/EOa6X1vfro0tVlBFGPCDCSP2JuSFhBs?= =?us-ascii?Q?Orj3881nC+N2UP15t7APDkI+1ZRy7ImmMjlK/cCQZwf5YzrkixR0goS9ZvjV?= =?us-ascii?Q?HcL7NPWHSEj4nAxw2ANsu3OFUw8wOlHaMxW7zXQV4dT8GKCZLJVWzp1pHKV4?= =?us-ascii?Q?x9jkLn1fj2AViXto8rTLt58YIFsz+agnbDnRZ57/7r6JgjpnZfDeTfDKWIk8?= =?us-ascii?Q?RjusFuNUKxhi7mqDDmfUD2nvzkWIjdPD5fDGSA8QnfpbU1wQP2pcZ0XDgoda?= =?us-ascii?Q?CmxDuhjt18N/so8NOTBPcP16megvmxf+x45sjUjaQBEDgnVseQdZKmBNTWbD?= =?us-ascii?Q?L4nUEp0jm9BHEGAj9QKLfHNpvqdBC9JAIahIyVLHx3nwyl1Z8ZuZS8hXqbot?= =?us-ascii?Q?iUwQhuZSmlrnypAhI+yc7vDCIoxoirh/rHEWiqmKpbgBzWtqcTiTCWqNHhv/?= =?us-ascii?Q?6DVKuQmmvCKtvKfv3fZ0a/siHJio54fmonoUmnOagU4tnUXT+InvCkQBfwNq?= =?us-ascii?Q?1kVTd2F3X469CiaUphzltuQdXKV8kZtag8utcViTZG4HnB92lHJXWNcUbNlJ?= =?us-ascii?Q?XBtBqTuLoxzxax2RBvpmSJJKXs9cKspG8u0wFBNztzonniCa4cF/AILVj1Cp?= =?us-ascii?Q?Qi8IKz0wEf0H9gQ24kWHruhowzXonbP2NffZfTbobNG7G0Inu8mCBtbVp5oz?= =?us-ascii?Q?8Q/0Z2xhVYPzhOuPi25PRBkdAFd9Ew/jOiGIHxeRDqHC02GJxSLd7PXfq0kW?= =?us-ascii?Q?Tf7b40QV5NTo3ozwrpwvo21P2VchLIra9Bkhry1nBJ3nsXiZfa2rHJVfmmq/?= =?us-ascii?Q?vypCX7qgRMoYlxeSYR8HTHmgUxaKgta2WQTd+bEZUh+XnNW4GEMQYjV5nskc?= =?us-ascii?Q?sFoP93vEweBepLkybBU29KCHXCj3rzGRWqYU/IRmEW0X3WlfDQVnScfHQAgh?= =?us-ascii?Q?BEG8w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2270;6:nBshh611aUlhQCOk8Vfp7WcSSYVG0Xwpz/M3CLIIDNxQnO8LQe6W0pHzdXJVewNo/E6iweROxQceTXT8RovIc9dmBHUXAd8+ACab5vyUI+g75K7CB5gZLqXitirDrYoN53PgrYZr+jHWGNX2JS8yaMcaeN1+cGe6m6rqX6VOXNFQ24UioSaxBo/lHyyTS8g74EpFvLG2YI/W5NExmK7yxbWbauBPn+JllfVjmlbr9ynbK1f9PHN1wo7y2a7NhBGLQT4aBj8L5AId+7ekQnpVTHX3cA1FWZ5pCCbsTJpoAfiup57FUw8BmfDvp8KKW01kbu4WHBisDQYKjK2l8OAAVAsg29+qWC7ykKWNhFGnSuhXfofBog+6xLG+9y2LJIm1cg0ZU6gKaOqM+1WJe840b0WStOW4I636MG44LtIjVCc3G/zo5vArkfhkT6c5aaFARU1oUWK2p5ODvXLtZ68cgA==;5:Xm53jYHky2YYUjeWwo4blyVp7N6S0sKqaHMRqZ3TQlXXjP/+cZ/gZu1knNRJy0037rTu1ViW2/1ZDAZ0K5qpCcZrhpLo+KzoMYSVIQrdxkBu+CvWrMhp5ikJyumovxeuVXZty3pzPd64PEwjSZIi/A==;24:zoI/eRiRP7S0A8QcnSDGupKGKHFoR40xw+lamEZLx6M8G9lq2KeEGHHTzwOz4Y0FjmMLK8KnuZIKSj+XKpsygg27ygzaJ1xscP9e4c6nIdk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR02MB2270;7:YNgGTHps/Oo7jMuX37ehPl+FI7ObFgl96dVJ8UjpsBkwh91UYN1ZZfscIvIp3hreFIHDHgbBtUyd5viDTe+QgaYCDj2rOTq+QzNpnSoe+zE61MU/IyzwBFbVsZGJMY/Bp84AZxyKYHrB3PAUHCe/Y1g+uSFthVN50xTmyd3o03jvNnAc4qOqy2up2ETX1JHpIOP0u6IRODMjZZFAa95bBlveqCqdzNehaP7WdvuRGMfHntDQtsVJVd+7QcqoqERpZhmp28SIHbCSdJTup9IqqL7rIkQg3YNCkE1sDs2HmTjTPovC7+d5DXgF1qxXKerfQX3B2UrY/6pGr11oKXsL+xBBiHgPpM+0DQexrVn7edAxAEVpi4phG+R+xiAhrGxPMGmKclVXSkiYXNM7FaxLM2090VpjYb8vB3cwi5pGCJ2sRd+P5EwY1zN7ydNjmj77cLpzuklOjh2rIknU+JVcFA== X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2016 18:49:54.5213 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2270 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uBFIr8Gx023950 Hi Jose Miguel Abreu, Thanks for the review... > > + chan->idle = true; > > > > spin_lock_init(&chan->lock); > > INIT_LIST_HEAD(&chan->pending_list); > > I think there is missing a set to true in idle when a channel reset is performed. > Otherwise: Reviewed-by: Jose Abreu Sure will fix in v2... Regards, Kedar. > > Best regards, > Jose Miguel Abreu From mboxrd@z Thu Jan 1 00:00:00 1970 From: appana.durga.rao@xilinx.com (Appana Durga Kedareswara Rao) Date: Thu, 15 Dec 2016 18:49:50 +0000 Subject: [PATCH 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor In-Reply-To: <5f667b4f-b1f3-df34-ec0d-b62061328642@synopsys.com> References: <1481814682-31780-1-git-send-email-appanad@xilinx.com> <1481814682-31780-2-git-send-email-appanad@xilinx.com> <5f667b4f-b1f3-df34-ec0d-b62061328642@synopsys.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Jose Miguel Abreu, Thanks for the review... > > + chan->idle = true; > > > > spin_lock_init(&chan->lock); > > INIT_LIST_HEAD(&chan->pending_list); > > I think there is missing a set to true in idle when a channel reset is performed. > Otherwise: Reviewed-by: Jose Abreu Sure will fix in v2... Regards, Kedar. > > Best regards, > Jose Miguel Abreu