All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESENT PATCH v3] rockchip: update emmc/sd index for distro boot order
Date: Wed, 23 Jan 2019 12:00:45 +0100	[thread overview]
Message-ID: <C298767F-3246-4F53-87C2-68D255DAAA0D@theobroma-systems.com> (raw)
In-Reply-To: <CAKUh=RwHFvU0nFS+QuN9biT2ur0GjQ9BPqu8RO7vUtmKEDVoxA@mail.gmail.com>

My gut feeling would be to fix the comment only.

> On 23.01.2019, at 03:14, Kever Yang <kever.yang@rock-chips.com> wrote:
> 
> Hi Philipp, Simon,
> 
>    Is it possible for this patch to be merged?
>    Right now, two board owner does not  like this patch but both of you says this patch do not affect your board, and most of other boards are maintained by me, and I have share why I need this patch and why this patch not affect so much very clearly in previous mail.
>     Please evaluate it again and close this topic, at least the original code comment "First try to boot from SD (index 0), then eMMC (index 1) " is not correct, something must be fixed.
> 
> Thanks,
> - Kever
> 
> Kever Yang <kever.yang at rock-chips.com <mailto:kever.yang@rock-chips.com>> 于2018年11月28日周三 上午10:06写道:
> According to the emmc/sdcard index in dts alias, emmc is always 0 and
> sdcard index is 1, let's update to using correct mmc number for distro
> boot order in common header.
> 
> SD card suppost to have higher priority so that people can boot into
> the firmware in SD card, this is very convenient for developer try with
> distro img from SUSE, Fedora and etc. Developer only need to 'dd' the
> Distro image(which id download from OS vendor release) into SD card without
> any modify and then we can boot it up directly.
> 
> Signed-off-by: Kever Yang <kever.yang at rock-chips.com <mailto:kever.yang@rock-chips.com>>
> ---
> 
> Changes in v3:
> - update the commit message
> Series-changes: 2
> - update the commit message
> 
>  include/configs/rockchip-common.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
> index 68e1105a4b..8a72613e52 100644
> --- a/include/configs/rockchip-common.h
> +++ b/include/configs/rockchip-common.h
> @@ -11,11 +11,11 @@
> 
>  #ifndef CONFIG_SPL_BUILD
> 
> -/* First try to boot from SD (index 0), then eMMC (index 1) */
> +/* First try to boot from SD (index 1), then eMMC (index 0) */
>  #if CONFIG_IS_ENABLED(CMD_MMC)
>         #define BOOT_TARGET_MMC(func) \
> -               func(MMC, mmc, 0) \
> -               func(MMC, mmc, 1)
> +               func(MMC, mmc, 1) \
> +               func(MMC, mmc, 0)
>  #else
>         #define BOOT_TARGET_MMC(func)
>  #endif
> -- 
> 2.18.0
> 

  reply	other threads:[~2019-01-23 11:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28  2:06 [U-Boot] [RESENT PATCH v3] rockchip: update emmc/sd index for distro boot order Kever Yang
2018-11-28  9:15 ` Philipp Tomsich
2018-11-29  1:48   ` Kever Yang
2018-11-29  9:54     ` Wadim Egorov
2018-11-29 21:04       ` Philipp Tomsich
2018-11-30  1:27       ` Kever Yang
2018-11-30 10:26         ` Wadim Egorov
2018-11-29 21:31     ` Philipp Tomsich
2018-11-29 21:44       ` Philipp Tomsich
2018-11-29 22:01         ` Klaus Goger
2018-11-29 22:14           ` Klaus Goger
2018-11-30  2:08         ` Kever Yang
2019-01-23  2:14 ` Kever Yang
2019-01-23 11:00   ` Philipp Tomsich [this message]
2019-01-24  8:21     ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C298767F-3246-4F53-87C2-68D255DAAA0D@theobroma-systems.com \
    --to=philipp.tomsich@theobroma-systems.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.