From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbbAMEtx (ORCPT ); Mon, 12 Jan 2015 23:49:53 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:46361 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbbAMEtu convert rfc822-to-8bit (ORCPT ); Mon, 12 Jan 2015 23:49:50 -0500 From: Vineet Gupta To: Arnaldo Carvalho de Melo , Jiri Olsa CC: "namhyung@kernel.org" , "peterz@infradead.org" , "jolsa@kernel.org" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-perf-users@vger.kernel.org" , "linux-arch@vger.kernel.org" , "Alexey.Brodkin@synopsys.com" , Borislav Petkov , Cody P Schafer Subject: Re: [PATCH v2 1/5] perf tools: [uclibc] fix statfs.f_type data type mismatch build error Thread-Topic: [PATCH v2 1/5] perf tools: [uclibc] fix statfs.f_type data type mismatch build error Thread-Index: AQHQLtMB+l91Mlgr4km5caF+7jcgbQ== Date: Tue, 13 Jan 2015 04:49:42 +0000 Message-ID: References: <1420888254-17504-1-git-send-email-vgupta@synopsys.com> <1420888254-17504-2-git-send-email-vgupta@synopsys.com> <20150112110522.GC26229@krava.redhat.com> <20150113014757.GG29743@kernel.org> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.196.223] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 13 January 2015 07:18 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Jan 12, 2015 at 12:05:22PM +0100, Jiri Olsa escreveu: > On Sat, Jan 10, 2015 at 04:40:50PM +0530, Vineet Gupta wrote: > > From: Alexey Brodkin > > > > ARC Linux uses the no legacy syscalls abi and corresponding uClibc headers > > statfs defines f_type to be U32 which causes perf build breakage > > > > http://git.uclibc.org/uClibc/tree/libc/sysdeps/linux/common-generic/bits/statfs.h > > > > ----------->8--------------- > > CC fs/fs.o > > fs/fs.c: In function 'fs__valid_mount': > > fs/fs.c:82:24: error: comparison between signed and unsigned integer > > expressions [-Werror=sign-compare] > > else if (st_fs.f_type != magic) > > ^ > > cc1: all warnings being treated as errors > > ----------->8--------------- > > > > Cc: Borislav Petkov > > Cc: Jiri Olsa > > Cc: Cody P Schafer > > Cc: Arnaldo Carvalho de Melo > > Cc: linux-perf-users@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Alexey Brodkin > > Acked-by: Jiri Olsa Thanks, applied, but please do not start lines in the changelog comment with ---, that breaks some patch applying scripts. I fixed it up this time. Thx. I've udpated the changelogs so scissor lines start at column 3 with leading whitespace, is that OK or do you want me to remove those lines altogether. Also do u want me to drop this patch from v3 of series as I have some fixups for other patches. Thx, -Vineet - Arnaldo