From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Xie, Huawei" Subject: Re: [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support Date: Wed, 17 Dec 2014 17:43:12 +0000 Message-ID: References: <1418247477-13920-1-git-send-email-huawei.xie@intel.com> <548E70F6.30807@igel.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: Tetsuya Mukawa , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <548E70F6.30807-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > -----Original Message----- > From: Tetsuya Mukawa [mailto:mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org] > Sent: Sunday, December 14, 2014 10:26 PM > To: Xie, Huawei; dev-VfR2kkLFssw@public.gmane.org > Cc: haifeng.lin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org > Subject: Re: [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support >=20 > Hi Xie, >=20 > I've got warnings from checkpatch.pl. > Mostly 'over 80 characters' warnings. > (But I know these are come from original vhost-example code sometimes.) >=20 > So far, your patches are RFC, so I haven't check these strictly. Thanks. I try to, but you know sometimes 'over 80 characters' is unavoidable. >=20 > Thanks, > Tetsuya >=20 > (2014/12/11 6:37), Huawei Xie wrote: > > This patchset refines vhost library to support both vhost-cuse and vhos= t-user. > > > > > > Huawei Xie (12): > > create vhost_cuse directory and move vhost-net-cdev.c to vhost_cuse > directory > > rename vhost-net-cdev.h as vhost-net.h > > move eventfd_copy logic out from virtio-net.c to vhost-net-cdev.c > > exact copy of host_memory_map from virtio-net.c to new file > > virtio-net-cdev.c > > host_memory_map refine: map partial memory of target process into cur= rent > process > > cuse_set_memory_table is the VHOST_SET_MEMORY_TABLE message > handler for cuse > > fd management for vhost user > > vhost-user support > > minor fix > > vhost-user memory region map/unmap > > kick/callfd fix > > cleanup when vhost user connection is closed > > > > lib/librte_vhost/Makefile | 5 +- > > lib/librte_vhost/rte_virtio_net.h | 2 + > > lib/librte_vhost/vhost-net-cdev.c | 389 ------------------= ---- > > lib/librte_vhost/vhost-net-cdev.h | 113 ------- > > lib/librte_vhost/vhost-net.h | 117 +++++++ > > lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 452 > ++++++++++++++++++++++++++ > > lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 349 ++++++++++++++++++= ++ > > lib/librte_vhost/vhost_cuse/virtio-net-cdev.h | 45 +++ > > lib/librte_vhost/vhost_rxtx.c | 2 +- > > lib/librte_vhost/vhost_user/fd_man.c | 205 ++++++++++++ > > lib/librte_vhost/vhost_user/fd_man.h | 64 ++++ > > lib/librte_vhost/vhost_user/vhost-net-user.c | 423 > ++++++++++++++++++++++++ > > lib/librte_vhost/vhost_user/vhost-net-user.h | 107 ++++++ > > lib/librte_vhost/vhost_user/virtio-net-user.c | 313 ++++++++++++++++++ > > lib/librte_vhost/vhost_user/virtio-net-user.h | 49 +++ > > lib/librte_vhost/virtio-net.c | 394 ++----------------= ---- > > lib/librte_vhost/virtio-net.h | 43 +++ > > 17 files changed, 2199 insertions(+), 873 deletions(-) > > delete mode 100644 lib/librte_vhost/vhost-net-cdev.c > > delete mode 100644 lib/librte_vhost/vhost-net-cdev.h > > create mode 100644 lib/librte_vhost/vhost-net.h > > create mode 100644 lib/librte_vhost/vhost_cuse/vhost-net-cdev.c > > create mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.c > > create mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.h > > create mode 100644 lib/librte_vhost/vhost_user/fd_man.c > > create mode 100644 lib/librte_vhost/vhost_user/fd_man.h > > create mode 100644 lib/librte_vhost/vhost_user/vhost-net-user.c > > create mode 100644 lib/librte_vhost/vhost_user/vhost-net-user.h > > create mode 100644 lib/librte_vhost/vhost_user/virtio-net-user.c > > create mode 100644 lib/librte_vhost/vhost_user/virtio-net-user.h > > create mode 100644 lib/librte_vhost/virtio-net.h > >