From: "Xie, Huawei" <huawei.xie@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v2] vhost: fix mmap failure as len not aligned with hugepage size
Date: Thu, 12 Nov 2015 06:39:22 +0000 [thread overview]
Message-ID: <C37D651A908B024F974696C65296B57B4B186C54@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: 1447279449-11289-1-git-send-email-jianfeng.tan@intel.com
On 11/12/2015 1:04 PM, Tan, Jianfeng wrote:
> This patch fixes a bug under lower version linux kernel, mmap()
> fails when length is not aligned with hugepage size. mmap()
> without flag of MAP_ANONYMOUS, should be called with length
> argument aligned with hugepagesz at older longterm version
> Linux, like 2.6.32 and 3.2.72, or mmap() will fail with EINVAL.
> This bug was fixed in Linux kernel by commit:
> dab2d3dc45ae7343216635d981d43637e1cb7d45
> To avoid failure, make sure in caller to keep length aligned.
>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
Acked-by: Huawei Xie <huawei.xie@intel.com>
Next time please add --in-reply-to with original message id.
> ---
> lib/librte_vhost/vhost_user/virtio-net-user.c | 36 ++++++++++++++++-----------
> 1 file changed, 21 insertions(+), 15 deletions(-)
>
next prev parent reply other threads:[~2015-11-12 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 22:04 [PATCH v2] vhost: fix mmap failure as len not aligned with hugepage size Jianfeng Tan
2015-11-12 6:06 ` [PATCH v3] " Jianfeng Tan
2015-11-24 18:24 ` Thomas Monjalon
2015-11-12 6:39 ` Xie, Huawei [this message]
2015-11-12 11:18 ` [PATCH v2] " Thomas Monjalon
2015-11-12 12:51 ` Tan, Jianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C37D651A908B024F974696C65296B57B4B186C54@SHSMSX101.ccr.corp.intel.com \
--to=huawei.xie@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.