From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Xie, Huawei" Subject: Re: [PATCH 3/4] vhost: log vring changes Date: Wed, 9 Dec 2015 02:45:28 +0000 Message-ID: References: <1449027793-30975-1-git-send-email-yuanhan.liu@linux.intel.com> <1449027793-30975-4-git-send-email-yuanhan.liu@linux.intel.com> <20151202155405-mutt-send-email-victork@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "Michael S. Tsirkin" To: Victor Kaplansky , Yuanhan Liu Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D5D71567E for ; Wed, 9 Dec 2015 03:46:31 +0100 (CET) Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/2/2015 10:09 PM, Victor Kaplansky wrote:=0A= > On Wed, Dec 02, 2015 at 11:43:12AM +0800, Yuanhan Liu wrote:=0A= >> Invoking vhost_log_write() to mark corresponding page as dirty while=0A= >> updating used vring.=0A= > Looks good, thanks!=0A= >=0A= > I didn't find where you log the dirty pages in result of data=0A= > written to the buffers pointed by the descriptors in RX vring.=0A= > AFAIU, the buffers of RX queue reside in guest's memory and have=0A= > to be marked as dirty if they are written. What do you say?=0A= Yes, that is actually the majority of the work.=0A= Besides, in the first version, we could temporarily ignore zero copy,=0A= which is much more complicated, as we have no idea when the page has=0A= been accessed.=0A= -- Huawei=0A= >=0A= > -- Victor=0A= >=0A= >=0A= =0A=