From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Xie, Huawei" Subject: Re: [PATCH v2 1/1] doc: correct Vhost Sample Application guide Date: Thu, 10 Dec 2015 13:33:53 +0000 Message-ID: References: <1449664541-9546-1-git-send-email-bernard.iremonger@intel.com> <1449681518-27656-1-git-send-email-bernard.iremonger@intel.com> <20151210065247.GT29571@yliu-dev.sh.intel.com> <8CEF83825BEC744B83065625E567D7C219F8EC44@IRSMSX108.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C219F8ED27@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "Iremonger, Bernard" , Yuanhan Liu Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DA177559C for ; Thu, 10 Dec 2015 14:34:02 +0100 (CET) In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F8ED27@IRSMSX108.ger.corp.intel.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Iremonger, Bernard > Sent: Thursday, December 10, 2015 9:20 PM > To: Xie, Huawei; Yuanhan Liu > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 1/1] doc: correct Vhost Sample > Application guide >=20 > Hi Huawei, >=20 > >=20 > > > > I don't think that's a right "correction": vhost-swtich would fail > > > > to > > > > start: > > > > > > > > EAL: Error - exiting with code: 1 > > > > Cause: Cannot create mbuf pool > > > > > > > > As vhost-switch creates more mbuf than 1024M can hold. > > > > > > > > However, I do think that adding this option is necessary, otherwise= , > > > > all hugepages will be allocated to vhost-switch, leaving no memory > > > > for > > > starting > > > > VM at all. (And this is kind of informatin you need to put into > > > > commit > > > log). > > > > > > > > And limiting it to "1024M" is reasonable as well, so that we can ru= n > > > > it > > > on a > > > > desktop (or laptop) without too many memories. You just need fix > > > > vhost- switch example to not allocate too many mbufs by default. > > > > > > > > --yliu > > > > > > Yes the --socket-mem option is necessary. > > > I will add a note that a value of may need to be greater > > > than 1024. > > > I will submit a patch to vhost-switch to reduce the number of mbufs. > > > > > I recall we have to allocate mbufs for each queue rather than used queu= es > > only, so memory consumption depends on queue number. After that issue i= s > > fixed, I think 1024MB is enough. For the time being, you could > temporarily > > use 2048M and add an explanation. > > >=20 > I have sent a v3 of this patch which includes a note that the value of 10= 24 > may have to be increased. > I would prefer to keep the value of 1024. >=20 For FVL with more queues, I recall 1024mb isn't enough, but it is ok with a= note. :). > Regards, >=20 > Bernard.