From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Xie, Huawei" Subject: Re: [PATCH v2 4/4] virtio: check if any kernel driver is manipulating the virtio device Date: Mon, 4 Jan 2016 17:56:49 +0000 Message-ID: References: <20151222035041.GA7532@pxdev.xzpeter.org> <1451843773-103006-1-git-send-email-huawei.xie@intel.com> <1451843773-103006-5-git-send-email-huawei.xie@intel.com> <20160104092410.11311412@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Stephen Hemminger Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C1C6E91C2 for ; Mon, 4 Jan 2016 18:57:00 +0100 (CET) Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/5/2016 1:24 AM, Stephen Hemminger wrote:=0A= > On Mon, 4 Jan 2016 01:56:13 +0800=0A= > Huawei Xie wrote:=0A= >=0A= >> + if (pci_dev->kdrv !=3D RTE_KDRV_NONE) {=0A= >> + PMD_INIT_LOG(INFO,=0A= >> + "kernel driver is manipulating this device." \=0A= >> + " Please unbind the kernel driver.");=0A= > Splitting strings in general is a bad idea since it makes it harder to fi= nd log messages.=0A= > Also the first clause is lower case and the second is captialized.=0A= Got it. This is to avoid 80 char warning. Will put it in one line to=0A= make it friendly for searching.=0A= The first clause is lower is because it actually follows "%s():".=0A= >=0A= > Lastly, the backslash continuation is unnecessary here and will cause che= ckpatch warning.=0A= >=0A= =0A=