From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Xie, Huawei" Subject: Re: [PATCH] vhost: remove lockless enqueue to the virtio ring Date: Wed, 16 Mar 2016 08:20:37 +0000 Message-ID: References: <1451918787-85887-1-git-send-email-huawei.xie@intel.com> <13376800.Cqouxc5gkz@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "ann.zhuangyanying@huawei.com" To: Thomas Monjalon , "yuanhan.liu@linux.intel.com" Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id F0B4E5589 for ; Wed, 16 Mar 2016 09:20:46 +0100 (CET) Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/15/2016 7:14 AM, Thomas Monjalon wrote:=0A= > 2016-01-05 07:16, Xie, Huawei:=0A= >> On 1/5/2016 2:42 PM, Xie, Huawei wrote:=0A= >>> This patch removes the internal lockless enqueue implmentation.=0A= >>> DPDK doesn't support receiving/transmitting packets from/to the same=0A= >>> queue. Vhost PMD wraps vhost device as normal DPDK port. DPDK=0A= >>> applications normally have their own lock implmentation when enqueue=0A= >>> packets to the same queue of a port.=0A= >>>=0A= >>> The atomic cmpset is a costly operation. This patch should help=0A= >>> performance a bit.=0A= >>>=0A= >>> Signed-off-by: Huawei Xie =0A= >> This patch modifies the API's behavior, which is also a trivial ABI=0A= >> change. In my opinion, application shouldn't rely on previous behavior.= =0A= >> Anyway, i am checking how to declare the ABI change.=0A= > I guess this patch is now obsolete?=0A= =0A= How about we delay this to next release after more considerations,=0A= whether we should keep this behavior, and what is the best way for=0A= concurrency in vhost.=0A= =0A= =0A=