All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Simon Horman <horms@verge.net.au>,
	Xen-devel <xen-devel@lists.xensource.com>
Cc: Yuji Shimada <shimada-yxb@necst.nec.co.jp>
Subject: Re: [patch] HVM: Expand the number of PCI interrupts from 16 to 32
Date: Mon, 09 Mar 2009 09:17:30 +0000	[thread overview]
Message-ID: <C5DA8F2A.47F7%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <20090308234803.GA31771@verge.net.au>

On 08/03/2009 23:48, "Simon Horman" <horms@verge.net.au> wrote:

> I'm not sure what the reason for this, but the tables relating
> to PCI interrupts seem to be truncated to 15 entries. I am
> guessing that they are just incomplete and that this has never
> been an issue. This patch extends these tables to the full 32 entries.
> 
> Tested by giving an ioemu rtl8139 device pci device 24,
> which is unable to communicate with the network without this change.

The rombios.c change was optimistic (you changed the bytes-per-device value,
rather than the number-of-devices value). The rombios table actually already
only describes 6 PCI devices, and expanding it further may risk overflowing
the available space in the ROM image. Any OS we pass devices to is going to
be ACPI-enabled anyway, so it doesn't matter.

The DSDT changes had some bugs -- the LNK[ABCD] values were mostly wrong,
and the GSI values for Device 23 Links C&D were wrong.

I fixed it all up and checked it in.

 -- Keir

  reply	other threads:[~2009-03-09  9:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-08 23:48 [patch] HVM: Expand the number of PCI interrupts from 16 to 32 Simon Horman
2009-03-09  9:17 ` Keir Fraser [this message]
2009-03-09  9:20   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C5DA8F2A.47F7%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=horms@verge.net.au \
    --cc=shimada-yxb@necst.nec.co.jp \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.